- Status changed to Postponed: needs info
over 1 year ago 11:34pm 30 July 2023 - ๐ฆ๐บAustralia acbramley
The button in the screenshot has completely changed in 10.1.x since the bulk actions are now a floating bar below the view, with the submit button being a primary (blue) button. I'm not sure if this still applies to the other buttons mentioned in the IS.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
Yes the button
Apply to selected items
highlighted in the issue summary got fixed with the changes in 10.1x but for the other places the issue still applies. For example on the content listing page/admin/content
you have still the greyFilter
andEdit
buttons on white background:--button-bg-color (#d3d4d9) / --color-bg (#fff). 1.5:1
The
Edit view name /description
and theCancel
button on a Views page/admin/structure/views/view/content
have even a greyish background :--button-bg-color (#d3d4d9) / --color-gray-050 (#f3f4f9). 1.3:1
So i think the issue still applies.
- Status changed to Active
over 1 year ago 1:10am 31 July 2023 - ๐ฆ๐บAustralia acbramley
Cool! No worries, just stumbled across this as I was looking for an existing issue for ๐ Disabled primary button in views area has grey text on blue background (bad contrast) Fixed - semi related.
- ๐ฎ๐ณIndia sanket.tale
sanket.tale โ made their first commit to this issueโs fork.
- Status changed to Needs review
4 months ago 10:10am 4 July 2024 - ๐ฎ๐ณIndia sanket.tale
Created MR for the issue please review it. Thanks!
- Status changed to Needs work
4 months ago 6:57pm 21 July 2024 - ๐บ๐ธUnited States smustgrave
Summary appears to be outdated, example the "Apply to selected items" button no longer is there
Proposed solution appears to be missing.
I did test the "Filter" button and it passed contrast.
- Status changed to Needs review
4 months ago 9:26am 22 July 2024 - Status changed to Needs work
4 months ago 1:16pm 22 July 2024 - ๐บ๐ธUnited States smustgrave
Issue summary still appears to have the old screenshot. Donโt need to keep deleted text either
- Status changed to Needs review
4 months ago 1:57pm 22 July 2024 - Status changed to Needs work
4 months ago 11:25am 26 July 2024 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
4 months ago 7:25am 30 July 2024 - ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
Thanks for the work on the issue. I've taken a look at MR8662. In regards of the color contrast it looks like they meet SC 1.4.3 and 1.4.11. But the thing i wonder about is are those color choices based on the decision that resulted out of the discussions mentioned in #14 ๐ Grey button's background color has a too low contrast ratio against page background Needs review by @ckrina? cuz at the moment those aren't reflected in the drupal design system either, see https://www.figma.com/design/OqWgzAluHtsOd5uwm1lubFeH/๐ง-Drupal-Design-system?node-id=553-0
- Status changed to Needs work
4 months ago 2:44pm 2 August 2024 - ๐บ๐ธUnited States mherchel Gainesville, FL, US
Yeah, we should really not be doing development until the design is done (and it looks like it is not done).
From #14
Thanks for all for your work here, but changing the color for the main button in the UI needs one of the maintainers approval. This actually needs some design work to test how it looks in other situations too, so moving back to active since we haven't done the design round yet.
Setting this to needs work because we need designs before we can properly write the code.