- Issue created by @acbramley
- 🇦🇺Australia acbramley
It seems like this colour was intentionally set in 📌 Implement bulk operation designs Fixed - probably better to just add the :disabled classes into tableselect.css too?
54:49 53:55 Running- @acbramley opened merge request.
- Status changed to Needs review
over 1 year ago 1:24am 31 July 2023 - 🇦🇺Australia acbramley
This seems to do the trick (never done CSS changes in core so apologies if I've altered the files incorrectly 😅)
- First commit to issue fork.
- last update
over 1 year ago 29,908 pass - 🇮🇳India gauravvvv Delhi, India
The
.views-bulk-actions__item
overrides only the background color of the primary element; there is no need to modify the button's color. - First commit to issue fork.
- last update
over 1 year ago 29,908 pass - 🇫🇮Finland lauriii Finland
I pushed alternative solution to the MR that avoids copying the disabled styles to the tableselect styles.
- Status changed to RTBC
over 1 year ago 6:30am 31 July 2023 - 🇦🇺Australia acbramley
This is why I stay away from CSS 😂
Much nicer solution and works perfectly, thanks @lauriii!
- last update
over 1 year ago 29,946 pass - last update
over 1 year ago 29,946 pass - 🇺🇸United States edmund.dunn Olympia, WA
Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue.
- last update
over 1 year ago 29,952 pass - last update
over 1 year ago 29,953 pass - last update
over 1 year ago 29,953 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,967 pass - last update
over 1 year ago 30,037 pass, 2 fail The last submitted patch, 12: 3378091-disabled-primary-button-gray-text-blue-background-bad-contrast-12.patch, failed testing. View results →
- last update
over 1 year ago 30,049 pass - last update
over 1 year ago 30,056 pass - last update
over 1 year ago 30,056 pass - last update
over 1 year ago 30,058 pass - last update
over 1 year ago 30,060 pass - last update
over 1 year ago 30,063 pass - last update
over 1 year ago 30,130 pass - last update
over 1 year ago 30,135 pass - last update
over 1 year ago 30,136 pass - last update
over 1 year ago 30,132 pass, 2 fail The last submitted patch, 12: 3378091-disabled-primary-button-gray-text-blue-background-bad-contrast-12.patch, failed testing. View results →
- last update
over 1 year ago 30,148 pass - last update
over 1 year ago 30,150 pass - last update
over 1 year ago 30,161 pass - last update
about 1 year ago 30,161 pass - Status changed to Fixed
about 1 year ago 9:04pm 18 September 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 11.x and backported to 10.1.x
thanks!
-
larowlan →
committed 89e557f9 on 10.1.x
Issue #3378091 by acbramley, lauriii, Gauravvvv: Disabled primary button...
-
larowlan →
committed 89e557f9 on 10.1.x
-
larowlan →
committed 38618b1e on 11.x
Issue #3378091 by acbramley, lauriii, Gauravvvv: Disabled primary button...
-
larowlan →
committed 38618b1e on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.