πŸ‡ΊπŸ‡ΈUnited States @Zooney

Account created on 23 April 2008, over 16 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States Zooney

The sample X Carousel also works perfectly.

I've found that Splide X: Carousel fails in 2.0.9 but works in 2.0.10 (and 2.0.x-dev). I can consistently switch between those respective versions and see the breakpoint issue appear and disappear between 2.0.9 and 2.0.10.

I just noticed that when I was testing Splide X: Carousel, I had been testing it in 2.0.9. It seems to work fine in 2.0.x-dev and 2.0.10.

This issue seems to have been fixed. Thanks!

πŸ‡ΊπŸ‡ΈUnited States Zooney

Which one:
Defaults not added, or breakpoint will still have 4 images, or both?
You should focus on the second problem.

I suppose that the breakpoint still having 4 images is what is actually happening, but it seems to be that the breakpoint simply isn't working when a default value is set (e. g. perPage being set to 1). For example, I can set the perPage to 2 and the breakpoint will work, but it doesn't work when set to 1.

You are correct, and this module is too. It is exactly by design. The only reason is to save bytes when having many sliders on a page. All sliders should access the exact same defaults from a single source drupalSettings.splide, not from each data-splide. Slick has done this since 10 years ago, and no problems.

If this is true, then it's possible that the problem is occurring when the value from the drupalSettings.splide object is being applied to the breakpoints in the JavaScript code (I'm not familiar enough with the module code to see where that's happening). I can try focusing on that part of the process.

The Splide X has samples with almost similar breakpoint settings. Please install and verify it.

Do the samples also fail?

Splide X: Carousel fails. It goes from a perPage of 5 to 3 and stops at 3 when it should go to a perPage of 1.

πŸ‡ΊπŸ‡ΈUnited States Zooney

The issue still exists in the 2.0.x-dev branch.

πŸ‡ΊπŸ‡ΈUnited States Zooney

Zooney β†’ changed the visibility of the branch 3381557-formatting-lost-when to active.

πŸ‡ΊπŸ‡ΈUnited States Zooney

I've tested on drupal/core 10.1.6 and this is what happens when embedding drupal-media (using the "Insert Media" button). Note that the list isn't split into two lists. The desired behavior is to have paragraphs embedded into list item elements rather than splitting the list in two (which is how it worked in CKEdtor 4).

Before:

<ul>
    <li>
        Test1 Test2
    </li>
</ul>

After:

<ul>
    <li>
        <p>
            Test1&nbsp;
        </p>
        <drupal-media data-entity-type="media" data-entity-uuid="9c10382b-8b46-4005-8aa2-9c62e2e58b3a">&nbsp;</drupal-media>
        <p>
            Test2
        </p>
    </li>
</ul>
Production build 0.71.5 2024