Toolbar height calculation is faulty in multiple cases

Still a problem with Drupal 10.1.2 and Seven 1.0.0 (contrib)

re-rolled patch

Tried fixing CCF in #55, 55 not applied on D11, so not attaching the interdiff.

Fixed CCF failure

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Trying to fix errors reported by bot.

Seems to have caused nightwatch failures.

Converted 59 to an MR, hiding patches.

Not just nightwatch that's failing now:

Functional JavaScript:

• Drupal\Tests\settings_tray\FunctionalJavascript\SettingsTrayBlockFormTest::testBlocks
• Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderToolbarTest::testBackToSiteLink
• Drupal\Tests\contextual\FunctionalJavascript\ContextualLinksTest::testContextualLinksClick
• Drupal\Tests\toolbar\FunctionalJavascript\ToolbarHeightCalculationTest::testToolbarHeightCalculation

Nightwatch:

• Check toolbar overlap with page content

I was able to fix this issue by adding one line of css.

#toolbar-item-administration-tray.toolbar-tray-horizontal {
  height: 40px;
}