- Issue created by @jessehs
- Status changed to Needs review
11 months ago 7:07pm 18 December 2023 - last update
11 months ago 29,722 pass - Assigned to lauriii
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks for the detailed bug report! 🤩
This was added in #3278415: Remove usages of the JavaScript ES6 build step, the build step itself, and associated dev dependencies → . I don't know enough about this CSS to provide more guidance — but @nod_ or @lauriii would be able to 😊
- Status changed to Needs work
10 months ago 3:32pm 13 January 2024 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- First commit to issue fork.
- Merge request !8279Remove the offending inline style from ckeditor5.js as proposed → (Closed) created by vinmayiswamy
- Status changed to Needs review
6 months ago 8:55am 4 June 2024 - 🇮🇳India vinmayiswamy
Created MR with the proposed changes. Please review.
Thanks! - Status changed to RTBC
6 months ago 2:49pm 4 June 2024 - 🇧🇷Brazil andre.bonon
I executed the steps mentioned and applied the patch.
That works for me.
- 🇳🇿New Zealand quietone
I read the issue summary, comments and the MR. I agree with @Wim Leers in thanking @jessehs for a detailed issue summary. The MR does implement the proposed changes and testing was done in #11 confirming the fix. There are no questions unanswered.
I do have a question. Why is 'style' in the title twice? Is that necessary. Since the first style is in square brackets, is there a need for a new special issue title → ?
I also updated credit and leaving at RTBC.
- Assigned to nod_
- 🇫🇷France nod_ Lille
Issue has been on my todo for a while, getting to it. I seem to remember that the rule was useful at some point, need to dig into why
- 🇫🇷France nod_ Lille
fix is ok since 🐛 CKEditor 5 isn't respecting field widgets row settings Fixed sets a minimum height for the editor element
- 🇫🇷France nod_ Lille
Committed and pushed 766418a8d5 to 11.x and c5359f3392 to 11.0.x and dbff7d429b to 10.4.x. Thanks!
- Issue was unassigned.
- Status changed to Fixed
5 months ago 8:35am 14 June 2024 The issue outlined on addresses a crucial aspect of accessibility in directv provider Drupal's admin interface. Enhancing keyboard navigation ensures usability for all users, especially those relying on assistive technologies. This update aligns Drupal with inclusive design principles, fostering a more accessible web experience. It's encouraging to see the community prioritizing accessibility, underscoring Drupal's commitment to equitable digital access.
Automatically closed - issue fixed for 2 weeks with no activity.