- Issue created by @dan612
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Whoops! π
Ideally we wouldn't tie it to any Drupal version. Because:
- people still use AM:A with Drupal 9
- Drupal 11 is due to be released later this year
How about instead? π
- πΊπΈUnited States dan612 Portland, Maine
Updated the IS as per #2 π Update labels/verbiage to Drupal 10 throughout interface Active - for future proofing.
I think these alterations will require a ui rebuild as we need to compile the changes into ui/dist/common.bundle.js. I tried doing this locally but was hitting some issues with node versions. I think i was able to get
npm run build
to work on Node 18 (whereas node 20 was failing) - but need to run through it again to be sure π - Assigned to dan612
- Status changed to Needs work
10 months ago 10:05am 12 February 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Yes, you'll need
node
16 or 18 β quotingpackage.json
:"engines": { "node": "^16 || ^18" },
- πΊπΈUnited States dan612 Portland, Maine
Leave it to me to not read instructions π
There were a few places where "modern Drupal" didn't fit...it read awkwardly. I tried to update things within context to what seemed fit π
Couple screenshots of the changed ui:
- πΊπΈUnited States dan612 Portland, Maine
Pipelines is quite angry with me but im not sure if that much noise is normal or not π¬
- Status changed to Needs review
10 months ago 10:18pm 12 February 2024 - Issue was unassigned.
- Status changed to RTBC
10 months ago 10:57am 16 February 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Pipelines is quite angry with me but im not sure if that much noise is normal or not π¬
There's some contrib test failures, but they cannot be related to this. These are upstream regressions. They're happening against
1.9.x HEAD
too.I'll try to get those fixed next week.
This looks great! π
-
Wim Leers β
committed da892dae on 1.9.x authored by
dan612 β
Issue #3420277 by dan612, Wim Leers: Update labels/verbiage to Drupal 10...
-
Wim Leers β
committed da892dae on 1.9.x authored by
dan612 β
- Status changed to Fixed
10 months ago 10:57am 16 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.