- 🇦🇺Australia mstrelan
This needs an issue summary update, let's start with the standard issue template. I think it's also not clear from the title what is the bug that needs fixing, i.e. the
is-active
class is not added. Let's get 2525830-18-комацу.patch converted to an MR so we can see the test fail, then we can work on a fix for this. - Merge request !12140Issue #2525830 by tr: Test-only patch - is-active class not set when UTF-8... → (Open) created by tr
- 🇦🇺Australia mstrelan
The test results in #18 demonstrated the bug for many years, until patch testing got turned off.
I'm not disputing that, just trying to help make it easier for anyone interested in picking this up. Without this it's hard to know at a glance if anything has changed in core that might have fixed this over the last 5 years.
- 🇦🇺Australia mstrelan
Thanks for updating this. I'm still confused about the steps to reproduce. If I understand correctly from #3 and #8, the HTML output is correct and the JS needs to be updated. The proposed resolution is to make the Unit test pass, but that's contradictory to the above. We probably need a FunctionalJavascript test instead. I note that we now have
\Drupal\Tests\system\FunctionalJavascript\ActiveLinkTest
which seems like a good place to test this. I tried to follow the suggestion in #8 but active-link.js has changed quite a bit so it wasn't straight forward.