Get rid of jQuery in displace event

finnsky → changed the visibility of the branch 3446855-get-rid-of to hidden.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Wasn't entire sure how to test this one.

I applied the MR and tested on a view page which has dialog and didn't see any issue
If any other recommendation can try that.

Did leave a comment on the MR for deprecation version.

I have addressed the mentioned feedback. While updating, I also noticed that the dialog-deprecation.js file had the same issue in line state 12.0.0, so I updated that as well. Please review.

RE: #11

For test you may revert this MR changes in toolbar.js locally. and when you will open close toolbar on desktop it will trigger deprecation messages.
Also you need to set drupalSettings.suppressDeprecationErrors to true. Easiest way to do it
core/misc/drupal.js:564 in Drupal.deprecationError remove this condition

`drupalSettings.suppressDeprecationErrors === false &&`

Seems to have a few test failures

Thanks for taking care of that version update for the deprecation message.

We have broken test in navigation module. If 2 or more data-once attributes presented. Fixed here.

Believe feedback has been addressed. Tested same way as did in #11

@finnsky, Thanks for the continued work on javaScript,

The first thing I did was change the format of URL is issue summary so I can read the issue title. There is no proposed resolution to explain the scope of this change. Is it everywhere in core or not? But I am more concerned about the testing. There are steps for testing but they are different than the steps #15. And neither of those are what was done to test this issue. Because of that I am setting to NW for manual testing and updated the remaining steps.

Also, I read the change record and changed some formatting. Why is it ticked that this impacts "Site builders, administrators, editors"?

This is a child of a critical task.

Now CR:
Impacts:
Module developers
Themers
Distribution developers

Sorry for the delay, keeping the review queue below 200 has been a battle. But there appears to be test failures that when I re-run still fail.

Pretty stupid test failure.
We check

[data-once="admin-toolbar-document-triggers-listener"]

even though we should

[data-once*="admin-toolbar-document-triggers-listener"]

because in this task data-once has two values

Please review!

Again sorry for the delay, really been struggling with the queue lately. But the javascript failure seems related. re-ran 3 times.

Saving credit for @finnsky and @shalini_jha for the work

I don't get it.
Nightwatch task fails at the end for a strange reason.