- ๐ท๐ธSerbia finnsky
This hits performance mostly because I've added lost drupal/message dependency
- ๐บ๐ธUnited States smustgrave
The fact this seems to hit performance is it still a task to do?
- ๐ท๐ธSerbia finnsky
I also added an experimental branch with web components. I believe that since Umami is an experimental topic, we can easily try this technology here. Browser support suits us.
The benefits we are achieving now:
- Both message methods (Drupal render and javascript theme function) use the same template.- Drupal has an example of using web components in its core and keeps up with the times
Please review!
- @finnsky opened merge request.
- ๐ท๐ธSerbia finnsky
One more bug.
Seems messages_list wrapper missed. So new messages added directly inside existing message
https://gyazo.com/dff6c11b71c3fbe18661379e45e01b8f - @finnsky opened merge request.
- ๐ท๐ธSerbia finnsky
Found one more bug. When Login with wrong password.
https://gyazo.com/6e5b6146b61a8d1d65249614dcb67f78
It not happends on
1. Olivero because it attaches library in template
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/themes/oliver...2. Claro because it has direct dependency
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/themes/claro/...Gonna add dependency aswell.
- First commit to issue fork.