- Issue created by @finnsky
- Merge request !8047Issue #3439909 by SolimanHarkas, vensires: Fix Taxonomy tests that rely on... β (Closed) created by finnsky
- π·πΈSerbia finnsky
finnsky β changed the visibility of the branch 3446818-dialog-posit to hidden.
- π·πΈSerbia finnsky
finnsky β changed the visibility of the branch 3446818-replace-dialog-position to hidden.
- π·πΈSerbia finnsky
finnsky β changed the visibility of the branch 3446818-dialog-posit to active.
- π·πΈSerbia finnsky
finnsky β changed the visibility of the branch 3446818-dialog-posit to hidden.
- Merge request !8048Replace dialog positioning with floating-ui - #3446818 β (Open) created by finnsky
- Status changed to Needs work
6 months ago 1:43pm 13 May 2024 - π«π·France nod_ Lille
haven't tested it yet but code looks good, I'm +1 on using floating ui for that
- π¬π§United Kingdom catch
I think this is a good idea, and I think it's fine if core uses internal libraries more than once.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Should we also consider anchor position with a polyfill now it's in chrome and Firefox has also signalled intent to ship? There's a polyfill from oddbird
- π«π·France nod_ Lille
Since we use jQuery UI we have to use some js for positioning. If we had native dialogs it would be easier to go with css-onlu for positioning.
- π·πΈSerbia finnsky
I like CSS-only positioning. But what about
1. my/at/flip in https://api.jqueryui.com/position/ ?
2. also not clean how to set maxWidth etc.Floating UI seems allows to keep all previous features.
- π·πΈSerbia finnsky
finnsky β changed the visibility of the branch 3446818-dialog-floating to hidden.
- Status changed to Needs review
3 months ago 3:08pm 17 August 2024 - Status changed to Needs work
3 months ago 2:48pm 23 August 2024 - πΊπΈUnited States smustgrave
MR appears to have some failures
Removing the beta targets since we missed that boat.