Claro's action links are not placed inside the modal action

+.ui-dialog-buttonpane .form-actions .action-link {

Still needs claro maintainer review but know they are moving towards updating the pcss.css files.

So think this should be using nesting.

Let me work on #34.

Improved nesting as per #34, Attached interdiff for same.

@Gauravvv Thanks for the work. I have Reviewed the patch on drupal 10.1.x. The patch was successfully applied. Now I am able to see the nesting in the "action-link.pcss.css" file. I have attached the screenshot for reference.

So making the selector less specific could be an issue, on the other hand I haven't seen a random link added to form-actions that's not form specific so I would say it's fine.

If that's a no go instead of a class we should add a data attribute for the JS to do it's thing since that's how we've decoupled style from function for a while now.

The last submitted patch, 37: 3191360-37.patch, failed testing. View results →

Random failure but leaving in NW per #40

Hi, I've updated the patch for current 10.1.x.

Re-rolled the patch for the latest 10.1.x. As patch in #44 did not apply. Please review.

@Suresh Prabhu Parkala: the patch you've provided is the copy of #44.

Tried to fix CCF in #44.

@_utsavsharma what's the difference between #44 and #47? Did you simple move the code to create a patch?

@FiNeX the patch failed the custom command as your css file was not getting compiled and throwing error. So i compiled the pcss folder.

This bug was fixed as part of 🐛 Claro's action links are not placed inside the modal action Closed: outdated .