Merge Requests

Recent comments

🇮🇹Italy FiNeX

Hi, after updating to Drupal 10.3, the CkEditor inside Layout Builder iFrame Modal works fine and I don't need anymore this patch.

🇮🇹Italy FiNeX

Hi, thank you for the patch. It works correctly. Tested on three websites without any issue.

🇮🇹Italy FiNeX

Hi, the MR 34 fixed the problem. Thank you very much.

🇮🇹Italy FiNeX

Fixed typo.

🇮🇹Italy FiNeX

Fixed typo in title

🇮🇹Italy FiNeX

Uniformed formatting and added missing link.

🇮🇹Italy FiNeX

Added missing "()".

🇮🇹Italy FiNeX

Hi, will this feature will be backported on current stable 6.x version?

🇮🇹Italy FiNeX

The proposed merge request only partially resolves the bug. If the window is wide enough it works, but below 1024px it does not.

🇮🇹Italy FiNeX

Hi, until the bug is not solved please add a warning on the description in the module page. Thank you.

🇮🇹Italy FiNeX

Hi, the patch works fine. Thank you.

🇮🇹Italy FiNeX

Hi, I'm experimenting with an hardcoded JS workaround. I've created two "background" crop types (landscape and portrait). If on the field formatter one of those preset is enabled, then on the JS i simply check the window size and eventually swap the crop type.

This is a simple example code I've put on drimage.js on Drupal.drimage.renderEl before setting the imgUrl variable:

if (iwc == "crop_landscape_background" || iwc == "crop_portrait_background"){
  if (window.innerHeight < window.innerWidth) {
    iwc = 'crop_landscape_background';
  }
  if (window.innerHeight > window.innerWidth) {
    iwc = 'crop_portrait_background';
  }
}

This approach is quite simple and it only needs a "portrait crop style" setting on the field formatter in order to be more dynamic instead of hardcoded.

What do you think? It could be an easy solution until a more flexible solution will be implemented. Let me know.

🇮🇹Italy FiNeX

Hi, the proposed patch just add some comments and does not modify anything relevant. It does not look as an improvement. Do you plan to create a valid patch to the issue? Thank you.

🇮🇹Italy FiNeX

Yeah, I know: when the revisions are enabled the procedure I've developed breaks the revisions system.

The main problem I'd like to solve is when you have to delete a block type but you can't delete a node. In this situation the orphaned entry will prevent to delete the block type. You have to delete all the old revisions and after delete the block instance from the database.

🇮🇹Italy FiNeX

Hi, I'm also interested on a solution to enable different crop types based on screen size/orientation.

🇮🇹Italy FiNeX

Hi, I confirm that PNG format works fine, it should be added the option to set the background color when using jpg format instead of using the black default color.

🇮🇹Italy FiNeX

Hi, after a bit of testing I realized that, in my case, the problem was related to twig debugging. In fact, in the development environment I have twig debugging active and therefore the empty fields are also visible, while in production, with debugging deactivated, the empty fields are correctly hidden.

🇮🇹Italy FiNeX

@robcarr: the search works fine except it is not integrated with options like "Jump directly to the first search result even when there are multiple results"

🇮🇹Italy FiNeX

Hi, with latest release (1.2.0) I'm not able to reproduce this issue anymore. Probably with the new API the type is always available. I've tried all custom types from Brevo and now it's ok.

🇮🇹Italy FiNeX

In my opinion this should be a configurable behavior. We should let the site owner to decide how to manage this situation. It should be an option on the handler settings: allow or deny submission when data is already present on Brevo. If the user is allowed no warning are shown, it should simply be logged on watchdog. With the deny option instead it should be printed a message and blocked the redirect.

🇮🇹Italy FiNeX

Hi, I've created the following issue with a patch to also solve this problem: https://www.drupal.org/project/sendinblue_api/issues/3432945 🐛 Module does not work out of the box. Update to Brevo API and fix Webform handler Active

🇮🇹Italy FiNeX

Hi, I've found a couple of related issues which could be considered when fixing this request.

🇮🇹Italy FiNeX

Hi, I've seen a 3.x version. Is this issue still valid?

🇮🇹Italy FiNeX

Hi, I cannot reproduce the bug on the latest version. Maybe it has been solved on 2.x version?

🇮🇹Italy FiNeX

I've updated the patch, the previous was incomplete.

🇮🇹Italy FiNeX

Hi, I've updated the patch.

🇮🇹Italy FiNeX

Thank you for the patch. Will be included in a stable release?

🇮🇹Italy FiNeX

Hi, could this patch considered as "safe" for production environment or is still under development? Thank you very much.

🇮🇹Italy FiNeX

Hi, I'm also experiencing this issue. Changed field type from blob to mediumblob temporary fixed it. A

🇮🇹Italy FiNeX

Hi, patch #3 works fine on D10.2.2. Thank you very much.

🇮🇹Italy FiNeX

Hi, I confirm the bug is no more reproducible on D10.2.

🇮🇹Italy FiNeX

FiNeX made their first commit to this issue’s fork.

🇮🇹Italy FiNeX

I've tested the patch and it looks fine. Thank you.

🇮🇹Italy FiNeX

Hi, this solution works fine for new installations, but what if meanwhile I've updated the paragraph after the installation? The "config/install" yml are parsed only at module installation. To update paragraph settings you're forced to use hook_update_N() which is quite convoluted especially if you add a lot of fields.

🇮🇹Italy FiNeX

Hi, the patch works fine with "unformatted list". Do you have a plan to fix the "HTML list" format too?

🇮🇹Italy FiNeX

Hi, I've created a new clean site and the option works fine. I'll check again the other site to find the differences. Thank you.

🇮🇹Italy FiNeX

Hi, the patch works fine. Thank you!

🇮🇹Italy FiNeX

Hi, I'm sorry but I'm not using mailchimp anymore so I can't test this issue.

🇮🇹Italy FiNeX

Parent content if I remember correctly.

🇮🇹Italy FiNeX

@mmbk: hi, I did not see your comment. The patch is the same. So we can close this bug as duplicate ok?

🇮🇹Italy FiNeX

Thank you for the patch. I want to add the log could also allow to ban the IP using autoban module. Meanwhile I've updated the patch against the current release.

🇮🇹Italy FiNeX

Hi, the patch is fine. Would be possible to update the module? I've tested the latest image_effects with file_mdm 3 and it works correctly.

🇮🇹Italy FiNeX

Hi, the bug is not relevant: it was an error on the database: empty values does not have a record on the table.

🇮🇹Italy FiNeX

Hi, until the module will not be fully fixed, I've created a temporary patch to fix the missing requirement.

🇮🇹Italy FiNeX

Hi, I'm reopening the bug because the node title field size is varchar(255).

🇮🇹Italy FiNeX

@jsacksick see comment #4. It looks a bug to me. Why a payment should be a config and a shipping an entity? What's the logic?

🇮🇹Italy FiNeX

Hi, I'm on the same situation. Please, would be possible to provide a robust solution to fix this issue?

Production build 0.69.0 2024