Remove dependency on jquery_ui_datepicker

MR !17 merge error

MR needs to get rebased on current 5.x. Should we also cherry-pick the commit into 6.x? I guess that would make sense?

Changing version to 5.x for now, but my question still stands.

I rerolled the MR 17 patch for 6.0.x. It failed for the composer.json and the README (change from txt to md extension).

Fixed overlapping of update functions.

We shouldn't work with patches here, as we are already have implemented the changes in our issue fork. @rcodina could you update this issue fork's "3210945-remove-dependency-on" branch with your changes from #19 and #20? Or provide an interdiff between patch 19 and "3210945-remove-dependency-on"?

It would still make a lot of sense to remove the jquery datepicker and replace it by the native HTML5 date selector. More lightweight, standard and less issues on our side.

@Grevil what was the reason to use 8.x-5.x instead of 6.x?

Re #10 regarding ✨ [PP-2] Use form element of type date instead textfield when selecting a date in an exposed filter Needs work I think that issue is PP-2 and will need loooooooong until being resolved. So we should do here, what we can and solve that part in a follow-up. jQuery datepicker is old, ugly and no more required here. Anyone agrees we should finish this?

@Anybody, honestly, I have no idea. Let's target 6.0.x!

Alright, I applied the rerolled patch by @rcodina on the newly created branch "3210945-remove-dependency-on-6.0.x".

Please review MR 39.

LGTM!

@Grevil: Could you please test this in some combinations in the view and post a screenshot of the HTML5 datepicker shown? Also please try that it works in the expected formats, which means, ensure that the view returns the expected results from the date filter.

If you need further information, don't hesitate to contact me personally ;)

Back to "Needs work" there is no "datepicker" option.

Oh my bad, didn't realise, that this patch requires the core patch provided in ✨ [PP-2] Use form element of type date instead textfield when selecting a date in an exposed filter Needs work !

It works alright. The date picker is way to specific. E.g. when filtering content based on the updated date, we also need to specify an exact time (with seconds), which won't do the trick here. But this should be discussed in the parent issue.

Here are some impressions:

But as the core patch is required, we should postpone this issue for now anyway.

POSTPONED on: ✨ [PP-2] Use form element of type date instead textfield when selecting a date in an exposed filter Needs work .

So since core can be slower there anything we can do here instead to drop the crud of jquery.

Actually lets do that. Just a simple filter for "Date" that uses a basic template OR we update the default filter that if it's a date field to set the type "#date"

Dealers choice

Only concern is if this could break existing sites maybe I start a 7.0.x branch for deprecations.

Started a 7.0.x branch so this can continue.

Sorry for the noise.

We have removed jquery_touch and have up for removal removal of jquery_slider

Leaves just this one but seems it's really blocked on a core issue that's stalled.

So lets handle ourselves here 📌 Add support for input type "date" Active . Then we update jquery plugins to use this and should be min disruption.

smustgrave → closed merge request !17

Tried a different approach were we keep the filter but instead of relying on jquery it adds the attribute of type date.

Hi, will this feature will be backported on current stable 6.x version?

Plan is to merge this change into 6.0.x then in 7.0.x remove from the composer file.

smustgrave → closed merge request !39

smustgrave → closed merge request !73

Bad form on my part I admit. But I went ahead and merged so that can get 7.0.x ready for a D11 release.

Shouldn't the 'datepickers' library (js/bef_datepickers.js) also be removed within this change?
Or am I missing something?

No the library is the same. It’s just now using non jquery plugins.

Ok thanks for the clarification. Misinterpreted the change then.

Automatically closed - issue fixed for 2 weeks with no activity.