🇷🇸Serbia @super_romeo

RouteBuilder::rebuild() is called once for every module change. Is there a memory leak in here somewhere?

I think so. In our case, the increase in memory consumption for each module to be installed when RouteBuilder::rebuild() is called is 100MB.
ModuleInstaller::install() is called sequentially for each module, rather than passing an array of modules.

Drupal 10.3. Still no solution.

super_romeo → created an issue.

Thank you, @divyansh.gupta!
Works as expected :)

Version 2.1.0 still uses version 3:

"require": {
    "drupal/field_group": "^3.0"
  }

Is that how it's supposed to work?

super_romeo → created an issue.

I solved it!
Leave "Alias" fields empty in "Data export: Row style options" dialog (Format/Show/Settings).
+ For all fields fill checkbox "Create a label" and set Label name.

I solved it!
Leave "Alias" fields empty in "Data export: Row style options" dialog (Format/Show/Settings).
+ For all fields fill checkbox "Create a label" and set Label name.

Yes, it's still the issue.

super_romeo → created an issue.

super_romeo → created an issue.

The following notices appears during the exporting to file:

/var/www/html/rn $ drush views_data_export:views-data-export view_id display_id file.xml
[notice] Starting data export ..
> [notice] Batch process has consumed in excess of 60% of available memory. Starting new thread
> [notice] Batch process has consumed in excess of 60% of available memory. Starting new thread
> [notice] Batch process has consumed in excess of 60% of available memory. Starting new thread
> [notice] Batch process has consumed in excess of 60% of available memory. Starting new thread
> [notice] Data export saved to private: //content_export/content-pages-for-google-ads/content-pages-for-google-ads.xml
[success] Data export finished.

Indeed memory consumption during batch calls grows. But this does not happen if you follow the link in the view and generate the file there. There are batch calls there too, but memory consumption does not grow at all.

@sirclickalot I'd like to upgrade to version 4 too, but the simple_multistep model uses version 3 ( https://www.drupal.org/project/simple_multistep/issues/3507839 ✨ Compatibility with field_group 4.0.0-alpha1 Active ). So I am forced to use version 3.

super_romeo → made their first commit to this issue’s fork.

Same problem on PHP 8.2. Drupal 10.2.8.
Any plan?

@eelkeblok Sorry, I mean MR 34.

Small fix.

@sstapleton please see my changes in patch.

One more thing.
On line $uri = $file->getFileUri();:

/var/www/html $ drush @rn views_data_export:views-data-export content_pages_for_google_ads data_export 345.xml
[notice] Starting data export..
> [warning] Undefined variable $file DataExport.php:938
> [26-May-2025 14:22:22 UTC] Error: Call to a member function getFileUri() on null in /var/www/html/modules/contrib/views_data_export/src/Plugin/views/display/DataExport.php on line 938

And another issue.

I execute command drush views_data_export:views-data-export content_pages_for_google_ads data_export and file
private://views_data_export\content_pages_for_google_ads_data_export\1-1748266716\filename.xml was created and never moved to the right place.

It's because in DataExport::processBatch() in line $options = $view->getStyle()->options; variable $options was overwritten.

Thank you for your work.

But I have error on using patch #34 on line

// @phpstan-ignore-next-line
return \Drupal::service('file.repository')->writeData('', $destination, FileExists::Replace);

Error:
> > [26-May-2025 13:06:31 UTC] Error: Class "Drupal\Core\File\FileExists" not found in /var/www/html/modules/contrib/views_data_export/src/Plugin/views/display/DataExport.php on line 1078 #0 /var/www/html/modules/contrib/views_data_export/src/Plugin/views/display/DataExport.php(800): Drupal\views_data_export\Plugin\views\display\DataExport::getTempFile(Object(Drupal\views\ViewExecutable), 'content_pages_f...', 'data_export')
> > #1 /var/www/html/vendor/drush/drush/includes/batch.inc(257): Drupal\views_data_export\Plugin\views\display\DataExport::processBatch('content_pages_f...', 'data_export', Array, Array, 112100, Array, '', Array, Array)
> > #2 /var/www/html/vendor/drush/drush/includes/batch.inc(204): _drush_batch_worker()
> > #3 /var/www/html/vendor/drush/drush/includes/batch.inc(75): _drush_batch_command('329028')
> > #4 /var/www/html/vendor/drush/drush/src/Commands/core/BatchCommands.php(25): drush_batch_command('329028')
> > #5 [internal function]: Drush\Commands\core\BatchCommands->process('329028', Array)
> > #6 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array(Array, Array)
> > #7 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback(Array, Object(Consolidation\AnnotatedCommand\CommandData))
> > #8 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter(Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
> > #9 /var/www/html/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(387): Consolidation\AnnotatedCommand\CommandProcessor->process(Object(Symfony\Component\Console\Output\ConsoleOutput), Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
> > #10 /var/www/html/vendor/symfony/console/Command/Command.php(326): Consolidation\AnnotatedCommand\AnnotatedCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
> > #11 /var/www/html/vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
> > #12 /var/www/html/vendor/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(Consolidation\AnnotatedCommand\AnnotatedCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
> > #13 /var/www/html/vendor/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
> > #14 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(110): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
> > #15 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
> > #16 /var/www/html/vendor/drush/drush/drush.php(139): Drush\Runtime\Runtime->run(Array)
> > #17 /var/www/html/vendor/drush/drush/drush(4): require('/var/www/html/v...')
> > #18 /var/www/html/vendor/bin/drush(119): include('/var/www/html/v...')
> > #19 {main}

I have Drupal 10.2.8.

"You can configure a field and disable it there" - AFAIK it's possible to enable/disable translating of entire field. Not specific field properties.
We are translating city and address lines.

Thank you for quick fix! 🙂

super_romeo → created an issue.

super_romeo → created an issue.

Thanks for the patches #12 and #14. They are on the right track.
But I think we need to set the responsive image style, not the image style.

The problem is that when job and job_item are deleted, the corresponding items for processing remain in the queue. These queue items should also be deleted.
This bug has been fixed. Don't forget to do drush updb

super_romeo → created an issue.

super_romeo → made their first commit to this issue’s fork.

Is it possible to set the desired locale value for reverse geocode?

super_romeo → created an issue.

#8 worked for me. D10.4

Got it. Thank you @penyaskito!

I can't figure it out. The Role field is not present in version 2. Why? Should I add it my myself somehow?

super_romeo → created an issue.

super_romeo → created an issue.

Need to replace
unset($delta_values['_weight']);
with
unset($delta_values['_weight'], $delta_values['_actions']);
To make the search for empty fields work properly.

super_romeo → changed the visibility of the branch 3482809-saves-unchecked-checkboxes to active.

super_romeo → changed the visibility of the branch 3482809-saves-unchecked-checkboxes to hidden.

super_romeo → created an issue.

Same thing with dev-version.

@jcontreras, you are welcome!

Hello @jcontreras,
please check.

Tests as a bonus :)

Working on patch now.

Can I hope to have this problem fixed in the future? So that I can plan.

I added branch "3261708-a-separate-permission-" (please rename it to "3261708-a-separate-permission-without-administer-users") same to "3261708-a-separate-permission". MR18.

super_romeo → made their first commit to this issue’s fork.

"Hide for the listed pages"

/trains/order/*/timetable
/trains/order/*/timetable2
/trains/order/*/passenger
/trains/order/*/payment

And block is hidden on /order/modification/3/aa7e50fddf30b0a5384b4b44c916f5c3/passenger.

I think wildcard /trains/order/*/passenger wrongly applied to this path.

Thank you. Got it.
Now all good except "Site branding block is still disappeared".

Thank you for update.

1. "Site branding" block is still disappeared.

2. "Site branding" block config fixed.

3. Cases:
a)

!/order/*/*
/order/*/complete

/order/1/foo - hidden (OK)
/order/1/complete - visible (OK)

b)

/order/*/complete
!/order/*/*

/order/1/foo - hidden (OK)
/order/1/complete - hidden (wrong)

I believe the path order should not depend on the path order.

I installed new version. And my Site branding block is disappeared. And contextual menu is corrupted.
Please see pics.

Thank you very much. I'm looking forward to it.

This case is covered by Condition Path → module (see "Example 2").

Thank you for answer.

But I wanna keep "Show for the listed pages" mode, because I know exactly only paths to show.
My code:

/order/*
!/order/*/*
/order/*/complete

Is it possible?

super_romeo → created an issue.

super_romeo → created an issue.

I tried patch #34. In my case it doesn't fully work.

My menu tree:
...
- item 4
-- item 41
--- item 411
--- item 412
--- ...

-- item 42 (disabled)
--- item 421
--- ...

-- item 43
--- item 431
--- item 432
--- ...

Expected:
...
- item 4
-- item 41
--- item 411
--- item 412
--- ...

-- item 43
--- item 431
--- item 432
--- ...

Got:
- item 4
-- item 43
--- item 431
--- item 432
--- ...

Tried to debug, but without success.
Something wrong in this part:

if (!empty($tree_parent['depth'])
  && $tree_link_definition['depth'] > $tree_parent['depth']
  && $tree_link_definition['parent'] !== $tree_parent['id']
) {
  return $tree;
}

My workaround: don't use OnlyEnabledLinks() and filter the disabled items in the recursion loop.

super_romeo → changed the visibility of the branch 3411311-Collapsed_paragraph_cannot_be_opened_within_the_IEF_on_a_translation_page to hidden.

I created the issue: The translation page does not correctly display paragraphs within the IEF 🐛 The translation page does not correctly display paragraphs within the IEF Active

super_romeo → created an issue.

super_romeo → created an issue.