In
#2537732: PluginFormInterface must have access to the complete $form_state (introduce SubFormState for embedded forms) →
, the SubFormState class was introduced for BlockPlugin's build/validate/submit callbacks, and additionally $form['settings'] (the sub form array) started getting passed to the build/validate callbacks, but not to the submit callback!
That means that $form is different in these two callbacks for everyone writing a BlockPlugin:
($form is $form['settings'] here)
public function blockValidate($form, FormStateInterface $form_state) {
($form is the complete/parent form here)
public function blockSubmit($form, FormStateInterface $form_state) {
We should fix this so that the $form argument passed to these callbacks is consistent.
Review the patch.
None.
The sub form is now passed to BlockPlugin's submitForm method, instead of the complete/parent form.
None.
Needs work
11.0 🔥
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.
The major change should have a special release note written to summarize the importance of the change. See Write a release note for an issue.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
@super_romeo please edit the merge request so that it targets 11.x.
I have updated the contents of the merge request so that they are on top of 11.x.
Tim Bozeman → made their first commit to this issue’s fork.