- Issue created by @bcobin
- Status changed to Postponed: needs info
about 1 year ago 2:31pm 21 June 2023 - 🇺🇸United States agentrickard Georgia (US)
What version of PHP is this? What version of Drupal?
- Status changed to Needs review
about 1 year ago 2:42pm 21 June 2023 - last update
about 1 year ago 93 pass - 🇺🇸United States agentrickard Georgia (US)
This looks like strict type checking for two parameters that were added in Drupal 10.
- last update
about 1 year ago 93 pass - last update
about 1 year ago 93 pass - 🇺🇸United States bcobin
UPDATE: If you try invoking on all displays in a given view, it instanciates on only the targeted view and content fails to display. If you invoke on individual displays, though, it seems to work fine.
I'll take it. Thanks!
- Status changed to RTBC
12 months ago 6:29am 29 June 2023 - 🇩🇪Germany diqidoq Berlin | Hamburg | New York | London | Paris
Confirm it as RTBC. Apart from that a notice of importance: in circumstances it can become a deal-beaker for updating Drupal from 9 to 10 since the database update required will trigger this issue and break the final db update. Applying the patch and re-trying to update database after core and modules update runs complete without flaws. 1+ for this issue fixed so quickly!
- First commit to issue fork.
- last update
8 months ago 93 pass - First commit to issue fork.
- last update
8 months ago 93 pass - last update
8 months ago 93 pass - 🇮🇳India ash2303
While patch #4 works fine, I think we don't need to re-declare properties again.
Updating patch, hope it works! - 🇦🇹Austria drupalfan2
I needed patch #15 in order to get it run after Drupal 10 Upgrade.
Patch #4 is also working. - Status changed to Needs work
8 months ago 2:57pm 14 November 2023 - 🇺🇸United States agentrickard Georgia (US)
The two patches need to be reconciled, since #15 is actually a different issue.
- 🇬🇧United Kingdom BWilliams1992
Tested on Drupal 10.1.6 after upgrade from Drupal 9.5.11 and patch #4 worked
Php version 8.1.18
10.3.27-MariaDB
nginx/1.17.10 - 🇮🇳India ash2303
Both patches will work fine.
#4 was created before base class is updated
#15 is created after base class is updatedSo as per latest base class change we need patch #15, we don't need to re-declare base class properties.
- Status changed to Needs review
7 months ago 9:45pm 29 November 2023 - 🇺🇸United States agentrickard Georgia (US)
I see the problem.
https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/modules/view...
https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/modules/vie...This was fixed in Drupal core, v 10.x (patch 15). If we commit that, we may break BC with Drupal 9.5, which does not have that (patch 4).
I think the best option is to commit #15. But that might throw some warnings on PHP 8.2 / Drupal 9.5. Not sure we can do anything about that.
- First commit to issue fork.
- Status changed to RTBC
4 months ago 12:00pm 8 March 2024 - Status changed to Needs review
24 days ago 8:19am 2 June 2024 - 🇩🇪Germany diqidoq Berlin | Hamburg | New York | London | Paris
Thanks for all the work in here. But - Please do not review your own work. First of all patches and merges should be made against latest dev. Second, there are no further comments if anything of #20 & #21 has been addressed yet. Also I would like to read opinions if the attempts here overlap somehow with: 🐛 Fatal error: Type $value_value must be string DomainAccessCurrentAllFilter.php on line 0 RTBC
- Status changed to RTBC
12 days ago 9:50pm 14 June 2024 - 🇺🇸United States capysara
I'll try to summarize the current status.
I'm hiding the patches to avoid confusion going forward.
The current MR just applies the patch from #15 and moves it into a MR. That should address #20 "one clean patch." I'm assuming that the comment meant one clean patch/MR, but if it literally meant "patch," then my apologies for muddying the issue.
RE: #21 I agree with this. It might throw warnings (on EOL D9), but it shouldn't break things.
I think the best option is to commit #15. But that might throw some warnings on PHP 8.2 / Drupal 9.5. Not sure we can do anything about that.
RE: #24, you're right, this issue definitely overlaps with 3413610. It's the same problem, and they addressed it in the same way as #4 in this issue.
I'm closing the other as a duplicate.
I've successfully used the MR so I'm setting to RTBC.
- 🇩🇪Germany spuky
added a fix for an error in the same file during a D 10.3 update but there is also the same fix in 3456123
should I revert my commit ?