🇺🇦Ukraine @ankondrat4

Hello @netgeek123

Did you try to use changes as in proposed patch #2?

Hello.

I have added code to fix warning: file_exists(): Unable to find the wrapper that sometimes happens on line 140

Please review.

ankondrat4 → made their first commit to this issue’s fork.

Tested with the last changes. All works as expected from my side.
+1 RTBC.

Hello @dydave,

I have reviewed your changes and refactored the code. We don't need to run twice reseting the cache query string added to all CSS and JavaScript URLs. Function _drupal_flush_css_js() equals the same as we have in module: $this->state()->set('system.css_js_query_string', base_convert($this->time->getCurrentTime(), 10, 36)); So I propose to stay it without depending to core. functions.

/**
 * Changes the dummy query string added to all CSS and JavaScript files.
 *
 * Changing the dummy query string appended to CSS and JavaScript files forces
 * all browsers to reload fresh files.
 */
function _drupal_flush_css_js() {
  // The timestamp is converted to base 36 in order to make it more compact.
  Drupal::state()->set('system.css_js_query_string', base_convert(\Drupal::time()->getRequestTime(), 10, 36));
}

Please review and feedback — thanks!

Hello.
Maybe we need to do some changes according to these news?

Changes to Merchant Initiated Transactions on ApplePay and GooglePay
https://developer.paypal.com/braintree/docs/guides/apple-pay/client-side...

Hi @nidhi27
Yes, you can.

I’ve pushed a proposed improvement to the issue fork.
The patch enhances the flushJsCss() method to invalidate asset-related cache tags and trigger regeneration of CSS/JS aggregates.

MR !129 is ready for review and feedback — thanks!

ankondrat4 → created an issue.

A little bit confusing update and request. Why we need to forbid adding different types of order items to the order?

Created MR. Please review changes)

ankondrat4 → changed the visibility of the branch 3394728-saving-a-media to hidden.

Hello.
This issue related to module file of Drupal core core/modules/file/src/Element/ManagedFile.php

Hello.
Thank you, changes were added to the new release.

Hello.

This module doesn't use for replacement of original fields or uploaded files. It is only for compressing files that attached to entity and it allows to download all files as 1 archive.

Hello.
You are right. We have changed description. Thank you!

" File Compressor field module only gives support for File and Image fields."

Checked issue fork webform_submission_files_download-3435687 and MR!3 on Drupal 11. All works as expected.
+1 RTBC

Hello olmyr!

I have tried to apply MR!3 to drupal/webform_submission_files_download (2.0.2), but couldn't do it...

ankondrat4 → created an issue.

+1 RTBC for patch #7. Hitting performs search on the entered text now.
Thank you.

For resolving described issue in Drupal 10.2.6 need to apply patch from here https://www.drupal.org/project/file_entity/issues/3112300#comment-13811330 →

Hello.

I have the similar issue after upgrading Drupal core to 2.5.6 version.
Adding "application/octet-stream" to one of file type at /admin/structure/file-types temporary resolved the issue, but didn't in common. If you have many file types, the file type of uploaded file will be assigned to the first which has this mime "application/octet-stream" as allowed.

Steps to reproduce:
- Drupal core 10.2.6
- Create file types: Document, Image, Video
- Add to file type Document mime "application/octet-stream"
- Add to file type Image mime "image/*"
- Add to file type Video mime "video/*"
- Upload some image in field of your CT
- Check which type was assigned to your file on admin/content/files and see that it is "Document", not "Image"

It changes order in class, but it still "row" and "bs_grid"
+1 RTBC MR !22

After run drush command in/drush deploy got this error:

PHP Fatal error:  Declaration of Drupal\request_cleanup\StackMiddleware\Cleanup::handle(Symfony\Component\Http  
  Foundation\Request $request, $type = self::MASTER_REQUEST, $catch = true) must be compatible with Symfony\Component\HttpKernel\HttpKernel  
  Interface::handle(Symfony\Component\HttpFoundation\Request $request, int $type = self::MAIN_REQUEST, bool $catch = true): Symfony\Compone  
  nt\HttpFoundation\Response in /var/www/html/docroot/modules/contrib/request_cleanup/src/StackMiddleware/Cleanup.php on line 46

Added changes and open MR.

+1 RTBC.

ankondrat4 → made their first commit to this issue’s fork.

Hello.
Added patch for Drupal core 10.2.6

Hello.

Sorry, It's related to my custom patch and doesn't reproduce in 1.6 version.

ankondrat4 → created an issue.

Hello.

We have applied patch #9, but sometimes we have this error when go to Content dashboard

Uncaught PHP Exception Symfony\Component\Routing\Exception\RouteNotFoundException: "Route "view.block_content.page_1" does not exist." at /mnt/www/html/docroot/core/lib/Drupal/Core/Routing/RouteProvider.php line 206

Seems patch #9 doesn't fix the issue as well(
Workaround, clearing Drupal caches...

Hello.

I have the same issue on my current Drupal core 10.1,5. Module enabled as expected but after clearing cache I have this issue and it blocked my site.

ankondrat4 → created an issue.

Hello.
+1 RTBC for patch #14 and MR !56 on Drupal 10.

ankondrat4 → made their first commit to this issue’s fork.

+1 RTBC for MR6.
It works as expected on Drupal 10.

Hello.
+1 RTBC for patch #4

_shY → credited ankondrat4 → .

Hello @sakthi_dev

We have pipeline with phpcs in this module)))) FYI: https://git.drupalcode.org/issue/ultimate_cron-3421334/-/jobs/815693

ankondrat4 → created an issue.

Hello.

I have created MR. Please review.

ankondrat4 → made their first commit to this issue’s fork.

Please review MR !401

ankondrat4 → changed the visibility of the branch 3421103-drupal-coding-standarts to hidden.

I have used on local rules: Drupal, DrupalPractice for extensions: twig,css,inc,install,module,php,profile,test,theme,module/php,install/php,js
Ok, I will create separate branch to fix only Drupal coding standards that proposed in pipeline from .gitlab-ci.yml

Hello.

@abramm TY

Please, review.

ankondrat4 → made their first commit to this issue’s fork.

Hello.

Please, review https://git.drupalcode.org/issue/webform-3421103/-/jobs/803692

ankondrat4 → created an issue.

Hello.

Please, review MR !398

ankondrat4 → made their first commit to this issue’s fork.

ankondrat4 → made their first commit to this issue’s fork.

Hello.

gitlabci is ready for working.

https://git.drupalcode.org/issue/redirect-3421073/-/pipelines/93694

ankondrat4 → created an issue.

Hello.

MR !82 is ready for review. We have fixed Drupal coding standards.

https://git.drupalcode.org/issue/redirect-3376530/-/jobs/802404

ankondrat4 → changed the visibility of the branch 8.x-1.x to hidden.

Hello.

+1 RTBC

https://git.drupalcode.org/issue/redirect-3413875/-/pipelines/75272

ankondrat4 → changed the visibility of the branch 3376530-code-standards-fixes to active.

Hello.

Fixed and created MR.

Need review.

ankondrat4 → made their first commit to this issue’s fork.

Hello.

Refactor and created MR.

Please review.

ankondrat4 → made their first commit to this issue’s fork.

Hello.
The module was prepared to review. Drupal coding standards were fixed as for Drupal 7 version of module https://git.drupalcode.org/project/file_compressor_field/-/pipelines/86778

ankondrat4 → created an issue.

Hello.

Added to release 2.1.0.

Hello.
The module was prepared to review. Drupal coding standards were fixed as for Drupal 9/10 as for Drupal 7 version of module.

ankondrat4 → created an issue.

ankondrat4 → created an issue.

ankondrat4 → made their first commit to this issue’s fork.

Hello.

Please, create MR for this.

ankondrat4 → created an issue.

Fixed.
Thank you.

Hello.

As I see, it was fixed in 2.0.0 version.