Drupal coding standards

Issue created by @ankondrat4
Comment 9 months ago →
🇺🇦Ukraine ankondrat4 Lutsk
Merge request !400Issue #3421103: Drupal coding standarts → (Open) created by ankondrat4
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
524 pass, 15 fail
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
524 pass, 15 fail
Pipeline finished with Canceled
9 months ago
Total: 467s
#93788
Issue was unassigned.
Status changed to Needs review 9 months ago11:20am 13 February 2024
Comment 9 months ago →
🇺🇦Ukraine ankondrat4 Lutsk
Hello.

Please, review https://git.drupalcode.org/issue/webform-3421103/-/jobs/803692
Pipeline finished with Failed
9 months ago
Total: 2037s
#93798
Status changed to Needs work 9 months ago12:24pm 13 February 2024
Comment 9 months ago →
cilefen
Tests failed. What is the actual ruleset used here?
Comment 9 months ago →
🇺🇦Ukraine ankondrat4 Lutsk
I have used on local rules: Drupal, DrupalPractice for extensions: twig,css,inc,install,module,php,profile,test,theme,module/php,install/php,js
Ok, I will create separate branch to fix only Drupal coding standards that proposed in pipeline from .gitlab-ci.yml
Merge request !401Resolve #3421103 "Drupal coding standarts gitlab" → (Merged) created by ankondrat4
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
536 pass
Pipeline finished with Success
9 months ago
Total: 2027s
#93932
Comment 9 months ago →
🇺🇦Ukraine ankondrat4 Lutsk
ankondrat4 → changed the visibility of the branch 3421103-drupal-coding-standarts to hidden.
Status changed to Needs review 9 months ago2:17pm 13 February 2024
Comment 9 months ago →
🇺🇦Ukraine ankondrat4 Lutsk
Please review MR !401
Status changed to Needs work 9 months ago5:36pm 13 February 2024
Comment 9 months ago →
cilefen
The current merge seems unrelated to this issue. What is it?
Comment 9 months ago →
solideogloria
Comment 9 months ago →
solideogloria
Status changed to Needs review 9 months ago4:37pm 22 February 2024
Comment 9 months ago →
solideogloria
The MR fixes the coding standard where \Drupal was used instead of injecting the service. It looks like the proper fix to me.
Pipeline finished with Skipped
8 months ago
#137583
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update 8 months ago
536 pass
Status changed to Fixed 8 months ago3:41pm 4 April 2024
Comment 8 months ago →
🇺🇸United States jrockowitz Brooklyn, NY
Comment 8 months ago →
System Message

jrockowitz → committed 016dfa29 on 6.2.x authored by ankondrat4 →
Issue #3421103: Drupal coding standards
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Merge Requests

!401Drupal coding standards
Merged

!400Drupal coding standards
Open

Comments & Activities

Drupal coding standards

Problem/Motivation

Merge Requests

!401Drupal coding standardsMerged

!400Drupal coding standardsOpen

Comments & Activities

!401Drupal coding standards
Merged

!400Drupal coding standards
Open