- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Assigning to myself as I'm triaging all RTBC issues.
- Status changed to Needs work
over 1 year ago 6:11am 9 August 2023 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Thanks for the issue, patch, and review.
+++ b/redirect.api.php @@ -23,7 +23,8 @@ - * - Updating an existing redirect (calling redirect_save() on an existing redirect): + * - Updating an existing redirect (calling redirect_save() on an + * existing redirect):
There are several places where the wrapping is not correct... here's one example where it's wrapped too soon.
Also, best to do all the code standards in one issue rather than break them up like this and π Missing doc comment Needs work or it can be consider issue credit gaming. See:
https://www.drupal.org/drupalorg/docs/marketplace/abuse-of-the-contribut... β
Specifically:
Bulk posting of low-effort issues, such as:
Conversion from README.txt to README.md or other minor readme fixes
phpcs (code style) fixes
etc. - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Ran the checker after applying the patch and there are more that are too long. So... in addition to fixing the ones already in the patch, then the rest need to be fixed as well:
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .
- Issue was unassigned.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Unassigning for someone else to work on this per above comments.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
This issue should be combined with π The line declaring an array spans longer than 80 characters Needs work so there is only one issue and patch.
- First commit to issue fork.
- First commit to issue fork.
- last update
9 months ago 11 pass