- Issue created by @Shreya_98
- 🇮🇳India Shreya_98
->Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig alr/
In this module i had fixed most of the issues but some major issues will need to work on.
- last update
over 1 year ago 62 pass, 2 fail - Issue was unassigned.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Renaming as this looked like a bug, and it isn't. I leave to maintainers the decision if they want these kind of contributions or not.
- 🇮🇳India zkhan.aamir
@penyaskito While using this command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml redirect/I got these issues
FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\css\redirect.admin.css ------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\redirect_404.install ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\redirect_404.module ------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 44 | WARNING | [x] A comma should follow the last multiline array item. Found: ) ------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\redirect_404.views.inc --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\Controller\Fix404IgnoreController.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 60 | ERROR | [ ] Description for the @return value is missing 66 | WARNING | [ ] Unused variable $langcode. ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\EventSubscriber\Redirect404Subscriber.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Path\CurrentPathStack. 99 | ERROR | [x] Data types in @param tags need to be fully namespaced -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\Form\RedirectFix404Form.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 157 | ERROR | [ ] The array declaration extends to column 134 (the limit is 80). The array content should be split up over multiple lines 157 | ERROR | [ ] The array declaration extends to column 118 (the limit is 80). The array content should be split up over multiple lines 170 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\Plugin\views\field\Language.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\Plugin\views\field\Redirect404Operations.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\RedirectNotFoundStorageInterface.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\Render\Redirect404LogSuppressor.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\SqlRedirectNotFoundStorage.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 72 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\tests\src\Functional\Fix404RedirectUILanguageTest.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\tests\src\Functional\Fix404RedirectUITest.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 178 | WARNING | [ ] Unused variable $xpath. 180 | ERROR | [x] Concat operator must be surrounded by a single space 230 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\tests\src\Functional\Redirect404LogSuppressorTest.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 82 | ERROR | [x] Expected 1 blank line after function; 0 found 83 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\tests\src\Functional\Redirect404TestBase.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\tests\src\Kernel\Fix404RedirectCronJobTest.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Database. 41 | ERROR | [x] Visibility must be declared on method "testRedirect404CronJob" 81 | ERROR | [x] Visibility must be declared on method "testRedirect404CronJobKeepAllButOne" 121 | ERROR | [x] Visibility must be declared on method "testRedirect404CronJobDailyCountReset" 186 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 223 | ERROR | [x] Expected 1 blank line after function; 0 found 224 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\tests\src\Unit\SqlRedirectNotFoundStorageTest.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_domain\redirect_domain.module ------------------------------------------------------------------------------------------------------------------------ FOUND 5 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] Missing file doc comment 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 7 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 8 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 18 | ERROR | [x] Case breaking statements must be followed by a single blank line ------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_domain\src\EventSubscriber\DomainRedirectRequestSubscriber.php --------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES --------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\EventDispatcher\EventSubscriberInterface. 19 | ERROR | [ ] Missing short description in doc comment 43 | ERROR | [x] Scope keyword "protected" must be followed by a single space; found 2 46 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 136 | ERROR | [ ] The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_domain\src\Form\RedirectDomainForm.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 3 WARNINGS AFFECTING 9 LINES --------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 21 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 22 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 43 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 49 | WARNING | [ ] Unused variable $rows. 57 | ERROR | [x] Expected one space after the comma, 0 found 57 | ERROR | [x] Expected one space after the comma, 0 found 157 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 165 | ERROR | [x] Expected 1 blank line after function; 0 found 166 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_domain\tests\src\FunctionalJavascript\RedirectDomainUITest.php --------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 35 | WARNING | [x] A comma should follow the last multiline array item. Found: 'administer redirects' 68 | ERROR | [x] Expected 1 blank line after function; 0 found 69 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_domain\tests\src\Unit\DomainRedirectRequestSubscriberTest.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 13 ERRORS AFFECTING 12 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 124 | ERROR | [ ] Missing parameter type 126 | ERROR | [ ] Missing parameter type 129 | ERROR | [x] Data types in @return tags need to be fully namespaced 129 | ERROR | [x] Data types in @return tags need to be fully namespaced 148 | ERROR | [ ] The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines 149 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 152 | ERROR | [ ] The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines 153 | ERROR | [ ] The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 154 | ERROR | [ ] The array declaration extends to column 87 (the limit is 80). The array content should be split up over multiple lines 155 | ERROR | [ ] The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines 157 | ERROR | [x] Expected 1 blank line after function; 0 found 158 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\redirect.api.php ------------------------------------------------------------------------------------------ FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 9 LINES ------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 28 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 38 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters 101 | ERROR | [ ] Missing parameter type 103 | ERROR | [ ] Missing parameter type 115 | ERROR | [ ] Missing parameter type 117 | ERROR | [ ] Missing parameter type 119 | ERROR | [ ] Missing parameter type 142 | ERROR | [ ] Missing parameter type ------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\redirect.drush.inc -------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 6 | ERROR | [x] There must be exactly one blank line after the file comment 7 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 11 | ERROR | [x] Expected 1 blank line before function; 0 found -------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\redirect.generate.inc ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 18 ERRORS AND 4 WARNINGS AFFECTING 19 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Database. 18 | ERROR | [x] Missing function doc comment 38 | ERROR | [x] Missing function doc comment 44 | ERROR | [x] Missing function doc comment 58 | ERROR | [x] Missing function doc comment 84 | ERROR | [x] Missing function doc comment 108 | WARNING | [ ] Unused variable $source_options. 143 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 144 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 145 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 149 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 150 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 158 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters 158 | WARNING | [x] There must be no blank line following an inline comment 158 | WARNING | [ ] There must be no blank line following an inline comment 158 | ERROR | [x] No space found before comment text; expected "// $context['message'] = t('Deleted URL redirect @rid.', array('@rid' => end($rids)));" but found | | "//$context['message'] = t('Deleted URL redirect @rid.', array('@rid' => end($rids)));" 167 | ERROR | [x] Missing function doc comment 175 | ERROR | [ ] The array declaration extends to column 195 (the limit is 80). The array content should be split up over multiple lines 179 | ERROR | [x] Missing function doc comment 183 | ERROR | [x] Concat operator must be surrounded by a single space 192 | ERROR | [x] Missing function doc comment ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\redirect.install ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 25 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 30 | ERROR | [ ] The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines 37 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. 37 | ERROR | [x] Expected 1 space before ":"; 0 found 52 | ERROR | [x] Expected 1 blank line after function; 2 found ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\redirect.module ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 11 ERRORS AND 2 WARNINGS AFFECTING 12 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 51 | ERROR | [ ] The array declaration extends to column 487 (the limit is 80). The array content should be split up over multiple lines 63 | ERROR | [x] Case breaking statements must be followed by a single blank line 64 | WARNING | [ ] Code after the RETURN statement on line 63 cannot be executed 64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 209 | ERROR | [ ] Missing parameter type 211 | ERROR | [ ] Missing parameter type 214 | ERROR | [ ] Return type missing for @return tag in function comment 227 | ERROR | [x] Missing function doc comment 237 | ERROR | [x] Use null coalesce operator instead of ternary operator. 245 | ERROR | [ ] Return type missing for @return tag in function comment 253 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for | | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates." 255 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "locale_form_redirect_edit_form_alter" but expected | | "redirect_locale_form_redirect_edit_form_alter" ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Entity\Redirect.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 157 | ERROR | [ ] The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines 163 | ERROR | [ ] Description for the @return value is missing 172 | ERROR | [ ] Description for the @return value is missing 252 | ERROR | [x] Use null coalesce operator instead of ternary operator. 298 | ERROR | [ ] The array declaration extends to column 268 (the limit is 80). The array content should be split up over multiple lines 313 | WARNING | [x] A comma should follow the last multiline array item. Found: DRUPAL_DISABLED --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\EventSubscriber\RedirectRequestSubscriber.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 15 ERRORS AND 2 WARNINGS AFFECTING 14 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 20 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\EventDispatcher\EventSubscriberInterface. 28 | ERROR | [x] The open comment tag must be the only content on the line 28 | ERROR | [ ] Missing short description in doc comment 31 | ERROR | [ ] Missing short description in doc comment 36 | ERROR | [ ] Missing short description in doc comment 41 | ERROR | [ ] Missing short description in doc comment 46 | ERROR | [ ] Missing short description in doc comment 51 | ERROR | [ ] Missing short description in doc comment 56 | ERROR | [ ] Missing short description in doc comment 61 | ERROR | [ ] Missing short description in doc comment 73 | ERROR | [ ] Parameter $context is not described in comment 73 | ERROR | [ ] Parameter $path_processor is not described in comment 74 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 90 | ERROR | [ ] Missing parameter name 148 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 148 | ERROR | [ ] The array declaration extends to column 155 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\EventSubscriber\RedirectSettingsCacheTag.php -------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 11 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\EventSubscriber\RouteNormalizerRequestSubscriber.php ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 4 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\EventDispatcher\EventSubscriberInterface. 109 | ERROR | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces 137 | ERROR | [x] Visibility must be declared on method "getSubscribedEvents" ------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Exception\RedirectLoopException.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 35 | ERROR | [ ] The array declaration extends to column 126 (the limit is 80). The array content should be split up over multiple lines 57 | ERROR | [x] Additional blank lines found at end of doc comment ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Form\RedirectDeleteForm.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 4 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. 9 | ERROR | [x] Missing class doc comment 15 | ERROR | [ ] The array declaration extends to column 203 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Form\RedirectDeleteMultipleForm.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\TempStore\PrivateTempStoreFactory. --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Form\RedirectForm.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 10 ERRORS AND 3 WARNINGS AFFECTING 13 LINES --------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. 14 | ERROR | [x] Missing class doc comment 26 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 70 | ERROR | [x] Expected 1 space after closing parenthesis; found 2 71 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 77 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 128 | ERROR | [x] Use null coalesce operator instead of ternary operator. 129 | ERROR | [x] Use null coalesce operator instead of ternary operator. 133 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 143 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 155 | ERROR | [x] Expected 1 blank line after function; 0 found 156 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Form\RedirectSettingsForm.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 8 | ERROR | [x] Missing class doc comment 15 | ERROR | [x] Expected 1 blank line after function; 0 found 32 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 38 | ERROR | [ ] The array declaration extends to column 426 (the limit is 80). The array content should be split up over multiple lines 72 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\Action\DeleteRedirect.php -------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 48 | ERROR | [x] Data types in @param tags need to be fully namespaced -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\Field\FieldFormatter\RedirectSourceFormatter.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface. ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\Field\FieldType\RedirectSourceItem.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 100 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\Field\FieldWidget\RedirectSourceWidget.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AND 4 WARNINGS AFFECTING 11 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. 50 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 66 | WARNING | [x] '@todo - Hmm... exception driven logic. Find a better way how to' should match the format '@todo Fix problem X here.' 69 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 69 | ERROR | [ ] The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines 71 | ERROR | [ ] The array declaration extends to column 113 (the limit is 80). The array content should be split up over multiple lines 82 | ERROR | [x] Use null coalesce operator instead of ternary operator. 85 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 89 | ERROR | [ ] The array declaration extends to column 319 (the limit is 80). The array content should be split up over multiple lines 122 | ERROR | [x] Expected 1 blank line after function; 0 found 123 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\migrate\process\d7\PathRedirect.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 14 | ERROR | [ ] Missing short description in doc comment 41 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. 54 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\migrate\process\d7\RedirectSourceQuery.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 14 | ERROR | [ ] Missing short description in doc comment 31 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\migrate\process\PathRedirect.php --------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 9 | ERROR | [ ] Missing short description in doc comment --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\migrate\source\d7\PathRedirect.php ----------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\migrate\source\PathRedirect.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\Validation\Constraint\SourceLinkTypeConstraint.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES --------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url. 25 | ERROR | [ ] Missing member variable doc comment 27 | ERROR | [ ] Missing short description in doc comment 52 | WARNING | [x] The variable name should be defined after the type 90 | ERROR | [x] Expected 1 blank line after function; 0 found 91 | ERROR | [x] Expected 1 newline at end of file; 2 found 91 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\RedirectChecker.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 9 ERRORS AFFECTING 9 LINES ----------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteObjectInterface. 18 | ERROR | [ ] Missing short description in doc comment 23 | ERROR | [ ] Missing short description in doc comment 28 | ERROR | [ ] Missing short description in doc comment 33 | ERROR | [ ] Missing short description in doc comment 38 | ERROR | [ ] Missing short description in doc comment 43 | ERROR | [x] Missing function doc comment 54 | ERROR | [x] Data types in @param tags need to be fully namespaced ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\RedirectRepository.php ---------------------------------------------------------------------------------------------------- FOUND 12 ERRORS AND 2 WARNINGS AFFECTING 14 LINES ---------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 12 | ERROR | [x] Missing class doc comment 14 | ERROR | [ ] Missing short description in doc comment 19 | ERROR | [ ] Missing short description in doc comment 24 | ERROR | [ ] Missing short description in doc comment 36 | ERROR | [ ] Parameter $config_factory is not described in comment 37 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 57 | ERROR | [ ] Missing parameter type 107 | ERROR | [ ] Parameter $redirect is not described in comment 110 | ERROR | [ ] Missing parameter name 117 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 166 | ERROR | [ ] Description for the @return value is missing 183 | ERROR | [x] Expected 1 blank line after function; 0 found 184 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\RedirectStorageSchema.php ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\RedirectViewsData.php --------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Routing\RouteSubscriber.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\fixtures\drupal6.php ---------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\fixtures\drupal7-no-default.php --------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES --------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 73 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 207 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 218 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 229 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\fixtures\drupal7.php ---------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AND 1 WARNING AFFECTING 8 LINES ---------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 73 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 153 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 218 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 229 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 240 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 ---------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\modules\redirect_test\redirect_test.module -------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Functional\AssertRedirectTrait.php ---------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 18 | ERROR | [ ] Missing parameter type 34 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 35 | ERROR | [x] Expected newline after closing brace ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Functional\GlobalRedirectTest.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 9 ERRORS AND 4 WARNINGS AFFECTING 10 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 37 | ERROR | [ ] Missing short description in doc comment 42 | ERROR | [ ] Missing short description in doc comment 47 | ERROR | [ ] Missing short description in doc comment 52 | ERROR | [ ] Missing short description in doc comment 57 | ERROR | [ ] Missing short description in doc comment 62 | ERROR | [ ] Missing short description in doc comment 195 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 211 | WARNING | [x] '@todo - here it seems that the access check runs prior to our redirecting' should match the format '@todo Fix problem X here.' 213 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 213 | WARNING | [x] There must be no blank line following an inline comment 213 | WARNING | [ ] There must be no blank line following an inline comment 213 | ERROR | [x] No space found before comment text; expected "// $this->assertRedirect('admin/config/system/site-information', 'site-info');" but found | | "//$this->assertRedirect('admin/config/system/site-information', 'site-info');" ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Functional\RedirectHooksTest.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Functional\RedirectNodeFormTest.php ----------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Functional\RedirectUILanguageTest.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 20 | ERROR | [ ] The array declaration extends to column 123 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Functional\RedirectUITest.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 210 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\FunctionalJavascript\RedirectJavascriptTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 39 | ERROR | [ ] The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines 73 | ERROR | [ ] Public method name "RedirectJavascriptTest::testRedirectUI" is not in lowerCamel format ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Kernel\Migrate\d6\PathRedirectTest.php -------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 6 | ERROR | [x] There must be one blank line after the last USE statement; 2 found; 27 | ERROR | [x] There should be no white space after an opening "(" 37 | ERROR | [x] Data types in @var tags need to be fully namespaced 48 | ERROR | [x] Expected 1 blank line after function; 0 found 49 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Kernel\Migrate\d7\PathRedirectSourceTest.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 18 | ERROR | [ ] The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines 29 | WARNING | [x] A comma should follow the last multiline array item. Found: ] ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Kernel\Migrate\d7\PathRedirectTest.php -------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Kernel\Migrate\d7\PathRedirectTestBase.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 38 | ERROR | [x] Data types in @var tags need to be fully namespaced ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Kernel\Migrate\d7\PathRedirectWithoutDefaultTest.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 5 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Kernel\RedirectAPITest.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 12 ERRORS AND 3 WARNINGS AFFECTING 13 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Language\Language. 30 | ERROR | [ ] The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines 189 | ERROR | [ ] The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines 190 | ERROR | [ ] The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 190 | ERROR | [ ] The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines 194 | WARNING | [ ] Unused variable $index. 272 | ERROR | [ ] Public method name "RedirectAPITest::testParseURL" is not in lowerCamel format 273 | ERROR | [x] No space found before comment text; expected "// $test_cases = array(" but found "//$test_cases = array(" 275 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters 275 | ERROR | [ ] Comment indentation error, expected only 2 spaces 276 | WARNING | [ ] Line exceeds 80 characters; contains 98 characters 278 | ERROR | [x] No space found before comment text; expected "// );" but found "//);" 279 | ERROR | [x] No space found before comment text; expected "// foreach ($test_cases as $index => $test_case) {" but found "//foreach ($test_cases as $index => | | $test_case) {" 282 | ERROR | [x] No space found before comment text; expected "// }" but found "//}" ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Unit\RedirectCheckerTest.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 30 ERRORS AND 5 WARNINGS AFFECTING 25 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 22 | ERROR | [ ] The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines 22 | ERROR | [ ] The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines 58 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 84 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 103 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters 103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 103 | ERROR | [x] 4 spaces found before inline comment; expected "// $checker = new RedirectChecker($this->getConfigFactoryStub($config), $state);" but found "// | | $checker = new RedirectChecker($this->getConfigFactoryStub($config), $state);" 104 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 106 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 106 | ERROR | [ ] Comment indentation error, expected only 4 spaces 107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 108 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 109 | ERROR | [ ] Comment indentation error, expected only 4 spaces 110 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 113 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 114 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 114 | ERROR | [ ] Comment indentation error, expected only 4 spaces 115 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters 115 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 117 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 118 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 119 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters 119 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 121 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 122 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 122 | ERROR | [ ] Comment indentation error, expected only 4 spaces 123 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters 123 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0 ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 24 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Unit\RedirectRequestSubscriberTest.php -------------------------------------------------------------------------------------------------------------------------- FOUND 14 ERRORS AFFECTING 10 LINES -------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 114 | ERROR | [ ] Missing parameter type 116 | ERROR | [ ] Missing parameter type 178 | ERROR | [ ] Missing parameter type 180 | ERROR | [ ] Missing parameter type 210 | ERROR | [ ] Missing parameter type 257 | ERROR | [ ] Missing parameter comment 257 | ERROR | [ ] Missing parameter type 258 | ERROR | [ ] Missing parameter comment 258 | ERROR | [ ] Missing parameter type 260 | ERROR | [ ] Description for the @return value is missing 260 | ERROR | [x] Data types in @return tags need to be fully namespaced 260 | ERROR | [x] Data types in @return tags need to be fully namespaced 272 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Unit\RouteNormalizerRequestSubscriberTest.php -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 12 ERRORS AND 6 WARNINGS AFFECTING 18 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\redirect\EventSubscriber\RouteNormalizerRequestSubscriber. 45 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters 46 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 59 | WARNING | [ ] Line exceeds 80 characters; contains 113 characters 60 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 73 | WARNING | [ ] Line exceeds 80 characters; contains 126 characters 74 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 99 | ERROR | [ ] The array declaration extends to column 101 (the limit is 80). The array content should be split up over multiple lines 100 | ERROR | [ ] The array declaration extends to column 127 (the limit is 80). The array content should be split up over multiple lines 101 | ERROR | [ ] The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines 102 | ERROR | [ ] The array declaration extends to column 122 (the limit is 80). The array content should be split up over multiple lines 116 | ERROR | [ ] Description for the @return value is missing 140 | ERROR | [ ] Description for the @return value is missing 162 | ERROR | [ ] Description for the @return value is missing 182 | ERROR | [ ] Description for the @return value is missing 208 | ERROR | [ ] Description for the @return value is missing 211 | ERROR | [ ] The array declaration extends to column 148 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------- Time: 3.82 secs; Memory: 14MB - First commit to issue fork.
- 🇮🇳India apatel0325
apatel0325 → changed the visibility of the branch 3376530-code-standards-fixes to hidden.
- Assigned to apatel0325
- Issue was unassigned.
- 🇷🇺Russia zniki.ru
It looks like it's going to be a big MR.
Let's move Dependency Injection changes to separate issue.
According to report from #5
Affected files:modules\redirect_404\src\SqlRedirectNotFoundStorage.php src\EventSubscriber\RedirectRequestSubscriber.php src\Form\RedirectForm.php src\Form\RedirectSettingsForm.php src\Plugin\Field\FieldWidget\RedirectSourceWidget.php src\RedirectRepository.phpLooks like there is already an issue to fix it 📌 Use dependency injection for redirect classes Needs review
- Assigned to nitin_lama
- last update
about 1 year ago 63 pass - 🇮🇳India nitin_lama India
Updating IS for the remaining phpcs issue.
- Issue was unassigned.
- 🇷🇺Russia zniki.ru
@nitin_lama thanks for suggest changes, let's use MR workflow, no need to attach patch files.
- last update
about 1 year ago 63 pass - 🇷🇺Russia zniki.ru
I add some changes to MR
* .gitlab-ci.yml from 📌 Adopt GitlabCi Needs review to run Gitlab CI check on MR.
* add phpcs.xml file to exclude sniffs related to Dependency Injection (see #11)Now it's possible to check the status of phpcs violations in the pipeline.
- First commit to issue fork.
- 🇷🇺Russia zniki.ru
There are too many violations, for single issue
A TOTAL OF 304 SNIFF VIOLATIONS WERE FOUND IN 61 SOURCES
Let's create child issues for different rules to fix, it will be easy to review.
Here is the list of violations sorted by name.[ ] Drupal.Arrays.Array.LongLineDeclaration 13 [ ] Drupal.Commenting.DocComment.MissingShort 27 [ ] Drupal.Commenting.DocComment.ShortSingleLine 1 [ ] Drupal.Commenting.FunctionComment.MissingParamComment 2 [ ] Drupal.Commenting.FunctionComment.MissingParamName 2 [ ] Drupal.Commenting.FunctionComment.MissingParamType 19 [ ] Drupal.Commenting.FunctionComment.MissingReturnComment 11 [ ] Drupal.Commenting.FunctionComment.MissingReturnType 2 [ ] Drupal.Commenting.FunctionComment.ParamMissingDefinition 4 [ ] Drupal.Commenting.HookComment.HookCommentFormat 1 [ ] Drupal.Commenting.InlineComment.SpacingBefore 6 [ ] Drupal.Commenting.VariableComment.Missing 1 [ ] Drupal.Files.LineLength.TooLong 24 [ ] Drupal.NamingConventions.ValidFunctionName.InvalidPrefix 1 [ ] Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps 2 [ ] Drupal.Semantics.FunctionT.BackslashSingleQuote 1 [ ] DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable 5 [ ] DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter 2 [ ] DrupalPractice.FunctionCalls.InsecureUnserialize.InsecureUnserialize 5 [ ] DrupalPractice.Objects.GlobalDrupal.GlobalDrupal 10 [ ] Squiz.PHP.NonExecutableCode.Unreachable 1 [x] Drupal.Arrays.Array.CommaLastItem 8 [x] Drupal.Classes.ClassDeclaration.CloseBraceAfterBody 10 [x] Drupal.Commenting.ClassComment.Missing 4 [x] Drupal.Commenting.DataTypeNamespace.DataTypeNamespace 9 [x] Drupal.Commenting.DocComment.ContentAfterOpen 1 [x] Drupal.Commenting.DocComment.SpacingAfter 1 [x] Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar 4 [x] Drupal.Commenting.FileComment.Missing 1 [x] Drupal.Commenting.FileComment.NamespaceNoFileDoc 6 [x] Drupal.Commenting.FileComment.SpacingAfterComment 1 [x] Drupal.Commenting.FunctionComment.Missing 10 [x] Drupal.Commenting.InlineComment.InvalidEndChar 2 [x] Drupal.Commenting.InlineComment.NoSpaceBefore 6 [x] Drupal.Commenting.InlineComment.SpacingAfter 2 [x] Drupal.Commenting.InlineVariableComment.VarInlineOrder 1 [x] Drupal.Commenting.TodoComment.TodoFormat 2 [x] Drupal.ControlStructures.ControlSignature.NewlineAfterCloseBrace 1 [x] Drupal.ControlStructures.ControlSignature.SpaceAfterCloseParenthesis 1 [x] Drupal.Files.EndFileNewline.NoneFound 1 [x] Drupal.Files.EndFileNewline.TooMany 1 [x] Drupal.Formatting.MultipleStatementAlignment.Incorrect 1 [x] Drupal.Formatting.MultipleStatementAlignment.NotSame 1 [x] Drupal.Scope.MethodScope.Missing 4 [x] Drupal.WhiteSpace.Comma.NoSpace 2 [x] Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace 1 [x] Drupal.WhiteSpace.OpenTagNewline.BlankLine 3 [x] Drupal.WhiteSpace.ScopeIndent.IncorrectExact 36 [x] Generic.PHP.UpperCaseConstant.Found 1 [x] PSR2.Namespaces.UseDeclaration.SpaceAfterLastUse 2 [x] SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed 5 [x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses 15 [x] Squiz.Arrays.ArrayDeclaration.CloseBraceNewLine 1 [x] Squiz.ControlStructures.SwitchDeclaration.SpacingAfterBreak 2 [x] Squiz.Strings.ConcatenationSpacing.PaddingFound 2 [x] Squiz.WhiteSpace.FunctionSpacing.After 2 [x] Squiz.WhiteSpace.FunctionSpacing.AfterLast 10 [x] Squiz.WhiteSpace.FunctionSpacing.Before 1 [x] Squiz.WhiteSpace.OperatorSpacing.NoSpaceBefore 1 [x] Squiz.WhiteSpace.ScopeKeywordSpacing.Incorrect 1 [x] Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines 1We need to think how to group rules.
- 🇷🇺Russia zniki.ru
Remove full report from IS description, add file with full report.
- last update
about 1 year ago 63 pass - last update
about 1 year ago 63 pass - 🇮🇳India zkhan.aamir
Hi,
MR #21 applied successfully.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/redirect (8.x-1.x) $ curl https://git.drupalcode.org/project/redirect/-/merge_requests/78.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 82203 0 82203 0 0 69747 0 --:--:-- 0:00:01 --:--:-- 69841 patching file .gitlab-ci.yml patching file modules/redirect_404/redirect_404.module patching file modules/redirect_404/src/Controller/Fix404IgnoreController.php patching file modules/redirect_404/src/EventSubscriber/Redirect404Subscriber.php patching file modules/redirect_404/src/Form/RedirectFix404Form.php patching file modules/redirect_404/tests/src/Functional/Fix404RedirectUITest.php patching file modules/redirect_404/tests/src/Functional/Redirect404LogSuppressorTest.php patching file modules/redirect_404/tests/src/Kernel/Fix404RedirectCronJobTest.php patching file modules/redirect_domain/redirect_domain.module patching file modules/redirect_domain/src/EventSubscriber/DomainRedirectRequestSubscriber.php patching file modules/redirect_domain/src/Form/RedirectDomainForm.php patching file modules/redirect_domain/tests/src/FunctionalJavascript/RedirectDomainUITest.php patching file modules/redirect_domain/tests/src/Unit/DomainRedirectRequestSubscriberTest.php patching file phpcs.xml patching file redirect.drush.inc patching file redirect.generate.inc patching file redirect.install patching file redirect.module patching file src/Entity/Redirect.php patching file src/EventSubscriber/RedirectRequestSubscriber.php patching file src/EventSubscriber/RouteNormalizerRequestSubscriber.php patching file src/Exception/RedirectLoopException.php patching file src/Form/RedirectDeleteForm.php patching file src/Form/RedirectDeleteMultipleForm.php patching file src/Form/RedirectForm.php patching file src/Form/RedirectSettingsForm.php patching file src/Plugin/Action/DeleteRedirect.php patching file src/Plugin/Field/FieldFormatter/RedirectSourceFormatter.php patching file src/Plugin/Field/FieldType/RedirectSourceItem.php patching file src/Plugin/Field/FieldWidget/RedirectSourceWidget.php patching file src/Plugin/Validation/Constraint/SourceLinkTypeConstraint.php patching file src/Plugin/migrate/process/d7/PathRedirect.php patching file src/Plugin/migrate/process/d7/RedirectSourceQuery.php patching file src/Plugin/migrate/source/d7/PathRedirect.php patching file src/RedirectChecker.php patching file src/RedirectRepository.php patching file tests/fixtures/drupal6.php patching file tests/fixtures/drupal7-no-default.php patching file tests/fixtures/drupal7.php patching file tests/src/Functional/AssertRedirectTrait.php patching file tests/src/Functional/GlobalRedirectTest.php patching file tests/src/Functional/RedirectUILanguageTest.php patching file tests/src/Functional/RedirectUITest.php patching file tests/src/FunctionalJavascript/RedirectJavascriptTest.php patching file tests/src/Kernel/Migrate/d6/PathRedirectTest.php patching file tests/src/Kernel/Migrate/d7/PathRedirectSourceTest.php patching file tests/src/Kernel/Migrate/d7/PathRedirectTest.php patching file tests/src/Kernel/Migrate/d7/PathRedirectTestBase.php patching file tests/src/Kernel/Migrate/d7/PathRedirectWithoutDefaultTest.php patching file tests/src/Kernel/RedirectAPITest.php patching file tests/src/Unit/RedirectCheckerTest.php patching file tests/src/Unit/RedirectRequestSubscriberTest.php patching file tests/src/Unit/RouteNormalizerRequestSubscriberTest.phpStill there are issues and warning. Please check
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib $ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml redirect/ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\Controller\Fix404IgnoreController.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------- 60 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\Form\RedirectFix404Form.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 155 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines 155 | ERROR | The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\src\SqlRedirectNotFoundStorage.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 72 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\tests\src\Functional\Fix404RedirectUITest.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 229 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph -------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_404\tests\src\Kernel\Fix404RedirectCronJobTest.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 186 | WARNING | Line exceeds 80 characters; contains 82 characters --------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_domain\redirect_domain.module ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 3 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_domain\src\EventSubscriber\DomainRedirectRequestSubscriber.php --------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------------------------------- 19 | ERROR | Missing short description in doc comment 45 | ERROR | Doc comment is empty 129 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\modules\redirect_domain\tests\src\Unit\DomainRedirectRequestSubscriberTest.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AFFECTING 8 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------- 124 | ERROR | Missing parameter type 126 | ERROR | Missing parameter type 148 | ERROR | The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines 149 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 152 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines 153 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 154 | ERROR | The array declaration extends to column 87 (the limit is 80). The array content should be split up over multiple lines 155 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\redirect.api.php ------------------------------------------------------------------------------------------ FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 8 LINES ------------------------------------------------------------------------------------------ 28 | WARNING | Line exceeds 80 characters; contains 85 characters 38 | WARNING | Line exceeds 80 characters; contains 83 characters 101 | ERROR | Missing parameter type 103 | ERROR | Missing parameter type 115 | ERROR | Missing parameter type 117 | ERROR | Missing parameter type 119 | ERROR | Missing parameter type 142 | ERROR | Missing parameter type ------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\redirect.generate.inc ----------------------------------------------------------------------------------------------- FOUND 8 ERRORS AFFECTING 8 LINES ----------------------------------------------------------------------------------------------- 18 | ERROR | Doc comment is empty 41 | ERROR | Doc comment is empty 50 | ERROR | Doc comment is empty 67 | ERROR | Doc comment is empty 96 | ERROR | Doc comment is empty 181 | ERROR | Doc comment is empty 199 | ERROR | Doc comment is empty 215 | ERROR | Doc comment is empty ----------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\redirect.install ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 31 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\redirect.module ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 210 | ERROR | Missing parameter type 212 | ERROR | Missing parameter type 215 | ERROR | Return type missing for @return tag in function comment 228 | ERROR | Doc comment is empty 249 | ERROR | Return type missing for @return tag in function comment 257 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for | | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates." 259 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "locale_form_redirect_edit_form_alter" but expected | | "redirect_locale_form_redirect_edit_form_alter" ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Entity\Redirect.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------- 157 | ERROR | The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines 163 | ERROR | Description for the @return value is missing 172 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\EventSubscriber\RedirectRequestSubscriber.php --------------------------------------------------------------------------------------------------------------------------- FOUND 11 ERRORS AND 1 WARNING AFFECTING 11 LINES --------------------------------------------------------------------------------------------------------------------------- 28 | ERROR | Missing short description in doc comment 32 | ERROR | Missing short description in doc comment 37 | ERROR | Missing short description in doc comment 42 | ERROR | Missing short description in doc comment 47 | ERROR | Missing short description in doc comment 52 | ERROR | Missing short description in doc comment 57 | ERROR | Missing short description in doc comment 62 | ERROR | Missing short description in doc comment 74 | ERROR | Parameter $context is not described in comment 74 | ERROR | Parameter $path_processor is not described in comment 75 | WARNING | Line exceeds 80 characters; contains 84 characters 91 | ERROR | Missing parameter name --------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\EventSubscriber\RedirectSettingsCacheTag.php -------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | Line exceeds 80 characters; contains 84 characters -------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Form\RedirectDeleteForm.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 9 | ERROR | Doc comment is empty --------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Form\RedirectForm.php --------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------- 14 | ERROR | Doc comment is empty 74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 80 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 136 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Form\RedirectSettingsForm.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------- 8 | ERROR | Doc comment is empty 36 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ----------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\Field\FieldWidget\RedirectSourceWidget.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 69 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 69 | ERROR | The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines 71 | ERROR | The array declaration extends to column 113 (the limit is 80). The array content should be split up over multiple lines 85 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\migrate\process\d7\PathRedirect.php ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\migrate\process\d7\RedirectSourceQuery.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\migrate\process\PathRedirect.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 9 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\Plugin\Validation\Constraint\SourceLinkTypeConstraint.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------------- 25 | ERROR | Missing member variable doc comment 27 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\RedirectChecker.php ------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------- 18 | ERROR | Missing short description in doc comment 23 | ERROR | Missing short description in doc comment 28 | ERROR | Missing short description in doc comment 33 | ERROR | Missing short description in doc comment 38 | ERROR | Missing short description in doc comment 43 | ERROR | Doc comment is empty ------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\src\RedirectRepository.php ---------------------------------------------------------------------------------------------------- FOUND 9 ERRORS AND 1 WARNING AFFECTING 10 LINES ---------------------------------------------------------------------------------------------------- 12 | ERROR | Doc comment is empty 17 | ERROR | Missing short description in doc comment 22 | ERROR | Missing short description in doc comment 27 | ERROR | Missing short description in doc comment 39 | ERROR | Doc comment is empty 55 | ERROR | Missing parameter type 105 | ERROR | Parameter $redirect is not described in comment 108 | ERROR | Missing parameter name 115 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 164 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Functional\GlobalRedirectTest.php --------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES --------------------------------------------------------------------------------------------------------------------- 37 | ERROR | Missing short description in doc comment 42 | ERROR | Missing short description in doc comment 47 | ERROR | Missing short description in doc comment 52 | ERROR | Missing short description in doc comment 57 | ERROR | Missing short description in doc comment 62 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\FunctionalJavascript\RedirectJavascriptTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 39 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Kernel\Migrate\d7\PathRedirectSourceTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 18 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Kernel\RedirectAPITest.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------------- 30 | ERROR | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines 189 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines 190 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 190 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Unit\RedirectCheckerTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 22 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines 22 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Unit\RedirectRequestSubscriberTest.php -------------------------------------------------------------------------------------------------------------------------- FOUND 11 ERRORS AFFECTING 9 LINES -------------------------------------------------------------------------------------------------------------------------- 114 | ERROR | Missing parameter type 116 | ERROR | Missing parameter type 178 | ERROR | Missing parameter type 180 | ERROR | Missing parameter type 210 | ERROR | Missing parameter type 257 | ERROR | Missing parameter comment 257 | ERROR | Missing parameter type 258 | ERROR | Missing parameter comment 258 | ERROR | Missing parameter type 260 | ERROR | Description for the @return value is missing 272 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\redirect\tests\src\Unit\RouteNormalizerRequestSubscriberTest.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES --------------------------------------------------------------------------------------------------------------------------------- 139 | ERROR | Description for the @return value is missing 163 | ERROR | Description for the @return value is missing 185 | ERROR | Description for the @return value is missing 205 | ERROR | Description for the @return value is missing 231 | ERROR | Description for the @return value is missing --------------------------------------------------------------------------------------------------------------------------------- Time: 2.12 secs; Memory: 14MB - 🇺🇦Ukraine ankondrat4 Lutsk
ankondrat4 → changed the visibility of the branch 3376530-code-standards-fixes to active.
- last update
about 1 year ago 63 pass - last update
about 1 year ago 63 pass - last update
about 1 year ago 52 pass, 2 fail - 🇺🇦Ukraine ankondrat4 Lutsk
ankondrat4 → changed the visibility of the branch 8.x-1.x to hidden.
- First commit to issue fork.
- last update
about 1 year ago PHPLint Failed - First commit to issue fork.
- last update
about 1 year ago PHPLint Failed - last update
about 1 year ago PHPLint Failed - last update
about 1 year ago 38 pass, 14 fail - last update
about 1 year ago 38 pass, 14 fail - last update
about 1 year ago 38 pass, 14 fail - last update
about 1 year ago 38 pass, 14 fail - last update
about 1 year ago 38 pass, 14 fail - Status changed to Needs review
about 1 year ago 9:05am 13 February 2024 - 🇺🇦Ukraine ankondrat4 Lutsk
Hello.
MR !82 is ready for review. We have fixed Drupal coding standards.
https://git.drupalcode.org/issue/redirect-3376530/-/jobs/802404
- 🇮🇳India Yashaswi18
On running the command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig, found these issues remaining.phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig redirect/ FILE: /home/yashaswi/contribs/redirect/src/EventSubscriber/RedirectRequestSubscriber.php ---------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------- 168 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------- FILE: /home/yashaswi/contribs/redirect/src/Form/RedirectDeleteForm.php ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 19 | ERROR | The array declaration extends to column 110 (the limit is 80). The array content should be split up over | | multiple lines ------------------------------------------------------------------------------------------------------------------------ FILE: /home/yashaswi/contribs/redirect/src/Form/RedirectSettingsForm.php --------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------- 36 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------- FILE: /home/yashaswi/contribs/redirect/src/Form/RedirectForm.php ---------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------- 74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 80 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 136 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------- FILE: /home/yashaswi/contribs/redirect/src/RedirectRepository.php ---------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------- 128 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------- FILE: /home/yashaswi/contribs/redirect/src/Entity/Redirect.php ------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 157 | ERROR | The array declaration extends to column 83 (the limit is 80). The array content should be split up over | | multiple lines 301 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over | | multiple lines ------------------------------------------------------------------------------------------------------------------------ FILE: /home/yashaswi/contribs/redirect/src/Plugin/Field/FieldWidget/RedirectSourceWidget.php ------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------------ 50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 69 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 69 | ERROR | The array declaration extends to column 102 (the limit is 80). The array content should be split up | | over multiple lines 71 | ERROR | The array declaration extends to column 113 (the limit is 80). The array content should be split up | | over multiple lines 85 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 91 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up | | over multiple lines ------------------------------------------------------------------------------------------------------------------------ FILE: /home/yashaswi/contribs/redirect/redirect.generate.inc ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 239 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over | | multiple lines ------------------------------------------------------------------------------------------------------------------------ FILE: /home/yashaswi/contribs/redirect/tests/src/Kernel/RedirectAPITest.php ------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 198 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over | | multiple lines 199 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over | | multiple lines 199 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over | | multiple lines ------------------------------------------------------------------------------------------------------------------------ FILE: /home/yashaswi/contribs/redirect/tests/src/Unit/RouteNormalizerRequestSubscriberTest.php ------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 102 | ERROR | The array declaration extends to column 101 (the limit is 80). The array content should be split up over | | multiple lines 107 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over | | multiple lines ------------------------------------------------------------------------------------------------------------------------ FILE: /home/yashaswi/contribs/redirect/redirect.install ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 31 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over | | multiple lines ------------------------------------------------------------------------------------------------------------------------ FILE: /home/yashaswi/contribs/redirect/modules/redirect_domain/tests/src/Unit/DomainRedirectRequestSubscriberTest.php ------------------------------------------------------------------------------------------------------------------------ FOUND 6 ERRORS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------ 148 | ERROR | The array declaration extends to column 83 (the limit is 80). The array content should be split up over | | multiple lines 149 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over | | multiple lines 152 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over | | multiple lines 153 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over | | multiple lines 154 | ERROR | The array declaration extends to column 87 (the limit is 80). The array content should be split up over | | multiple lines 155 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over | | multiple lines ------------------------------------------------------------------------------------------------------------------------ - Assigned to apatel0325
- Status changed to Needs work
11 months ago 9:01am 19 March 2024 - last update
11 months ago 30 pass, 22 fail - Issue was unassigned.
- First commit to issue fork.
- last update
11 months ago 30 pass, 22 fail - 🇮🇳India pray_12
Hi,
Applied the MR!82 and found no PHPCS errors and warnings.
Thank You!!