🇺🇸United States @agentrickard

I can confirm the same problem on Platform.sh (Solr 9.6) using the provided configset from the module.

Putting the provided configset in .platform/configsets/solr9/ throws the error.

https://solr.apache.org/guide/solr/9_6/configuration-guide/config-sets.h... suggests that the files should be in a nested /conf directory inside the configset.

When we move the files to a nested /conf directory (.platform/configsets/solr9/conf), the initial error is replaced by "Your config-set contains manually added customizations. Be aware that these will be lost when the config-set needs to be regenerated."

For the OP, I ran into this as well and could not get Brightcove's iFrame to work, so I ended up with this:

In mytheme.theme.

/**
 * Implements hook_preprocess_brightcove_player_responsive()
 *
 * We cannot render Brightcove inside CKEditor.
 */
function mytheme_theme_preprocess_brightcove_player_responsive(&$variables) {
  $variables['preview'] = FALSE;
  $route = \Drupal::routeMatch();
  if ($route instanceof RouteMatchInterface && $route->getRouteName() === 'embed.preview') {
    $variables['preview'] = TRUE;
  }
}

In mytheme/templates/brightcove/brightcove-player-responsive.html.twig

{% if preview %}
  {% set img_url = '/' ~ directory ~ '/imgs/video-thumbnail-.jpg' %}

  <div class="brightcove-player sizing-responsive">
    <div style="max-width: {{- max_width ~ units -}};">
      <img class="video__thumbnail" src="{{ img_url }}">
    </div>
  </div>
{% else %}
  <div class="brightcove-player sizing-responsive">
    <div style="max-width: {{- max_width ~ units -}};">
      <video-js class="vjs-fluid"
                controls=""
                data-account="{{- account -}}"
                data-embed="{{- embed -}}"
                data-player="{{- player -}}"
                data-usage="{{- data_usage -}}"
                data-{{- type -}}-id="{{- id -}}"
      ></video-js>
    </div>
    {% if is_playlist %}
      <ol class="vjs-playlist"></ol>
    {% endif %}
    <script src="//players.brightcove.net/{{- account -}}/{{- player -}}_{{- embed -}}/index.min.js"></script>
  </div>
{% endif %}

agentrickard → created an issue.

agentrickard → created an issue.

This MR needs to pull in the changes from 📌 Fix failing test Fixed

Latest patch is working nicely on Drupal 10.3.6.. Both import and export of a Layout Builder page work as expected.

This needs testing by people outside our project.

So you filed an MR that requires 10.3+ and didn't note that at all until after it was committed?

The current published release is now 1.6 and tests on GitLab CI with 10.3.

I will also note that I reviewed the module and it has no API and no clear means for adding items.

I would wait until it is stable and those are provided, as they are in Toolbar now.

I am going to remove the update hook because it has no added value to a site.

Any site that had an error due to basic_html would have already corrected it. New installs should be fine with the new config.

agentrickard → created an issue.

Sadly, the update hook breaks any customizations and this needs to be revisited.

8.x-1.x should be 10.3 compatible.

I am testing on Drupal 11 and the dev branch works fine.

I'll need a new issue if DEV isn't working on 10.3, with specific errors.

Are you able to test the dev branch to ensure it will be stable?

This is being worked as part of 📌 Fix failing tests Active

Still marked as experimental in 11.x

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/navig...

I'd be happy to review an MR though.

agentrickard → created an issue.

Fixed up tested and committed.

Nice work on the update hook.

Update hooks go in module .install files.

See 🐛 Do not use basic_html text format Needs review

Merged

agentrickard → made their first commit to this issue’s fork.

Toolbar is a core feature.

The open question is how this logo might fit with the other "Workbench" projects, which are listed here: https://www.drupal.org/project/project_browser/issues/3446128 📌 Logos for agentrickard Active

This was an error when updating code style.

agentrickard → made their first commit to this issue’s fork.

Duplicates 🐛 Fatal errors in WorkbenchBlock Needs review

agentrickard → created an issue.

Patch and MR.

agentrickard → created an issue.

MR is ready and the patch file.

agentrickard → created an issue.

Reviewed by client.

Patch version of the MR attached.

agentrickard → created an issue.

I merged that D11 compatibility already. This is open to try to resolve the GItLab CI issues with NEXT_VERSION (d11) testing.

Specifically #3469536: Test was run in child process and ended unexpectedly → .

It does happen consistently, yes.

Comments:

+    if (!empty($request_domain_id)) {
+      return $request_domain_id;
     }

PHPStan doesn't like the empty() construct and I this fails. There is an explicit NULL set just before this so is_null() should work.

Same issue a little further down:

+    $session_domain_id = $_SESSION['domain_config_ui_domain'] ?? NULL;
+    if (!empty($session_domain_id)) {
+      return $session_domain_id;
     }

+    if (!empty($request_language_id)) {
+      return $request_language_id;
     }
-    if (is_null($id) && isset($_SESSION['domain_config_ui_language'])) {
-      $id = $_SESSION['domain_config_ui_language'];
+
+    $session_language_id = $_SESSION['domain_config_ui_language'] ?? NULL;
+    if (!empty($session_language_id)) {
+      return $session_language_id;
     }

Here, I am not a big fan of multiple return values, which can make code harder to maintain.

   /**
    * {@inheritdoc}
    */
   public function getSelectedLanguageId() {
-    $id = NULL;
-
     $request = $this->getRequest();
-    if (!is_null($request)) {
-      $id = $this->currentRequest->get('domain_config_ui_language') ?? NULL;
+    $request_language_id = !is_null($request)
+      ? $this->currentRequest->get('domain_config_ui_language')
+      : NULL;
+
+    if (!empty($request_language_id)) {
+      return $request_language_id;
     }
-    if (is_null($id) && isset($_SESSION['domain_config_ui_language'])) {
-      $id = $_SESSION['domain_config_ui_language'];
+
+    $session_language_id = $_SESSION['domain_config_ui_language'] ?? NULL;
+    if (!empty($session_language_id)) {
+      return $session_language_id;
     }
 
-    return $id;
+    return NULL;
   }

That said -- I LOVE THE TESTS.

This was an inadvertent added (by me) during the PHPStan issue fix.

agentrickard → created an issue.

Not a duplicate. This change breaks my modules.

I have made some changes and this is ready for review. The files to change are detected using INFO_FILES=$(find -L . -name "*.info.yml") within the /modules/custom/$CI_PROJECT_NAME folder, not the top-level directory, to avoid finding every .info.yml. Then xargs sed as suggested.

Duplicates #3414505: Allow all sub-modules to be compatible with next_major →

The test fails are specific to GitLab behavior and I have filed an issue #3469521: Drupal 11 requires root info.yml file and breaks existing module tests →

If you look at the Jobs list, you can see the variant behavior on D11.

https://git.drupalcode.org/project/domain/-/jobs

Nothing in the code has changed except the test runner. This surfaced in 📌 Mark as Drupal 11 compatible Needs work

agentrickard → created an issue.

This is actually throwing test fails that need to be addressed before release.

agentrickard → changed the visibility of the branch 3226519-navigation-block-with-active-class to hidden.

agentrickard → changed the visibility of the branch 3226519-navigation-block-with-active-class to hidden.

Looks good but needs to be rebased.

Fixing.

The bot should auto-update the patch the next time it runs.

agentrickard → created an issue.

This is ready for merge.

Merged.

agentrickard → made their first commit to this issue’s fork.

Merged the D11 change.

agentrickard → made their first commit to this issue’s fork.

agentrickard → made their first commit to this issue’s fork.

Merged to "palantir".

I missed the note about the warnings – I think this is ready for to commit to the "palantir" branch and then we can work on cleanup.

I find these test instructions incomplete:

* How do I install yarn? Is yarn install sufficient?

* Should I run the commands inside or outside of DDEV?

Regardless of where I run the command, I get lots of warnings:

Warning: In order to avoid variable namspace collisions, we have updated the way to change settings for Breakpoint. Please change all instances of `$breakpoint-to-ems: {{setting}}` to `@include breakpoint-set('to ems', {{setting}})`. Variable settings, as well as this warning will be deprecated in a future release.
    node_modules/breakpoint-sass/stylesheets/breakpoint/_legacy-settings.scss 16:7  legacy-settings-warning()
    node_modules/breakpoint-sass/stylesheets/_breakpoint.scss 41:3                  breakpoint()
    sass/partials/drupalorg/redesign2018/_view-redesign-case-studies.scss 9:3       @import
    sass/styles.scss 95:9                                                           root stylesheet

Warning: 63 repetitive deprecation warnings omitted.

We made a tracking sheet for the content, which is uploaded to the ticket as a pdf.

To test this branch:

* Checkout the branch
* Add the default_content module to the repo
* drush en drupalorg_test_content -y

This should create the listed content fixtures.

When working with forum comments at least, we get this error:

TypeError: Drupal\forum\ForumIndexStorage::updateIndex(): Argument #1 ($node) must be of type Drupal\node\NodeInterface, null given, called in /var/www/html/web/core/modules/forum/forum.module on line 287 in /var/www/html/web/core/modules/forum/src/ForumIndexStorage.php on line 93 #0 /var/www/html/web/core/modules/forum/forum.module(287): Drupal\forum\ForumIndexStorage->updateIndex(NULL)

That suggests that the entity_id mapping isn't loading properly.

agentrickard → created an issue.

agentrickard → created an issue.

agentrickard → created an issue.

The MigrationDeriverTrait only has one method.

Removing the Trait call and moving that method into FileMigrationDependencyManager.php fixes the issue, but I suspect this may affect all uses of the Trait.

It seems to be a race condition regarding how the plugin alter hook gets called.

The latest patch introduces a hard dependency on migrate module inside file.module. That is not really acceptable, as it can cause errors in install from config.

Fatal error: During class fetch: Uncaught ReflectionException: Class "Drupal\migrate\Plugin\MigrationDeriverTrait" not found while loading "Drupal\file\FileMigrationDependencyManager". in /var/www/html/vendor/composer/ClassLoader.php:576 Stack trace: #0 [internal function]: Composer\Autoload\ClassLoader->loadClass('Drupal\\file\\Fil...') #1 /var/www/html/vendor/symfony/config/Resource/ClassExistenceResource.php(76): class_exists('Drupal\\file\\Fil...') #2 /var/www/html/vendor/symfony/dependency-injection/ContainerBuilder.php(361): Symfony\Component\Config\Resource\ClassExistenceResource->isFresh(0) #3 /var/www/html/vendor/symfony/dependency-injection/Compiler/RegisterAutoconfigureAttributesPass.php(32): Symfony\Component\DependencyInjection\ContainerBuilder->getReflectionClass('Drupal\\file\\Fil...', false) #4 /var/www/html/vendor/symfony/dependency-injection/Compiler/Compiler.php(80): Symfony\Component\DependencyInjection\Compiler\RegisterAutoconfigureAttributesPass->process(Object(Drupal\Core\DependencyInjection\ContainerBuilder)) #5 /var/www/html/vendor/symfony/dependency-injection/ContainerBuilder.php(767): Symfony\Component\DependencyInjection\Compiler\Compiler->compile(Object(Drupal\Core\DependencyInjection\ContainerBuilder)) #6 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(1447): Symfony\Component\DependencyInjection\ContainerBuilder->compile() #7 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(971): Drupal\Core\DrupalKernel->compileContainer() #8 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(515): Drupal\Core\DrupalKernel->initializeContainer() #9 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(739): Drupal\Core\DrupalKernel->boot() #10 /var/www/html/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #11 {main} in /var/www/html/web/core/modules/file/src/FileMigrationDependencyManager.php on line 18

agentrickard → created an issue.

agentrickard → made their first commit to this issue’s fork.

Merged.

agentrickard → created an issue.

agentrickard → created an issue.

Merged!