Automated Drupal 11 compatibility fixes for styleguide

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

The MR works in the local development environment on Drupal 11.0.0.
I have attached a screenshot of the page.

Apply this MR for D11 now with:

...
    "repositories": {
        "https://packages.drupal.org/8": {
            "canonical": false,
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        },
        "https://drupal.org/node/3434813": {
            "canonical": false,
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/styleguide-3434813.git"
        },
    },
...
    "require": {
        "drupal/styleguide": "dev-project-update-bot-only",
    }
...

I removed the drupal/core requirement from the new composer.json file. Previously the documentation on adding a composer.json file specified that it's better to not define drupal/core as a dependency. But I just discovered that information was removed earlier this month, see https://www.drupal.org/node/2514612/revisions/view/13628499/13705720 → . Still, it's unnecessary and it can be a pain for someone who is updating modules.

I also removed compatibility for unsupported versions of Core, which has been my practice in the modules that I maintain.

@dcam with your changes the PR now couldn't install with composer...

$ sudo -E composer update -n --ignore-platform-reqs
Gathering patches for root package.
Loading composer repositories with package information
                                                      
Skipped branch project-update-bot-only, "dde82c4462415a5b82679b994e448f246034fd9a:composer.json" does not contain valid JSON
Parse error on line 7:
...roject/styleguide",}
---------------------^
Expected: 'STRING' - It appears you have an extra trailing comma


In VcsRepository.php line 421:
                                                                                                             
  No valid composer.json was found in any branch or tag of https://git.drupalcode.org/issue/styleguide-3434  
  813.git, could not load a package from it.

Sorry about that. It was a hastily-made in the web IDE. I should know better.

I saw minimum Drupal version is 10.3 so removed previous phpunit variables.
If D9 support is required then please do add back those variables for executing the phpunit on previous versions.

Any news?

I removed any changes not related to upgrading the version compatibility. Earlier today I attempted to apply the MR's diff as a patch so that I can use the composer lenient plugin and proceed with a D11 upgrade. Unfortunately, the diff couldn't be applied for some reason. I wondered if the unrelated changes were the problem, so I took them out. Without the extra stuff the MR could be applied, and I was able to proceed with upgrading the site to D11.

I left in my removal of D9 compatibility. You can't test against D9, so you can't guarantee compatibility. That means future changes may break compatibility and you wouldn't even know until you start getting bug reports.

I'm marking this MR as RTBC. I know that marking your own changes as RTBC is taboo in Drupal Core, but this isn't Core. It's a one-line change. If no maintainer is interested in applying the MR, then consider giving me maintainer rights and I'll merge it. I'm not crazy about the idea of taking on yet another module that past maintainers have lost interest in and I don't know much about, but I'm willing to do it.

Sorry @dcam, i give a re-rollback with composer.json so it could be install normally with (also giving it a git rebase -i origin/2.x into single GIT commit):

{
    "repositories": {
        "https://drupal.org/node/3434813": {
            "canonical": false,
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/styleguide-3434813.git"
        },
    },
    "require": {
        "drupal/styleguide": "dev-project-update-bot-only",
    },
}

I've been allowed to maintain the module. FYI, I'm removing the composer.json file, but I'll add it in a separate issue. I'd rather maintain separation of concerns so that changes are easier to revert with Git.

dcam → credited agentrickard → .

dcam → credited chandansha → .

dcam → credited msnassar → .

Something is wrong with MR 15. I've tried several times to use the merge tool, but it keeps failing. It's possible that all the mangling of that branch is causing an issue. So I opened a new MR 24.

dcam → changed the visibility of the branch 3434813-D11-compatibility to hidden.

That didn't work either.

Fine. We'll do this the old-fashioned way.

Thank you to everyone who worked on this issue!

dcam → changed the visibility of the branch project-update-bot-only to hidden.

dcam → changed the visibility of the branch 3434813-automated-drupal-11 to hidden.