hswong3i → made their first commit to this issue’s fork.
hswong3i → made their first commit to this issue’s fork.
acke → credited hswong3i → .
@itamair some feedback:
parsing of Lat and Lon to 6 digit float
This is somehow a nice idea (but seems not important?), if we have limitation in backend database schema from Drupal Leaflet module point of view.
trigger dynamic sync / update of the proximity-origin-summary Lat and Lon elements (eventually present in case check/selection of "Show (anyway) the Origin coordinates as summary in the Exposed Form" option
This doesn't looks like a good idea for me, since the Leaflet.SyncView itself is design for generic Leaflet use case (but not Drupal specific integration only).
Hard-coded with .geofield-lat-summary may generate upgrade difficulties if Geofield update it's own implementation.
IMHO, keep Leaflet.SyncView as isolated and independent with it downstream integration could provide much better flexibility.
Finally, I had create https://www.npmjs.com/package/@drustack/leaflet.syncview/v/1.9.3 which partly integrate the "parsing of Lat and Lon to 6 digit float" implementation, please kindly comment ;-)
hswong3i → created an issue.
hswong3i → changed the visibility of the branch 3307927-php8.1-deprecated-function to active.
hswong3i → changed the visibility of the branch 3307927-php8.1-deprecated-function to hidden.
Similar as #9 @kazarobert reported, now when running with PHP 8.3 + Drupal 11.0.4 + Captcha 2.0.x-dev, with following condition:
- Newly installed Drupal
- NONE of wrong response captcha, yet (i.e.
captcha.wrong_response_counternow return null) - Enable "Enable statistics"
- Access Status Report page (i.e. trigger
captcha_requirements()fromcaptcha.install)
Will generate following PHP error message:
[Sun Sep 29 10:47:36 2024] Uncaught PHP Exception TypeError: "Drupal\Component\Utility\Html::escape(): Argument #1 ($text) must be of type string, null given, called in /home/hswong3i/Documents/drustack/composer-project-website-skeleton-11.0.x/core/lib/Drupal/Component/Render/FormattableMarkup.php on line 256" at /home/hswong3i/Documents/drustack/composer-project-website-skeleton-11.0.x/core/lib/Drupal/Component/Utility/Html.php line 431
Simply patch as below could fix the problem:
diff --git a/captcha.install b/captcha.install
index f8161f6..c68361a 100755
--- a/captcha.install
+++ b/captcha.install
@@ -97,7 +97,7 @@ function captcha_requirements($phase) {
$requirements['captcha_wrong_response_counter'] = [
'title' => \Drupal::translation()->translate('CAPTCHA'),
'value' => \Drupal::translation()->formatPlural(
- \Drupal::state()->get('captcha.wrong_response_counter'),
+ \Drupal::state()->get('captcha.wrong_response_counter', 0),
'Already 1 blocked form submission',
'Already @count blocked form submissions'
),
hswong3i → made their first commit to this issue’s fork.
@dcam with your changes the PR now couldn't install with composer...
$ sudo -E composer update -n --ignore-platform-reqs
Gathering patches for root package.
Loading composer repositories with package information
Skipped branch project-update-bot-only, "dde82c4462415a5b82679b994e448f246034fd9a:composer.json" does not contain valid JSON
Parse error on line 7:
...roject/styleguide",}
---------------------^
Expected: 'STRING' - It appears you have an extra trailing comma
In VcsRepository.php line 421:
No valid composer.json was found in any branch or tag of https://git.drupalcode.org/issue/styleguide-3434
813.git, could not load a package from it.
hswong3i → made their first commit to this issue’s fork.
Apply this MR for D11 now with:
...
"repositories": {
"https://packages.drupal.org/8": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"https://drupal.org/node/3430336": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/eu_cookie_compliance-3430336.git"
},
},
...
"require": {
"drupal/eu_cookie_compliance": "dev-3430336-Drupal-11-readiness",
}
...
Merged with https://www.drupal.org/node/3258142 →
hswong3i → made their first commit to this issue’s fork.
Apply this MR for D11 now with:
...
"repositories": {
"https://packages.drupal.org/8": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"https://drupal.org/node/3430336": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/eu_cookie_compliance-3430336.git"
},
},
...
"require": {
"drupal/eu_cookie_compliance": "dev-3430336-Drupal-11-readiness",
}
...
Apply this MR for D11 now with:
...
"repositories": {
"https://packages.drupal.org/8": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"https://drupal.org/node/3428399": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/coffee-3428399.git"
},
},
...
"require": {
"drupal/coffee": "dev-3428399-automated-drupal-11",
}
...
Apply this MR for D11 now with:
...
"repositories": {
"https://packages.drupal.org/8": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"https://drupal.org/node/3454104": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/select2-3454104.git"
},
},
...
"require": {
"drupal/select2": "dev-3454104-drupal-11-compatibility",
}
...
Merged with https://www.drupal.org/node/3211796 →
hswong3i → made their first commit to this issue’s fork.
Apply this MR for D11 now with:
...
"repositories": {
"https://packages.drupal.org/8": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"https://drupal.org/node/3434813": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/styleguide-3434813.git"
},
},
...
"require": {
"drupal/styleguide": "dev-project-update-bot-only",
}
...
Apply this MR for D11 now with:
...
"repositories": {
"https://packages.drupal.org/8": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"https://drupal.org/node/3451339": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/svg_image-3451339.git"
},
},
...
"require": {
"drupal/svg_image": "dev-project-update-bot-only",
}
...
@itamair I am now using https://github.com/drustack/Leaflet.ResetView/ and https://github.com/drustack/Leaflet.SyncView for https://www.wastereduction.gov.hk/en-hk/recycling-map since 3 years agos:
You could test the drustack/Leaflet.SyncView functionality by:
- Move the map by mouse
- The X/Y is now sync to the hidden form value for search
- Click the "Search this Area"
- Now the search result will be directly related to recent updated X/Y
Merge with https://www.drupal.org/node/3229045 →
Apply this MR for D11 now with:
...
"repositories": {
"https://packages.drupal.org/8": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"https://drupal.org/node/3447460": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/features-3447460.git"
},
},
...
"require": {
"drupal/features": "dev-3447460-drupal-11-compatibility",
}
...
hswong3i → made their first commit to this issue’s fork.
Apply this MR for D11 now with:
...
"repositories": {
"https://packages.drupal.org/8": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"https://drupal.org/node/3435091": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/translatable_menu_link_uri-3435091.git"
},
},
...
"require": {
"drupal/translatable_menu_link_uri": "dev-3435091-automated-drupal-11",
}
...
hswong3i → made their first commit to this issue’s fork.
hswong3i → created an issue.
This MR could now apply for D11 with:
...
"repositories": {
"drupal": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"drupal/xmlsitemap": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/xmlsitemap-3435760.git"
},
},
...
"require": {
"drupal/xmlsitemap": "dev-3435760-automated-drupal-11",
}
...
I give merge with https://www.drupal.org/node/3435903 → with:
curl -skL https://git.drupalcode.org/project/webform/-/merge_requests/429.patch | git am --keep-cr
And apply this MR for D11 now with:
...
"repositories": {
"drupal": {
"canonical": false,
"type": "composer",
"url": "https://packages.drupal.org/8"
},
"drupal/webform": {
"canonical": false,
"type": "vcs",
"url": "https://git.drupalcode.org/issue/webform-3465838.git"
},
},
...
"require": {
"drupal/webform": "dev-3465838-drupal-11-compatibility",
}
...
hswong3i → made their first commit to this issue’s fork.
Convert to MR, rebase with 8.x-1.x-dev
hswong3i → made their first commit to this issue’s fork.
Convert to MR, rebase with 8.x-1.x-dev
hswong3i → made their first commit to this issue’s fork.
Convert to MR, rebase with 8.x-1.x-dev
hswong3i → made their first commit to this issue’s fork.
hswong3i → created an issue.
Recreate MR via 10.2.x-dev
Patch re-roll from #15 via 8.x-3.x-dev and convert as PR
@bkosborne #11 not working for me and report error message as below:
NOTICE: PHP message: Uncaught PHP Exception TypeError: "Drupal\Core\Render\Renderer::addCacheableDependency(): Argument #1 ($elements) must be of type array, null given, called in /var/www/html/modules/contrib/asset_injector/asset_injector.module on line 141" at /var/www/html/core/lib/Drupal/Core/Render/Renderer.php line 690
Rolling back with #7 looks much better ?_?
hswong3i → made their first commit to this issue’s fork.
hswong3i → made their first commit to this issue’s fork.
#26
✨
Add menu_link_content support into views
Needs work
missing the additional core/modules/menu_link_content/src/MenuLinkContentViewsData.php
Additional MR for 10.2.x and 11.x had been created.
hswong3i → made their first commit to this issue’s fork.
hswong3i → made their first commit to this issue’s fork.
hswong3i → made their first commit to this issue’s fork.
I get following error message once fetching the latest 8.x-2.x-dev:
NOTICE: PHP message: Uncaught PHP Exception TypeError: "Drupal\Core\Render\Renderer::addCacheableDependency(): Argument #1 ($elements) must be of type array, null given, called in /var/www/html/modules/contrib/asset_injector/asset_injector.module on line 153" at /var/www/html/core/lib/Drupal/Core/Render/Renderer.php line 768
After rolling back the patch, issue get fixed:
cd /var/www/html/modules/contrib/asset_injector
curl -skL https://git.drupalcode.org/project/asset_injector/-/commit/e9c6d068752a7f152ee1d013e54eda2112daee35.patch | patch -p1 -Rhswong3i → made their first commit to this issue’s fork.
Re-roll https://git.drupalcode.org/project/drupal/-/commit/a5117b293edc1211c0e72... via 9.5.x-dev
Update MR https://git.drupalcode.org/project/drupal/-/merge_requests/1521 with 10.1.x
@AdamPS confirm #11 working for my DruStack, see https://github.com/drustack/composer-project-website-skeleton/commit/6dd...
Once patch applied and `drush -y cr`, site up and running once again, able to enable other else modules with no issue.
Thank you very much ;-)