php8.1 Deprecated function : htmlspecialchars(): Passing null to parameter #1

Similar as #9 @kazarobert reported, now when running with PHP 8.3 + Drupal 11.0.4 + Captcha 2.0.x-dev, with following condition:

1. Newly installed Drupal
2. NONE of wrong response captcha, yet (i.e. captcha.wrong_response_counter now return null)
3. Enable "Enable statistics"
4. Access Status Report page (i.e. trigger captcha_requirements() from captcha.install)

Will generate following PHP error message:

[Sun Sep 29 10:47:36 2024] Uncaught PHP Exception TypeError: "Drupal\Component\Utility\Html::escape(): Argument #1 ($text) must be of type string, null given, called in /home/hswong3i/Documents/drustack/composer-project-website-skeleton-11.0.x/core/lib/Drupal/Component/Render/FormattableMarkup.php on line 256" at /home/hswong3i/Documents/drustack/composer-project-website-skeleton-11.0.x/core/lib/Drupal/Component/Utility/Html.php line 431

Simply patch as below could fix the problem:

diff --git a/captcha.install b/captcha.install
index f8161f6..c68361a 100755
--- a/captcha.install
+++ b/captcha.install
@@ -97,7 +97,7 @@ function captcha_requirements($phase) {
     $requirements['captcha_wrong_response_counter'] = [
       'title' => \Drupal::translation()->translate('CAPTCHA'),
       'value' => \Drupal::translation()->formatPlural(
-        \Drupal::state()->get('captcha.wrong_response_counter'),
+        \Drupal::state()->get('captcha.wrong_response_counter', 0),
         'Already 1 blocked form submission',
         'Already @count blocked form submissions'
       ),

hswong3i → changed the visibility of the branch 3307927-php8.1-deprecated-function to hidden.

hswong3i → changed the visibility of the branch 3307927-php8.1-deprecated-function to active.

Tested that the patch works and solves the error on "Status report" page.

Good catch hswong3i, committed!

Automatically closed - issue fixed for 2 weeks with no activity.