Tallinn
Account created on 18 September 2009, over 14 years ago
#

Recent comments

🇪🇪Estonia ram4nd Tallinn
  • The initial focus should be on the dialog container with role="dialog".
🇪🇪Estonia ram4nd Tallinn

ram4nd created an issue.

🇪🇪Estonia ram4nd Tallinn
  • When the dialog is visible and the focus has been moved on it, the keyboard focus must remain within modal dialogs when open.
🇪🇪Estonia ram4nd Tallinn
  • Add aria-labelledby to the dialog.
  • Modal title should be heading not div.
  • Add role close to close link(button).
🇪🇪Estonia ram4nd Tallinn
  • Add role dialog to container. Also add tabindex -1 so it can be focused by js and thus announced by screen reader.
  • Fix keyboard detection, there is no "e.key" value Space.
🇪🇪Estonia ram4nd Tallinn

Focus getting lost when modal dialog is closed by using Close button.

🇪🇪Estonia ram4nd Tallinn

Add if condition to validate that "top" is set on sticking.

🇪🇪Estonia ram4nd Tallinn

Go through parents and their siblings to get elements that have been made sticky. I think this is better approach than is used with .is-sticky where distance from top is calculated.

Production build 0.69.0 2024