🇪🇪Estonia @ram4nd

ram4nd → created an issue.

Needs to be merged to D7 too

As per #3

Works, but produced a notice.

• The initial focus should be on the dialog container with role="dialog".

ram4nd → created an issue.

ram4nd → created an issue.

ram4nd → created an issue.

• When the dialog is visible and the focus has been moved on it, the keyboard focus must remain within modal dialogs when open.

Yes I am still interested.

• Add aria-labelledby to the dialog.
• Modal title should be heading not div.
• Add role close to close link(button).

• Add role dialog to container. Also add tabindex -1 so it can be focused by js and thus announced by screen reader.
• Fix keyboard detection, there is no "e.key" value Space.

Marking RTBC due to #16

ram4nd → created an issue.

Focus getting lost when modal dialog is closed by using Close button.

Add if condition to validate that "top" is set on sticking.

Go through parents and their siblings to get elements that have been made sticky. I think this is better approach than is used with .is-sticky where distance from top is calculated.

ram4nd → created an issue.

ram4nd → created an issue.

ram4nd → created an issue.

Needs a correct patch.