To me it is a question of what the module actually is. I know that libraries are preferably not bundled in modules. But this seems to be the exception. I am not worried about bumping the minor version if there would be never version of 3. Since the module never was focused on CDN implementation, but bundling jQuery for replacement in core. I personally would prefer it to be updated in core itself, but it seems using jquery_update is preferred by the community. The changes posted seemed appropriate to me.
The problems in my eyes are:
- There are some style changes that need to be added.
- You would have to add jquery.ui on every single page, instead of loading it with
$form['#attached']['library'][] = array('system', 'ui.dialog');. - Consistency, the deprecated versions are selectable via dropdown, but correct version is not? Reverting to urls, is kind of getting past the point of the module.
ram4nd → changed the visibility of the branch 3419849-jquery-4.0-support to hidden.
ram4nd → changed the visibility of the branch 3479425-d7-module-and to hidden.
ram4nd → changed the visibility of the branch drupal-3479425-3479425-d7-module-and to hidden.
ram4nd → changed the visibility of the branch 3482184-d7-protect-pager to hidden.
There is another case of .style.display === 'none' in misc/vertical-tabs.js.
I am thinking that it would be correct to validate int only. But the patch is to check string and int, at this point we probably don't want to introduce new possible problems.
ram4nd → created an issue. See original summary → .
Doesn't seem like you missed anything.
Tested that the patch works and solves the error on "Status report" page.
It worked, I simplified the if condition. And I added position support as well.
Simply converted logout page to confirmation form. What else should be backported/implemented? And then it needs tests too.
ram4nd → created an issue. See original summary → .
If I remember correctly, I backported it from D11 not D10.
Why is this marked fixed?
Replaced by own code with back port from Drupal 11. https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util...
I also reproduced this on Drupal 7 and opened a child issue. I used D7 Lando instance with PHP 8.3 and "Error messages to display" is set to "None".
Needs to be merged to D7 too
As per #3
Works, but produced a notice.
- The initial focus should be on the dialog container with role="dialog".
- When the dialog is visible and the focus has been moved on it, the keyboard focus must remain within modal dialogs when open.
Yes I am still interested.
- Add aria-labelledby to the dialog.
- Modal title should be heading not div.
- Add role close to close link(button).
- Add role dialog to container. Also add tabindex -1 so it can be focused by js and thus announced by screen reader.
- Fix keyboard detection, there is no "e.key" value Space.
Marking RTBC due to #16
Focus getting lost when modal dialog is closed by using Close button.
Add if condition to validate that "top" is set on sticking.
Go through parents and their siblings to get elements that have been made sticky. I think this is better approach than is used with .is-sticky where distance from top is calculated.