Typo in WidgetInterface.php

Created on 12 November 2024, 5 months ago

Problem/Motivation

There's a typo in a WidgetInterface.php comment.

Proposed resolution

A MR is coming.

🐛 Bug report
Status

Active

Version

11.1 🔥

Component

field system

Created by

🇫🇷France Kgaut

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Kgaut
  • Merge request !10155fix typo in WidgetInterface.php cf 3486996 → (Open) created by Kgaut
  • Pipeline finished with Failed
    5 months ago
    Total: 864s
    #336433
  • 🇬🇧United Kingdom longwave UK

    Usually we try to fix all instances of the same issue in one go, with a regular expression search [^\.]\.\.$ we can find all instances of two periods at the end of a line so let's try to address all these at once:

    core/tests/Drupal/Tests/Core/Plugin/Discovery/TestDerivativeDiscoveryWithObject.php
    10: * Defines test derivative discovery using an object..
    
    core/tests/Drupal/Tests/Core/Asset/library_test_files/licenses.libraries.yml
    1:# No license information: should default to GPL 2.0 or later..
    
    core/lib/Drupal/Component/PhpStorage/FileStorage.php
    26:   *     the same configuration, but for different bins..
    
    core/lib/Drupal/Core/Cache/CacheTagsChecksumTrait.php
    135:    // so return early..
    
    core/lib/Drupal/Core/Cache/Context/CacheContextsManager.php
    162:   *   A representative subset of the given set of cache context tokens..
    
    core/lib/Drupal/Core/Routing/AccessAwareRouterInterface.php
    15:   * Attribute name of the access result for the request..
    
    core/lib/Drupal/Core/Routing/StackedRouteMatchInterface.php
    22:   * Gets the master route match..
    
    core/lib/Drupal/Core/Form/FormBuilder.php
    850:    // when the request uri starts with multiple slashes..
    
    core/lib/Drupal/Core/Field/WidgetInterface.php
    14: * Drupal\Core\Field\WidgetBase..
    
    core/misc/tabledrag.js
    261:    // manipulate form elements directly, rather than using drag-and-drop..
    
    core/modules/search/search.pages.inc
    53:  // Provide separated and grouped meta information..
    
    core/modules/pgsql/src/Driver/Database/pgsql/Schema.php
    1098:   * Retrieves a sequence name that is owned by the table and column..
    
    core/modules/locale/tests/src/Functional/LocaleImportFunctionalTest.php
    122:    // Check empty files import with a user that cannot access site reports..
    
    core/modules/menu_ui/tests/src/Functional/MenuUiNodeTest.php
    307:    // Enable translation for pages and menu link content..
    
    core/modules/ckeditor5/tests/src/Unit/HTMLRestrictionsTest.php
    955:    // Basic cases: attributes..
    
    core/modules/user/src/UserInterface.php
    137:   * Sets the UNIX timestamp when the user last accessed the site..
    
    core/modules/views_ui/tests/src/Functional/GroupByTest.php
    8: * Tests UI of aggregate functionality..
    
    core/modules/options/tests/src/Functional/OptionsWidgetsTest.php
    619:    // Verify that a test radio button has a "N/A" choice..
    
    core/modules/field/src/FieldStorageConfigInterface.php
    136:   * Sets the custom storage indexes for the field data storage..
    
    core/modules/views/src/Plugin/views/style/StylePluginBase.php
    482:   *   - rows: The result rows to be rendered in this group..
    
    core/modules/views/src/Plugin/views/field/FieldHandlerInterface.php
    62:   * Returns a wrapper HTML element for the field..
    
    core/modules/views/src/Plugin/views/display/PathPluginBase.php
    267:    // Find all paths which match the path of the current display..
    
    core/modules/views/tests/src/Functional/Plugin/PagerTest.php
    535:    // Translation mapping..
    
    core/modules/contact/tests/src/Functional/ContactSitewideTest.php
    559:   *   The path where user will be redirect after this form has been submitted..
    
    core/modules/system/tests/src/Functional/Form/ElementTest.php
    182:   * Tests a form with an autocomplete setting..
    
    core/modules/migrate/src/Row.php
    416:   * Returns the hash for the source values..
    
  • 🇺🇸United States smustgrave

    Good point @longwave

  • 🇫🇷France Kgaut

    Done @longwave :)

  • Pipeline finished with Success
    5 months ago
    Total: 534s
    #336572
  • 🇪🇪Estonia ram4nd Tallinn
  • 🇬🇧United Kingdom alexpott 🇪🇺🌍
  • 🇺🇦Ukraine init90 Ukraine
  • 🇨🇳China jungle Chongqing, China
  • 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
  • 🇳🇿New Zealand quietone

    Thanks for working to improve the readability of our comments.

    This is actually a Coding standard fix and should be done by a sniff, so that we can be sure no such errors are introduced in the future. Unfortunately, this is a duplicate of an existing core issue which already has a patch, so this is duplicating existing editing and review work. Since we are already waiting on the sniff, I am closing the other issue as a duplicate because this has an MR, which is preferred and postponing on the sniff. I am also moving credit from that issue.

    And updating the issue meta data to use the 'main' branch which is 11.x, and set to a 'Task' in the 'other' component which is where coding standards issues normally go and adding as a child of the Meta for PHP coding standards.

    Cheers

Production build 0.71.5 2024