- 🇫🇷France dydave
Hi everyone,
Thank you very much for raising this issue and contributing a patch, it's greatly appreciated.
This issue seems to also apply to more recent versions of the module and based on the D7 version of the patch, I was able to make similar adjuments in the JS files of the current D9 version of the module (2.0.x').
Pleas find attached to this reply an updated patch, for the D9 version of the module:
shs-support-disabled-form-element-3215145-2.patchWe would greatly appreciate if you could please try testing/reviewing the patch and let us know if you encounter any issues.
Feel free to let us know if you have any questions on the patch, or this ticket in general, we would be glad to provide more information.
Thanks in advance! - 🇫🇷France StephaneQ Paris 🇫🇷
Hello,
I encountered this issue on a project and the provided patch fixed it. Thanks.
- Status changed to RTBC
10 months ago 11:26am 4 February 2024 - Merge request !25Issue #3215145 by ram4nd, DYdave: Fixed module's behavior when form element is disabled. → (Open) created by dydave
- 🇫🇷France dydave
Thanks a lot everyone for your positive feedback and reviews.
Just a quick comment to let maintainers know the patch was applied in issue's merge request at #5 which is now ready to be reviewed and merged in !MR25.
Feel free to let us know if there is anything you would like to see added to the merge request or if you have questions or concerns on any of the changes, we would surely be glad to help.
Thanks in advance for the reviews, comments and feedback. -
joseph.olstad →
committed ccf89716 on 7.x-1.x
Issue #3215145 by ram4nd: Not working when form element is disabled
-
joseph.olstad →
committed ccf89716 on 7.x-1.x
- Status changed to Fixed
9 months ago 5:59pm 22 March 2024 - Status changed to Needs review
9 months ago 8:09am 23 March 2024 - 🇫🇷France dydave
Hi Joseph (@joseph.olstad),
Thanks a lot for your feedback and help on this issue committing the changes to the D7 branch of the module at #8.
Could we please get this committed to the 2.0.x branch as well ?
See the corresponding merge request: MR!25.Any feedback, suggestions or comments would be greatly appreciated.
Thanks in advance ! -
joseph.olstad →
committed 4f3a1ff5 on 2.0.x
Issue #3215145 by DYdave, ram4nd, StephaneQ: Not working when form...
-
joseph.olstad →
committed 4f3a1ff5 on 2.0.x
- Status changed to Fixed
8 months ago 6:34pm 24 March 2024 - 🇫🇷France dydave
Thanks Joseph (@joseph.olstad) for the speedy reply, it's greatly appreciated !
-
joseph.olstad →
committed e5bb05f1 on 2.0.x
Revert "Revert "Issue #3215145 by DYdave, ram4nd, StephaneQ: Not working...
-
joseph.olstad →
committed e5bb05f1 on 2.0.x
-
joseph.olstad →
committed 2d9539c4 on 2.0.x
Revert "Issue #3215145 by DYdave, ram4nd, StephaneQ: Not working when...
-
joseph.olstad →
committed 2d9539c4 on 2.0.x
-
joseph.olstad →
committed b21f9481 on 2.0.x
Issue #3215145 by DYdave, ram4nd, StephaneQ: Not working when form...
-
joseph.olstad →
committed b21f9481 on 2.0.x
- 🇨🇦Canada joseph.olstad
Sorry about the noise here, sorting this out.
It's going into both 2.0.x and 3.0.x
and tagged 2.0.0-rc10 just now
Automatically closed - issue fixed for 2 weeks with no activity.