- last update
4 months ago 8 pass - πΊπΈUnited States bkosborne New Jersey, USA
Okay, that makes sense. I didn't realize I could pull the tags and contexts from that interface. Here's an updated patch that does that.
- Status changed to Needs work
3 months ago 1:41pm 3 June 2024 - π©πͺGermany Anybody Porta Westfalica
Thanks @bkosborne patch LGTM so far, perhaps it would make sense to proceed using a MR instead of patches? Would you do that?
Furthermore some simple tests might be good to ensure it works as expected.
- First commit to issue fork.
- Merge request !23Issue #3181674 by bkosborne, pookmish, geek-merlin: Page and dynamic page... β (Open) created by hswong3i
- last update
3 months ago 8 pass - last update
3 months ago 4 fail - ππ°Hong Kong hswong3i
@bkosborne #11 not working for me and report error message as below:
NOTICE: PHP message: Uncaught PHP Exception TypeError: "Drupal\Core\Render\Renderer::addCacheableDependency(): Argument #1 ($elements) must be of type array, null given, called in /var/www/html/modules/contrib/asset_injector/asset_injector.module on line 141" at /var/www/html/core/lib/Drupal/Core/Render/Renderer.php line 690
Rolling back with #7 looks much better ?_?
- πΊπΈUnited States bkosborne New Jersey, USA
I don't see how that's possible. $elements is an array typed property on the function. If it were null, PHP should have thrown a different error when _asset_injector_add_element_libraries was invoked. What version of Asset Injector are you using, and what other patches (if any) do you have applied?
- π©πͺGermany Anybody Porta Westfalica