- Issue created by @mark_fullmer
- Status changed to Needs review
5 months ago 10:14am 30 July 2024 - 🇮🇳India Rajan Kumar@2026
Hii @mark_fullmer
I have created patch for "Drupal 11 compatibility for Features module" . Thanks
- Status changed to RTBC
4 months ago 1:22am 28 August 2024 - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Came across this patch because I wanted to work features into a demo. I can't even get the demo going because I can't get features included via composer.
We need this in.
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
I think this patch needs more testing. I did the following:
- I rolled a brand new D11 site with just features (and the require dependency, config_update and features_ui, installed).
- I navigated to the features_ui admin page (/admin/config/development/features) and received the following error:
The website encountered an unexpected error. Try again later. Error: Call to a member function getName() on null in Drupal\features_ui\Form\FeaturesExportForm->buildPackageDetail() (line 382 of modules/contrib/features/modules/features_ui/src/Form/FeaturesExportForm.php). Drupal\features_ui\Form\FeaturesExportForm->buildListing() (Line: 181) Drupal\features_ui\Form\FeaturesExportForm->buildForm() call_user_func_array() (Line: 528) Drupal\Core\Form\FormBuilder->retrieveForm() (Line: 279) Drupal\Core\Form\FormBuilder->buildForm() (Line: 73) Drupal\Core\Controller\FormController->getContentResult() call_user_func_array() (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593) Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183) Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76) Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53) Drupal\Core\StackMiddleware\Session->handle() (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28) Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32) Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 106) Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85) Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36) Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709) Drupal\Core\DrupalKernel->handle() (Line: 19)
- First commit to issue fork.
- Merge request !39Issue #3447460: Drupal 11 compatibility for Features module → (Open) created by hswong3i
- 🇭🇰Hong Kong hswong3i
Apply this MR for D11 now with:
... "repositories": { "https://packages.drupal.org/8": { "canonical": false, "type": "composer", "url": "https://packages.drupal.org/8" }, "https://drupal.org/node/3447460": { "canonical": false, "type": "vcs", "url": "https://git.drupalcode.org/issue/features-3447460.git" }, }, ... "require": { "drupal/features": "dev-3447460-drupal-11-compatibility", } ...
- 🇺🇸United States bradallenfisher
so should we just manually install this for D11?
- 🇺🇸United States mark_fullmer Tucson
The latest two commits address compatibility with PHPUnit 10 and PHP 8.2:
- Unit test dataProviders must be static methods, per https://www.drupal.org/project/drupal/issues/3353210 📌 [PHPUnit 10] @dataProvider methods must be declared static and public Fixed
- Creation of dynamic properties are deprecated, per https://www.php.net/manual/en/migration82.deprecated.php
PHPUnit tests are green for both Drupal 10 and Drupal 11. This is ready for a narrowly-scoped release, 8.x-3.16, which would include only this change and https://git.drupalcode.org/project/features/-/commit/d8bb8c1baa795b93b27... compared to 8.x-3.15.
- 🇺🇸United States mark_fullmer Tucson
Can the maintainers provide a timeline for when this compatibility will be provided in a new release? Thanks for all the work you do!