- Status changed to Needs review
about 2 years ago 12:09pm 21 March 2023 - 🇸🇰Slovakia gresko8
I tested the patch in #21 and it works well. Thanks!
The only thing that probably needs to be fixed is that we still have the checkboxes in field formatter settings. Since they are ignored because the actual settings stored on the entity are used, we should probably get rid of them.
- Status changed to Needs work
over 1 year ago 11:52am 14 August 2023 - 🇮🇹Italy lolandese Turin, Italy
See comment #23:
We still have the checkboxes in field formatter settings but these are now ignored.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Please use an issue fork and merge request.
- First commit to issue fork.
- 🇺🇸United States agentrickard Georgia (US)
Patch no longer applies cleanly.
- Merge request !41Issue #3128030: Make "Header orientation" a per-entity setting → (Open) created by agentrickard
- 🇺🇸United States agentrickard Georgia (US)
This is working fine on a clean install, but when applied to an existing Drupal 11 site, the `Use header` option still appears.
Investigating.
- 🇺🇸United States agentrickard Georgia (US)
MR is ready for review.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
There is one coding standards issue to fix.
- 🇺🇸United States agentrickard Georgia (US)
Odd, I would have expected the MR to not have a green check in that case.
Anyway, fixed.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Coding standards issues do not prevent tests from being counted as passed.
- 🇺🇸United States agentrickard Georgia (US)
Yeah,. I thought we could set that to strict. I suppose we can only skip them.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
It can be configured so that coding standards issues create failures instead of warnings and then the overall will report a failure.
- 🇺🇸United States agentrickard Georgia (US)
All that aside, this seems to be working as expected.