🇸🇰Slovakia @gresko8

Attaching a patch.

gresko8 → created an issue.

I agree that this makes sense according to the google documentation.

Thanks for the patch, I included it in my project.

I think this can be RTBC.

Thanks for the MR! I also bumped into this problem and can confirm the fix works.

gresko8 → created an issue.

Accidentaly missed some chunks of code in my last patch. Attaching a new one.

Attaching a re-rolled patch.

I plan to work on the WYSIWYG integration in the coming weeks.

I looked into the option of porting the Backdrop core module but decided that this is probably not the right way to go, as I found too many differences/additions in the core code that the ckeditor5 module is relying on.

The build process for CKEditor library created in this issue is throwing a lot of errors/warnings for me and after building I also had errors in the console for missing plugins when testing.

I'm testing switching the library building approach to the one that backdrop CMS is using here: https://github.com/backdrop/backdrop/blob/1.x/core/modules/ckeditor5/lib...

I managed to build the library without errors and used it successfully with some updates to the code from the merge request in this issue.

I plan to work on this further, hopefully managing to add a config UI for the toolbar as well.

Attaching a patch.

gresko8 → created an issue.

Fixed here: https://git.drupalcode.org/project/webform_timeout/-/commit/28a475d9d69d...

This fix has been out for some time but only in the dev version. Since it's solving D10 compatibility issues it would be nice to have it in an official release.

Are you talking about exporting the pipelines? I tested it and seems to be working fine in the beta2 version of the module. I added a new pipeline (the ones defined by the module are exported within the module so unless you allow conflicts to be added to your feature, you can not export those), exported successfully and tested updating and reverting as well. Found no issue.

+1 RTBC

Using multiple expanders per page on one of our sites.

Thanks for the patch Klausi!

Thanks for the suggestion! Fixed here https://git.drupalcode.org/sandbox/gresko8-3267405/-/commit/5a53b2425195...

gresko8 → created an issue.

I found out there were some warnings logged and setting breadcrumbs did not work correctly. Attaching a patch to fix that by making sure we are using the system path and not an alias in the background.

Attaching a re-roll of the patch along with a version combined with clean URLs patch.

Attaching a re-roll of the patch along with a possibility to disable this by setting a variable.

Attaching a patch.

gresko8 → created an issue.

For me this is happening after filtering the view with ajax facet when there are these obnoxious parameters in pager links.

Attaching a patch that is compatible with patch #29 in facetapi pretty paths compatibility issue:
https://www.drupal.org/project/ajax_facets/issues/2070427#comment-15429453 ✨ Support for Facet API Pretty Paths Needs review

One more fix to unset the pretty_path query param so it doesn't clutter up views links.

Attaching an updated patch which also includes search query in history.

Here is my initial attempt for 7.x-3.x patch. It might need some improvement in a sense that we could maybe get rid of some code execution when using the pretty paths but it seems to be working fine for me.

The patch deals with checkboxes and links compatibility with pretty paths. I didn't have time to work on select/ranges widgets.

I tested multiple options per facet and navigation through browser history as well.

I tested the patch on my site, but the operator was not updated. This was caused by my webform having nested elements and those were skipped by the update in the provided patch.
I'm attaching a patch which uses getElementsDecodedAndFlattened() method instead of getElementsDecoded() to fix this issue.

After this change I can confirm that it works as expected for me.

Created a new branch for D10 compatibility. Closing.

Created a new branch for D10 compatibility. Closing.

I'm attaching my attempt at porting a patch from commit mentioned in comment #4.

I tested the patch in #21 and it works well. Thanks!

The only thing that probably needs to be fixed is that we still have the checkboxes in field formatter settings. Since they are ignored because the actual settings stored on the entity are used, we should probably get rid of them.

Thanks for checking @klausi. Attaching updated patch.

Attaching a patch with an access callback (depends on the patch from the related issue: https://www.drupal.org/files/issues/2022-05-12/video_embed_field-remove-... → ).

gresko8 → created an issue.

We also encountered this issue on one of our sites. I opened a MR with a fix. Since jQuery doesn't seem to plan the fix anytime soon I think it makes sense to address this in Drupal core.

gresko8 → made their first commit to this issue’s fork.

Attaching a patch with added country option.

gresko8 → created an issue.

I tested the provided patch but it has a downside that it just takes the part following the last '/' so in case there is no hash it takes the video ID and passes it as the hash parameter. I'm attaching a patch with a different approach so the hash parameter is only set when it's present in the source URL.