- 🇺🇸United States Stoob
+1 and thank you for the wonderful #301 patch. Don't forget to turn backtrace in settings at admin/config/development/logging after patch applied
- last update
over 1 year ago 2,110 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,110 pass - last update
over 1 year ago 2,110 pass - last update
over 1 year ago 2,110 pass - last update
over 1 year ago 2,110 pass - last update
over 1 year ago 2,110 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,110 pass - last update
over 1 year ago 2,110 pass - last update
over 1 year ago 2,110 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,111 pass - last update
over 1 year ago 2,112 pass - last update
over 1 year ago 2,112 pass - last update
over 1 year ago 2,112 pass - last update
over 1 year ago 2,112 pass - last update
over 1 year ago 2,112 pass - last update
over 1 year ago 2,112 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,116 pass - last update
over 1 year ago 2,116 pass - last update
over 1 year ago 2,116 pass - last update
over 1 year ago 2,116 pass - last update
over 1 year ago 2,116 pass - last update
over 1 year ago 2,116 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,120 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago 2,120 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,121 pass - last update
over 1 year ago 2,122 pass - last update
over 1 year ago 2,121 pass, 1 fail - last update
over 1 year ago 2,122 pass - last update
over 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago run-tests.sh exception - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago run-tests.sh exception - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago run-tests.sh exception - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,122 pass - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,123 pass, 1 fail - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,124 pass - last update
about 1 year ago 2,127 pass - last update
about 1 year ago 2,127 pass - last update
about 1 year ago 2,127 pass - last update
about 1 year ago 2,127 pass - last update
about 1 year ago 2,127 pass - last update
about 1 year ago 2,127 pass - last update
about 1 year ago 2,127 pass - last update
about 1 year ago 2,127 pass - last update
about 1 year ago 2,127 pass - last update
12 months ago 2,126 pass, 1 fail - last update
12 months ago 2,127 pass - last update
12 months ago 2,127 pass - last update
12 months ago 2,126 pass, 1 fail - last update
12 months ago 2,127 pass - last update
12 months ago 2,127 pass - last update
12 months ago 2,127 pass - last update
12 months ago 2,127 pass - last update
12 months ago 2,127 pass - Status changed to Needs work
9 months ago 2:08pm 5 April 2024 - 🇫🇷France anrikun
Actually additions made in patch at #301 may cause crash below in theme_dblog_message() when the exception's class is not a standard one:
Object of class __PHP_Incomplete_Class could not be converted to string
As $error['exception'] is no longer used after getting its trace, I suggest we unset it then.
- Status changed to Needs review
9 months ago 2:23pm 5 April 2024 - last update
9 months ago 2,179 pass - 🇫🇷France anrikun
This new patch only adds:
unset($error['exception']);
<?php if (isset($error['exception'])) { $e = $error['exception']; unset($error['exception']); // HERE } else { $e = new Exception(); } ?>
- last update
9 months ago 2,179 pass - last update
9 months ago 2,179 pass - last update
9 months ago 2,140 pass - last update
9 months ago 2,179 pass - last update
9 months ago 2,179 pass - last update
9 months ago 2,179 pass - last update
9 months ago 2,175 pass - Status changed to Needs work
6 months ago 12:44pm 19 June 2024 - 🇫🇷France anrikun
Actually, even with my patch, some exceptions still cause what I described at #311.
I guess patch at #301 needs to be rethought to avoid this. - Status changed to Needs review
6 months ago 1:17pm 19 June 2024 - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
6 months ago Waiting for branch to pass - 🇫🇷France anrikun
This new patch seems to work in all cases :-)
The 'exception' attribute is now added in _drupal_exception_handler() and directly in _drupal_decode_exception().
- Status changed to Needs work
15 days ago 4:17pm 8 December 2024 - 🇮🇹Italy eliosh Bacoli
I'm sorry,
but it doesn't work anymore with version 7.103This is the file generated with the rejected code:
--- includes/errors.inc +++ includes/errors.inc @@ -257,7 +272,11 @@ function _drupal_log_error($error, $fatal = FALSE) { $class = 'status'; } - drupal_set_message(t('%type: !message in %function (line %line of %file).', $error), $class); + $message = '%type: !message in %function (line %line of %file).'; + if ($backtrace_options[ERROR_REPORTING_BACKTRACE_TO_SCREEN]) { + $message .= '<br /><pre>@backtrace</pre>'; + } + drupal_set_message(t($message, $error), $class); } if ($fatal) {
- 🇸🇰Slovakia gresko8
Accidentaly missed some chunks of code in my last patch. Attaching a new one.