- Issue created by @jsacksick
- Status changed to Needs review
over 1 year ago 5:55pm 31 May 2023 - 🇪🇸Spain aleix
I was working on it too, so despite there's a patch too, I am adding a new patch, It covers media hover preview too.
- 🇮🇱Israel jsacksick
oh! First tried the forEach approach and experienced issues, didn't realize the order of parameters changed there (index and item), my patch covered the preview too?
- 🇪🇸Spain aleix
I see now, sorry. I thought that it didn't cover the media hover_preview_media, but it does.
It's on maintainer's hands to choose.As contextual info for maintainer , here the cr: https://www.drupal.org/node/3158256 →
- 🇿🇦South Africa niki v
Trying to update this module as part of a local Commerce Kickstart install via composer and the patch keeps failing
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch →
I'm not sure whether this is related but my local install then has the following error
Error: Failed opening required 'C:\wamp64\www\kickstart\web/../vendor/autoload.php' (include_path='.;C:\php\pear') in C:\wamp64\www\kickstart\web\autoload.php on line 16
If this is actually a kickstart problem, I'll open an issue there but this is the only aspect of the entire scaffold update that fails consistently
- Status changed to RTBC
about 1 year ago 10:26am 16 August 2023 - 🇮🇳India keshavv India
Module already released to Drupal 10. But still
.once()
is not replaced.
Patch #3 works well to fixjQuery.once()
issue.
Please merge this patch so at least we can unblock this issue. -
Daniel.Moberly →
committed 66473186 on 8.x-1.x authored by
aleix →
Issue #3363948 by aleix: D10 compatibility issues
-
Daniel.Moberly →
committed 66473186 on 8.x-1.x authored by
aleix →
- Status changed to Fixed
about 1 year ago 5:31pm 16 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
7 months ago 3:02pm 15 April 2024 Run
```
composer create-project -s dev centarro/commerce-kickstart-project drupalcommerce
```have got this
```
- Applying patches for drupal/bootstrap_basic_image_gallery
https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch → (#3363948 - Fix D10 compatibility issues)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch →In Patches.php line 331:
Cannot apply patch #3363948 - Fix D10 compatibility issues ( https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch → )!
```
- 🇿🇦South Africa niki v
It's been a while since I solved his so I don't remember exactly how I did it but patch failures for me were a windows permission error or similar on WAMP server. If that applies to you, Google is your friend. If not WAMP, it's a composer issue
- 🇸🇰Slovakia gresko8
This fix has been out for some time but only in the dev version. Since it's solving D10 compatibility issues it would be nice to have it in an official release.