What branch should I use for Drupal 10?

Created on 3 April 2023, almost 2 years ago
Updated 2 May 2023, over 1 year ago

Branch 2.x: Development branch (DO NOT USE IN PRODUCTION YET!)
Branch 1.x: Don't support D10.
What branch should I use for Drupal 10?

πŸ’¬ Support request
Status

Fixed

Version

2.0

Component

Miscellaneous

Created by

πŸ‡·πŸ‡ΈSerbia super_romeo Belgrade

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @super_romeo
  • Assigned to Grevil
  • Status changed to Needs work almost 2 years ago
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Thanks @super_romeo, you're right, we have to update the module page description! 2.x is for Drupal 10, sorry

  • πŸ‡·πŸ‡ΈSerbia super_romeo Belgrade

    Thank you!

    But before reCAPTCHA issue not fixed Change CAPTCHA from ^1.4 to ^1.4 || ^2 in composer.json file ✨ Change CAPTCHA from ^1.4 to ^1.4 || ^2 in composer.json file Fixed there is conflict in composer if require branch 2.x.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    That's true, but we can't do anything about it. Please contact the recaptcha maintainers, if needed.

  • πŸ‡©πŸ‡ͺGermany Grevil

    @Anybody, back when we refactored and added quite a bit of code for captcha, we also wanted to change the module page description, but we did not have the permissions to change it, so we kept it. I think I also contacted @wundo about it, but I am not 100% sure.

    Anyway, I don't have the permissions to change it. Maybe you @Anybody? But I think not.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Yes I'm now able to change it. Sorry I thought you were also given that permission. I'll fix the text. Thanks @Grevil!

  • πŸ‡ΊπŸ‡ΈUnited States tjtj

    Captcha and recaptcha Drupal 10 requirements are not self-conststent.
    [~/www]# composer require 'drupal/captcha:^1.10'
    ./composer.json has been updated
    Running composer update drupal/captcha
    Loading composer repositories with package information
    Updating dependencies
    Your requirements could not be resolved to an installable set of packages.

    Problem 1
    - Root composer.json requires drupal/captcha ^1.10 -> satisfiable by drupal/captcha[1.10.0, 1.x-dev].
    - drupal/captcha[1.10.0, ..., 1.x-dev] require drupal/core ^8.9 || ^9 -> found drupal/core[8.9.0-beta1, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but the package is fixed to 10.0.7 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    Problem 2
    - drupal/captcha[1.10.0, ..., 1.x-dev] require drupal/core ^8.9 || ^9 -> found drupal/core[8.9.0-beta1, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but the package is fixed to 10.0.7 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - drupal/recaptcha 3.1.0 requires drupal/captcha ^1.4 -> satisfiable by drupal/captcha[1.10.0, 1.x-dev].
    - drupal/recaptcha is locked to version 3.1.0 and an update of this package was not requested.

    Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

    Installation failed, reverting ./composer.json and ./composer.lock to their original content.

  • Issue was unassigned.
  • Status changed to Fixed almost 2 years ago
  • πŸ‡©πŸ‡ͺGermany Grevil

    Captcha 2.x is currently in a beta state. Try running "composer require drupal/captcha:^2" and make sure you have "minimum-stability" set to "beta".

  • πŸ‡ΊπŸ‡ΈUnited States bcobin

    I'm in latest Drupal 10 and site reports incompatible CAPTCHA, but there's no upgrade path. What's the procedure here? Should CAPTCHA 8.x be uninstalled first? I also don't recall seeing a "minimum-stability" option.

    Please advise - thanks!

  • πŸ‡ΊπŸ‡ΈUnited States tjtj

    I have minimum-stability set to dev, and still get
    /www]# composer require drupal/captcha:^2
    ./composer.json has been updated
    Running composer update drupal/captcha
    Loading composer repositories with package information
    Updating dependencies
    Your requirements could not be resolved to an installable set of packages.

    Problem 1
    - Root composer.json requires drupal/captcha ^2, found drupal/captcha[dev-2.x, 2.0.0-alpha0, 2.0.0-beta1, 2.x-dev] but these were not loaded, likely because it conflicts with another require.
    Problem 2
    - drupal/recaptcha is locked to version 3.1.0 and an update of this package was not requested.
    - drupal/recaptcha 3.1.0 requires drupal/captcha ^1.4 -> found drupal/captcha[dev-1.x, 1.4.0, ..., 1.x-dev (alias of dev-1.x)] but it conflicts with your root composer.json require (^2).

    [~/www]# composer prohibits drupal/captcha "^2"
    Info from https://repo.packagist.org: #StandWithUkraine
    drupal/recommended-project - requires drupal/captcha (^1.8)
    drupal/recaptcha 3.1.0 requires drupal/captcha (^1.4)

    Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

    Installation failed, reverting ./composer.json and ./composer.lock to their original content.

  • πŸ‡ΊπŸ‡ΈUnited States bcobin

    Why is this marked as "fixed?" If so, what's the solution? I'm now delaying a deploy of a D10 site until this is resolved, so any guidance is much appreciated! Thanks...

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    @bcobin: It's not an issue with CAPTCHA but with recaptcha.

    See your lines:
    - drupal/recaptcha 3.1.0 requires drupal/captcha ^1.4 -> found drupal/captcha[dev-1.x, 1.4.0, ..., 1.x-dev (alias of dev-1.x)] but it conflicts with your root composer.json require (^2).

    and the issue linked above from recaptcha:
    ✨ Change CAPTCHA from ^1.4 to ^1.4 || ^2 in composer.json file Fixed

  • πŸ‡ΊπŸ‡ΈUnited States bcobin

    Thanks for the quick response, @anybody. I upgraded reCaptcha and site still reports the below. This is only after core upgrade to 10.0.7.

    There is no upgrade path from 8.x-1.9 and 8.x-1.10 is not Drupal 10 compatible. So back to my original question: what to do here? Thanks...

    ------

    Update Page

    Not compatible
    Name Installed version Recommended version
    CAPTCHA 8.x-1.9 8.x-1.10 (Release notes)
    Requires Drupal core:

  • Question: Why is 8.x-1.10 not compatible with D10 but 8.x-1.9 was. I'm waiting on a few other modules to update their requirements and stuck on 8.x-1.9 for Drupal 10.

  • πŸ‡©πŸ‡ͺGermany Grevil

    @catapipper, see release notes of 8.x-1.10: https://www.drupal.org/project/captcha/releases β†’

    >Removed unwanted Drupal 10 compatibility from 8.x-1.x πŸ› Image not shown, PHP error Closed: duplicate

  • πŸ‡©πŸ‡ͺGermany Grevil

    But as already said, 2.x IS Drupal 10 ready.

  • Oh I completely missed that, lol. Thanks for setting me straight. Now to wait for Webform to update, allowing 2.x. Issue already added over there.

  • πŸ‡©πŸ‡ͺGermany Grevil

    Glad I could help!

  • πŸ‡ΊπŸ‡ΈUnited States komlenic

    I'm struggling to understand something and may be missing the obvious, but:

    If the 2.0 branch of this module is D10 only, and the previous 8.x-1.x version is D8 and D9 only.... how is someone supposed to update this project *prior* to, and in preparation for, updating core to D10? Most other modules are creating branches/releases that support *both* D9 and D10, no?

  • πŸ‡§πŸ‡ͺBelgium ericvl

    @komienic

    You are right. Therefor, I never updated to version 1.10 and stayed at 1.09 because this version was drupal 9 and 10 compatible. I then moved to te 2.0 version with "composer require drupal/captha..." and not "composer update...".
    My opion then was that the 1.10 version was rather a downgrade than an upgrade because they removed the D10 compatibility. This was IMHO not a good solution for another bug. The bug should have been resolved and not by removing the compatibility.
    So you should do the jump from 1.09 to 2.x.

  • πŸ‡©πŸ‡ͺGermany Grevil

    @EricVL, @komlenic, the Symfony version changed in Drupal 10, which implemented return type hinting for a bunch of symfony methods. Because our overwritten method did not implement type hinting, the error occurred.

    To make sure the module was still Drupal 8.9 compatible, we could NOT simply add the return type hint, as the minimal Drupal 8.9 PHP version is PHP 7.3, which does NOT support return type hinting.

    So the question was, to either drop the Drupal 8.9 support or drop the Drupal 10 support. And as we already have a D10 ONLY version with 2.x, the answer was simple.

    Not a "bug" we could have simply fixed.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    @EricVL: BTW this is open source and there are many things to improve im CAPTCHA for sure! Simply invest money or time to help, it's for your own benefit ;)

  • πŸ‡§πŸ‡ͺBelgium ericvl

    @Grevil
    Thank you very much for the clear explanation why the 1.10 doesn't support D10 anymore.
    This was a logical move to do but I understand the issue from @komlenic too.
    @Anybody
    I know this is open source and everybody is glad to use it.
    I spend allready a lot of time to help people and make things easier for everyone.
    My comment was not ment to blame someone. I do apologize if you thought so.
    Greetings

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024