- Issue created by @mrshowerman
- π©πͺGermany mrshowerman Munich
Note that the webform handler only works after applying the patch from π Webform Handler does not work RTBC first.
- Issue was unassigned.
- Status changed to Needs review
9 months ago 1:53pm 1 March 2024 - π©πͺGermany mrshowerman Munich
To avoid merge conflicts when including both this patch and the one from π Webform Handler does not work RTBC , I also included the fix from there.
- π³π΅Nepal sujan shrestha Nepalπ³π΅, Kathmandu
Thanks @mrshowerman, I'll review it.
- π©πͺGermany Schoenef Unna
Hello, are there any news on this one? We would like to have this feature as well.
Thx a lot everybody!
- π©πͺGermany Schoenef Unna
Hi @mrshowman, is there a way I can tryout your fork? We need this feature for a client as well,
Thx a lot!
Andreas - π©πͺGermany mrshowerman Munich
Sure, you can apply the MR as a composer patch.
Download the MR's patch file to your local project using the "plain diff" above and follow the instructions in https://www.drupal.org/docs/develop/using-composer/manage-dependencies#p... β - π©πͺGermany Schoenef Unna
Thank you! I did not see the plain diff link.
It applies very well by adding
"patches": { "drupal/sendinblue_api": { "#3424946_doi": "https://git.drupalcode.org/project/sendinblue_api/-/merge_requests/2.diff" } },
to the composer.json file.
- π©πͺGermany mrshowerman Munich
Glad it works!
But you should never use a direct URL to an MR's diff file, because that could change with future updates, and you never know if you really want those changes in your project.
Instead, download the file to your project and reference it locally:"patches": { "drupal/sendinblue_api": { "#3424946_doi": "patches/sendinblue_api/3424946.diff" } },
- Status changed to RTBC
4 months ago 12:57pm 11 July 2024 - π©πͺGermany Schoenef Unna
So from the functional point of view, this works very well - I have just installed and tested it.
Codewise it is also fine from my point of view.