PHP message: Error: Call to a member function getEntityTypeId() on null (Layout Builder)

The patch in #60 works for me on Drupal 9.5.5

Updated patch to move this forward. moved deprecation to 10 as the latest release this would go in. Updated deprecation to match standard format. Needs Change Record to link to in the deprecation.

I don't know how to address the logging concern in #75 to update the issue summary. Why wouldn't you log the an error? Without logging something it would be one of those unknoweable unfixable errors right?

Here's a small adjustment to #60 to allows admins to see the broken blocks, instead of suppressing the error "This block is broken or missing..."

Attaching patch and interdiff

Having this error on Layout builder of an entity in my case the taxonomy term page in Core 10.0.10, so this patch is against 10.0.10

I like the approach in #82. Show the error that blocks are missing to those that have access.

Re-role for the patch from #82 to apply for Drupal 10.2.1

The issue is in
@trigger_error('The logger service must be passed to InlineBlock::__construct(). It was added in drupal:9.4.0 and will be required before drupal:11.0.0.', E_USER_DEPRECATED);

as it is not in correct format.
%thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
https://www.drupal.org/about/core/policies/core-change-policies/drupal-deprecation-policy →

Attempt tp fix PHPSTAN.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

carolpettirossi → changed the visibility of the branch 3049332-call-to-a-member-function-getEntityTypeId()-on-null to hidden.

I created an MR with code from patch #87 as recommended by the "needs-review-queue-bot"

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Still getting the PHPCS error on trigger_error. However, I'm wondering if that trigger_error is needed. Is there an intention to make $logger required in a future Drupal version? If yes, do we need a Change Record to link to?

Correct yeah we would need a CR to be made for this as the logger is now required by InlineBlock

In my opininon, the trigger_error message should be formatted like existing examples. This example also includes a CR → that could be used as a starting point.

I've updated the message and created... 🥁 my first ever change record → (please be gentle).

Thanks to @DanielVeza for the helpful example. I tried to follow that model, although I couldn't find any good examples of the constructor being called. I instead opted to use [#3436810] as an example of a constructor change. I'm very much open to suggestions for better examples there.

Test failures seem to be unrelated:

    There was 1 failure:
    
    1)    Drupal\Tests\Composer\Plugin\Scaffold\Functional\ManageGitIgnoreTest::testUnmanagedGitIgnoreWhenGitNotAvailable

Hiding patches for clarity.

Left some comments on the MR.

Leaving issue summary tag if that could be cleaned up please. Proposed solution seems like a question and there are some TBD spots. If there aren't, for example, UI changes it's fine to just N/A there.

Thanks for the feedback @smustgrave. I've resolved the MR comments and taken a pass at updating the issue summary.

Thanks MR appears to have phpcs errors

I've satisfied phpcs, but it looks like Drupal\Tests\Composer\Plugin\Scaffold\Functional\ManageGitIgnoreTest is still failing.

Would recommend rebasing the branch.

Sorry... took a couple tries but I successfully rebased and tests are now passing.

Believe feedback has been addressed

This needs a title update so it makes sense in the git log.

Done.

I've asked a couple of questions on the MR.

Carlos Romero → made their first commit to this issue’s fork.

Carlos Romero → closed merge request !8352

Carlos Romero → reopened merge request !8352

Carlos Romero → closed merge request !8350

Carlos Romero → closed merge request !8352

Nothing changed, just a re-roll against Drupal 10.3.0 to ease the update for installations that require the patch.

Added issue #2942975 📌 [PP-1] Expose Layout Builder data to REST and JSON:API Postponed as related because its impossible to use this patch and patch from that issue at the same time.

Adding issue https://www.drupal.org/project/drupal/issues/3180702 ✨ Export block UUID with custom Layout Builder blocks Needs work as related, because we also can't use both patches at the same time.

Just got the same error, patch #118 fixes the issue for us.

for my case patch #118 isnt applied completaly, so i created another patch which is working fine for me.

In previous patch, the test file was missing, so adding correct one.

@rajveergangwar could you please fix PHP 8.4 deprecation warning in the latest patch?

Deprecated: Drupal\layout_builder\Plugin\Block\InlineBlock::__construct(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/core/modules/layout_builder/src/Plugin/Block/InlineBlock.php