🇸🇮Slovenia @alecsmrekar

alecsmrekar → created an issue.

Looks great and makes sense, thanks!

Looks great!

Works well, thanks!

Works well, thanks!

None of these seem directly related to PHP 8.4, everything seems to be working regardless of these phpstan warnings

alecsmrekar → created an issue.

alecsmrekar → created an issue.

alecsmrekar → created an issue.

alecsmrekar → created an issue.

Released as part of alpha8

alecsmrekar → made their first commit to this issue’s fork.

amateescu → credited alecsmrekar → .

alecsmrekar → created an issue.

alecsmrekar → created an issue.

alecsmrekar → created an issue.

alecsmrekar → created an issue.

@catch I think that all feedback has been addressed. Which comment are you referring to exactly?

Thanks, merged and tagged alpha5.

alecsmrekar → created an issue.

Looks good to me!

alecsmrekar → made their first commit to this issue’s fork.

Do you mean there are a total of three aliases after step 4, or is it two aliases?

A total of 3

alecsmrekar → created an issue.

alecsmrekar → created an issue.

alecsmrekar → created an issue.

alecsmrekar → created an issue.

alecsmrekar → made their first commit to this issue’s fork.

alecsmrekar → created an issue.

Test steps for the MR:

1. drush si -y
2. drush en -y content_translation trash
3. Go to /admin/config/regional/language and add Spanish as a new language
4. Go to /admin/config/regional/content-language and enable translation for Article nodes
5. Add a new Article
6. Add a Spanish translation
7. Go to /es/node/1/delete, and ensure you can't submit the form. There should be a message saying "Moving translations to the trash bin is currently not supported. Unpublish the translation instead.".

alecsmrekar → created an issue.

Thanks, this looks good to me!

Looks good to me as well!

Looks great, thank you!

Test failure does not seem related:
Drupal\Tests\comment\Functional\CommentPreviewTest 0 passes 94s 1 fails

alecsmrekar → created an issue. See original summary → .

The test fail does not seem related to this:
Drupal\Tests\image\Functional\ImageStylesPathAndUrlTest 0 passes 84s 1 fails

I opened a merge request that addresses this with a new approach. Simply, if a menu link is not translatable, the code should not be setting a language on the menu link entity.

Here are some test step that fail without the fix applied:
1. drush si
2. drush en -y workspaces content_translation
3. drush uli
4. Go to /admin/config/regional/language and add the Spanish language
5. Go to /admin/config/regional/content-language and enable translation for "Content", ensure to check "Article" under the "Content" fieldset
6. Switch to the Stage workspace
7. Create a new Article, check "Provide a menu link" and save
8. Go to /es/node/{}/translations and add a Spanish translation
9. Note the revision ID: drush sqlq "select MAX(revision_id) from menu_link_content_field_revision"
10. Run drush php:eval 'echo \Drupal::entityTypeManager()->getStorage("menu_link_content")->loadRevision(REVISION_ID)->getMenuName()'

Notice that without the fix, the menu name comes blank, but with the fix, it prints the menu name.

alecsmrekar → made their first commit to this issue’s fork.

Thanks, I tested this and it works as expected, no errors :)

alecsmrekar → created an issue.

I think I addressed all the feedback, but there seems to be something wrong with composer in the test pipeline.

alecsmrekar → created an issue.

alecsmrekar → created an issue.

Updated!

Opened a PR, and it seems the pipeline failure is not related to the changes made here.

Thanks Andrei, I pushed another commit enabling validation on the path.

alecsmrekar → created an issue. See original summary → .