- 🇷🇴Romania amateescu
The modern replacement for
drupal_static()
use-cases is a request attribute :) - Merge request !60Add a way to skip geocoding using runtime parameters. → (Merged) created by amateescu
- 🇷🇴Romania amateescu
Pushed a commit that uses the new request attribute during workspace publishing.
The MR looks good to me. One consideration here: As the presave hook is so expensive, it may be worth triggering a hook/an event that allows other modules to react when the hook is fired to skip further execution?
- First commit to issue fork.
- 🇮🇹Italy itamair
Thanks for al this, but I had some difficulties to understand that and how the attached #2 patch and the MR !60 are going to solve kind of same goal but in two parallels contexts of Migrations and Workspace publishing.
It looks most of the folks here do belong to TAG1 and perfectly know what they are debating about and accomplishing (as the Workspace module logics) but it would also help some better description that is going to be implemented here.
I kind of did it ... digging in the the MR !60, and its dependencies,
BUT it would be hard for a normal contributor to understand what is going here, also because the Workspace module is still missing basis documentation and help content (isn't it?).So I feel to forward the following requests:
- could you proper provide some better extended description of what is being achieved here, at once on both Migration and Workspace sides, and mostly ...
- could you properly let me know if both the #2 patch and the MR !60 should be deployed in parallel (as RTBC) or even better could / should everything (from the #2 patch) be grouped / embedded in the MR !60 itself, if opportune?Thanks!
-
itamair →
committed 69986883 on 8.x-4.x authored by
amateescu →
Issue #3301512 by amateescu, itamair, kiseleva.t, s_leu, alecsmrekar,...
-
itamair →
committed 69986883 on 8.x-4.x authored by
amateescu →
- 🇮🇹Italy itamair
Ok I better inspected all this and all makes great sense to me also.
I just added a commit on better commenting.
Going to deploy this into new incoming 8.x-4.26 Geocoder release. Automatically closed - issue fixed for 2 weeks with no activity.