Use decoration instead of overriding the service definition

Created on 24 September 2024, 3 months ago

Problem/Motivation

The definitions of the http_middleware.page_cache service is overriden, setting the custom service class AdvancedPageCache.php. This causes this module to not play well with other modules that alter page cache, like page_cache_query_ignore for example.

Steps to reproduce

Proposed resolution

The solution is to use service decoration, this way all the module that wish to alter how page cache works can do so in a layered way.

Remaining tasks

Post a MR.

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

🇸🇮Slovenia alecsmrekar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024