- Issue created by @ajits
- Merge request !124Issue #3489001: Add passthrough query setting per redirect → (Open) created by ajits
- 🇮🇳India ajits India
Let's see how the tests fare. Also, this will need some tests.
- 🇮🇳India ajits India
Addressed feedback and adjusted tests. This is ready for review.
- 🇮🇳India ajits India
I received feedback from Alec → about the changing behavior of the public function
findMatchingRedirect
in theredirect.repository
service. I have adjusted the code to preserve the current functionality; and adjusted to the newly provided field. Also, adjusted the tests to be more detailed. - Issue was unassigned.
- Status changed to Needs review
9 days ago 12:44am 3 April 2025 - 🇮🇳India ajits India
@berdir - thank you for your review! I have incorporated it. Found another issue:
1. Global query pass through setting is disabled.
2. Create a redirect from/body.foo?id=123
to/bar
3. Create a redirect from/bar
to/baz
Visiting
/body.foo?id=123
did not redirect as expected. This was also fixed. - 🇮🇹Italy plach Venezia
This is working well in a project of ours, tentatively marking RTBC :)