🇮🇳India @ajits

@berdir - thank you for your review! I have incorporated it. Found another issue:

1. Global query pass through setting is disabled.
2. Create a redirect from /body.foo?id=123 to /bar
3. Create a redirect from /bar to /baz

Visiting /body.foo?id=123 did not redirect as expected. This was also fixed.

> implement a hook_form_alter that covers both entity_workflow_form and entity_workflow_simple_transition_form

Done

> in that form alter, build and render the workspace publish form (directly for entity_workflow_simple_transition_form, using #states for entity_workflow_form)

This was not possible because the EntityWorkflowSimpleTransitionForm form uses routeMatch to check for the workspace transition; and the transition is not available (on load) for EntityWorkflowForm.

I have checked for other details and the MR should cover it. Please review.

@amateescu - Thank you! Moving this to the entity_workflow module.

I have pushed the code to hook_deploy_NAME instead. Please let me know if I should remove the Drush command.

@amateescu - I tried to move the logic to hook_install as you suggested; however, I still get the error that pushed to me to write the command in the first place:

Field entity_workflow_workspace is unknown.

Created a MR. Please review.

ajits → created an issue.

I started adding the support for trash to taxonomy. I have created an MR that enables trashing the terms. However, there is a challenge with the term hierarchy, as mentioned in the previous comments.

Any term being trashed resets its parent to root by design. See <a href="https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/taxonomy/src/Entity/Term.php?ref_type=heads#L137">Term::preSave</a>.

I had a chat with @amateescu, and we concluded that any other temporary storage like key/value will not be compatible with the core workspaces module. This data needs to stay with the term itself. Something like @khaled.zaidan mentioned above. I like the idea of saving the immediate child terms for the current term. Maybe in an implementation of hook_pre_trash_delete for taxonomy terms?

ajits → made their first commit to this issue’s fork.

surabhi-gokte → credited ajits → .

surabhi-gokte → credited ajits → .

Created a drush command. The hooks hook_install and hook_modules_installed did not work. They seem to be executed very early.

ajits → created an issue.

Created a PR as we're moving away from d.o issues. See - 📌 Migrate drupal.org issues to gitlab issues Needs review

Addressed the comments. This is ready for another review.

Moved to config :)

It made more sense for this to be configurable via the core Drupal\Core\Site\Settings instead of actual configuration.

ajits → created an issue.

I received feedback from Alec → about the changing behavior of the public function findMatchingRedirect in the redirect.repository service. I have adjusted the code to preserve the current functionality; and adjusted to the newly provided field. Also, adjusted the tests to be more detailed.

Addressed feedback and adjusted tests. This is ready for review.

Turns out this was because of an outdated core patch https://www.drupal.org/project/drupal/issues/3202896#comment-15053954 🐛 Don't display OEmbed error to anonymous visitors when resource stops being available Needs work ¯\_(ツ)_/¯
Closing this!

I am working on this.

ajits → created an issue. See original summary → .

Let's see how the tests fare. Also, this will need some tests.

I am working on creating a MR.

ajits → created an issue. See original summary → .

alexpott → credited ajits → .

Would it make sense to make it configurable?

Marking this as fixed.

Marking this as fixed.

ajits → created an issue. See original summary → .

ajits → created an issue. See original summary → .

ajits → created an issue. See original summary → .

ajits → created an issue. See original summary → .

ajits → created an issue.

ajits → created an issue. See original summary → .

ajits → created an issue. See original summary → .

ajits → created an issue. See original summary → .

ajits → created an issue.

ajits → created an issue.

Added a check in a non-dependency-injection way, as the module is not directly dependent on the workspaces module.

I am working on a PR.

ajits → created an issue.

breidert → credited ajits → .

Adjusted title.

Correct component.

Thank you, @amateescu!
Moving the core with IS update.

ajits → created an issue.

Thank you for your review! I have adjusted the help text. I have also made the change so that the redirect target also supports the query string.

The target also needs to support the escaped `?`

Removed unused variable.

Created a PR that should fix this. Also, adjusted the title.

Also, I am working on this.

ajits → created an issue. See original summary → .

This is ready for review. The validation of the entered target path is not done by the setRegexErrors function; which feels deliberate.

I am not sure about the category. This doesn't qualify for the support request, as a bug, or a feature. Marking it as a "task". I hope that is okay.

Adding some profiling details below.

Before the fix:

After the fix:

I am working on this.

ajits → created an issue.

Thank you for the patch! Committed.

Thank you for the patch! Works fine. Committed to 2.0.x

Checking.

Merged and added Drupal 11 compatibility. Thank you!

AjitS → made their first commit to this issue’s fork.

Fixed.

AjitS → made their first commit to this issue’s fork.

Merged. Thank you for your contribution!

I am working on this.

AjitS → made their first commit to this issue’s fork.

rahul.shinde → credited AjitS → .