- First commit to issue fork.
- Assigned to ajits
- Merge request !12Issue #3051664: Allow the GUI of regex_redirect to support targets without a pattern. → (Open) created by ajits
- Issue was unassigned.
- Status changed to Needs review
4 months ago 2:09pm 27 August 2024 - 🇮🇳India ajits India
This is ready for review. The validation of the entered target path is not done by the
setRegexErrors
function; which feels deliberate. - Status changed to Needs work
4 months ago 1:09pm 2 September 2024 - 🇸🇮Slovenia paranojik
Seems to be working as expected. I'm not sure if a setting for this functionality is actually needed @LaravZ.
@ajits: You did leave an unused variable in there, though
diff --git a/src/Form/RegexRedirectForm.php b/src/Form/RegexRedirectForm.php index a39041c..fdeb385 100644 --- a/src/Form/RegexRedirectForm.php +++ b/src/Form/RegexRedirectForm.php @@ -217,7 +217,6 @@ class RegexRedirectForm extends ContentEntityForm { // Set the regex delimiter in code to avoid issues with leading slash. $delimiter = '/'; $source_regex = $delimiter . trim($source_path) . $delimiter; - $redirect_regex = str_replace('internal:', '', $redirect_uri); if (preg_match($source_regex, '') === FALSE) { $form_state->setErrorByName('regex_redirect_source', $this->t('The regex redirect source must be a regex pattern.'));
- Status changed to Needs review
4 months ago 4:01pm 3 September 2024 - Status changed to RTBC
3 months ago 1:08pm 5 September 2024