🇸🇮Slovenia @paranojik

Proposed solution implemented and ready for review.

paranojik → changed the visibility of the branch 3485818-rebuild-workspace-menu to hidden.

paranojik → created an issue.

Fixed the nit @plach. Thanks!

paranojik → created an issue.

I think this is a very good enhancement. Thanks @ajits!
Marking RTBC.

Looks good now.
Thanks @ajits.

Marking RTBC.

paranojik → created an issue.

Seems to work fine, however the redirect source field help text seems to be inaccurate.
Enter an internal url regex path with named captures. For example: page\/old\/(?P<nr>[0-9a-z]+). Please be aware that certain characters such as "$", or "?" need to be escaped due to it being part of a replacement string.
The special characters are to be escaped because they're part of the regular expression used for matching not because they're part of a replacement string.

Seems to be working as expected. I'm not sure if a setting for this functionality is actually needed @LaravZ.

@ajits: You did leave an unused variable in there, though

diff --git a/src/Form/RegexRedirectForm.php b/src/Form/RegexRedirectForm.php
index a39041c..fdeb385 100644
--- a/src/Form/RegexRedirectForm.php
+++ b/src/Form/RegexRedirectForm.php
@@ -217,7 +217,6 @@ class RegexRedirectForm extends ContentEntityForm {
     // Set the regex delimiter in code to avoid issues with leading slash.
     $delimiter = '/';
     $source_regex = $delimiter . trim($source_path) . $delimiter;
-    $redirect_regex = str_replace('internal:', '', $redirect_uri);
 
     if (preg_match($source_regex, '') === FALSE) {
       $form_state->setErrorByName('regex_redirect_source', $this->t('The regex redirect source must be a regex pattern.'));

paranojik → created an issue.

paranojik → made their first commit to this issue’s fork.

paranojik → made their first commit to this issue’s fork.