- Merge request !8Compare routes using the route name instead of the generated path. → (Open) created by nick dewitte
- 🇨🇦Canada floydm
+1 on confirming this fixes an infinite redirect on sites with language prefixes. Please roll this into a release soon.
- Status changed to Needs work
7 months ago 9:27am 30 September 2024 - 🇷🇴Romania amateescu
Added a comment on the MR, checking the user's edit form in the MR doesn't match the previous logic completely.
- 🇷🇴Romania amateescu
I forgot to mention that the current way of generating the paths to check is effectively disabling core's alias pre-loading mechanism for any site that has this module installed. See #2508217-14: AliasManager should use the current route match for outbound alias pre-loading cache keys → for details.
- 🇷🇴Romania amateescu
Also worth noting that the current code was introduced in #3108636: Infinite redirect loop when used in combination with drupal/rename_admin_paths →
- First commit to issue fork.
- First commit to issue fork.
s_leu → changed the visibility of the branch 3280541_3356565_combined to hidden.
I reverted the changes in the MR to back to compare the excluded urls by path but without using the
path.currentservice and instead getting the path via request stack, as that will contain the language path prefix and will thus solve the initial problem of this issue and the problem mentioned in #12 🐛 Generated URL language prefix mismatch causes infinite redirect loop RTBC and in #10 🐛 Generated URL language prefix mismatch causes infinite redirect loop RTBC too- First commit to issue fork.