- Issue created by @venkatadapa
- Status changed to RTBC
over 1 year ago 4:38pm 29 December 2023 - 🇮🇳India shashank5563 New Delhi
@venkatadapa, Thank you, I have tested this on my project and found it is working as expected.
I am moving it for RTBC.
- Status changed to Needs work
over 1 year ago 11:02pm 29 December 2023 This patch has not been tested.
Is this something that should be fixed in the contributed module?
There must be missing tests of this is a core bug, and a regression.
- last update
over 1 year ago 25,779 pass, 1,838 fail - last update
over 1 year ago 25,767 pass, 1,820 fail - last update
over 1 year ago 25,800 pass, 1,795 fail - 🇺🇸United States banoodle San Francisco, CA
I upgraded to Drupal 10.2.2 and I also can no longer add links to Group menus.
Patch #2 fixes the issue for me, but I have created this task in the Group Content Menu → issue queue to get visibility with the maintainers of that module: https://www.drupal.org/project/group_content_menu/issues/3417879 🐛 Can't create group menu link after upgrade to 10.2.2 - Error: Call to a member function label() on null Closed: duplicate
In the meantime, I'm going to have to use the patch on this issue - so thanks!
- Issue was unassigned.
- heddn Nicaragua
Traced this back to 🐛 When adding a new menu link, restrict the available parents to the current menu Fixed . It isn't in 10.1 but is in 10.2. GCM does not have a full config backed menu. It never will. Additionally, the menu parent logic is overwritten by that module after this here. The patch in #2 seems like a decent solution. An entity load can fail to load (that's what we see here). We should check and handle appropriately.
Still needs tests, but this can be easily reproduced. In a test controller add something like:
public function addLink(GroupContentMenuInterface $group_content_menu) { $menu_name = 'non-existent'; $menu_link = $this->entityTypeManager()->getStorage('menu_link_content')->create([ 'menu_name' => $menu_name, 'bundle' => 'menu_link_content', ]); return $this->entityFormBuilder()->getForm($menu_link); }
- 🇨🇦Canada karimb
Just to mention that I applied the patch #2 and it works for me! Thanks.
- First commit to issue fork.
- First commit to issue fork.
- Merge request !7228Issue 3411384: Fix form for links with invalid menu names → (Open) created by alecsmrekar
- Status changed to Needs review
about 1 year ago 12:47pm 28 March 2024 - First commit to issue fork.
- Status changed to RTBC
about 1 year ago 2:39pm 28 March 2024 - 🇮🇹Italy plach Venezia
Looks good and works well here, I pushed a small commit to address @graber's review.
I only changed a word in a comment, so I think it's fine for me to RTBC this :)
- Status changed to Needs work
about 1 year ago 11:58am 29 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Made some comments on the MR with a suggested change.
- Status changed to Needs review
about 1 year ago 12:58pm 29 March 2024 - Status changed to RTBC
about 1 year ago 3:57pm 30 March 2024 - 🇺🇸United States smustgrave
Appears suggestions by @alexpott has been addressed.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 84432de226 to 11.x and cf919c8960 to 10.3.x and 22add58ea6 to 10.2.x. Thanks!
-
alexpott →
committed 22add58e on 10.2.x
Issue #3411384 by phthlaap, venkatadapa, alecsmrekar, plach, alexpott,...
-
alexpott →
committed 22add58e on 10.2.x
-
alexpott →
committed cf919c89 on 10.3.x
Issue #3411384 by phthlaap, venkatadapa, alecsmrekar, plach, alexpott,...
-
alexpott →
committed cf919c89 on 10.3.x
- Status changed to Fixed
about 1 year ago 5:04pm 30 March 2024 -
alexpott →
committed 84432de2 on 11.x
Issue #3411384 by phthlaap, venkatadapa, alecsmrekar, plach, alexpott,...
-
alexpott →
committed 84432de2 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.