🇮🇳India @shashank5563

shashank5563 → created an issue.

I am getting the following error:
TypeError: Unsupported operand types: string + int in Drupal\office_hours\OfficeHoursDateHelper::format() (line 158 of /modules/contrib/office_hours/src/OfficeHoursDateHelper.php).

1. How reproduce the issue.

1. Please see the screenshot and put the value same way.

1. Then click on save button.

@shabana.navas, Please raise a MR for it.

@malcomio, 8.x-3.0-alpha16 version has beed released.

@naveenvalecha, I have tested with Group 3.x module, and found it is working as expected.
Please raised the released version of 3.0.x.

Thanks

@bramtenhove, I am ready make it fully compatible with Group 3.x.
Because, I have done it one of my project today and it is working as expected.

Please give me permission to update the module.

@duckydan, you can get it from chargebee. but it is not required. you just need api key from chargebee.

@venkatadapa, Thank you, I have tested this on my project and found it is working as expected.

I am moving it for RTBC.

@malcomlo, Your MR is merged in 8.x-3.x-dev branch.

@msnassar, Thank you for your support.

I want to pass parent group id if group have parent. I want plugin with group content menu block like this screenshot.

<?php

declare(strict_types = 1);

namespace Drupal\mymodule\Plugin\GroupFinder;

use Drupal\Core\Routing\RouteMatchInterface;
use Drupal\group\Entity\GroupInterface;
use Drupal\group_finder\GroupFinderBase;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\RequestStack;

/**
 * Plugin finds group from media library opener.
 *
 * @GroupFinder(
 *   id = "group_content",
 *   label = @Translation("Media library opener"),
 *   description = @Translation("When in context of media library opener."),
 *   weight = 40,
 * )
 */
class GroupContent extends GroupFinderBase {

  /**
   * The group entity.
   *
   * @var \Drupal\group\Entity\GroupInterface
   */
  protected $group;

  /**
   * The request stack.
   *
   * @var \Symfony\Component\HttpFoundation\RequestStack
   */
  protected $requestStack;

  /**
   * GroupContent constructor.
   *
   * @param array $configuration
   *   Plugin configuration.
   * @param string $plugin_id
   *   Plugin id.
   * @param mixed $plugin_definition
   *   Plugin definition.
   * @param \Drupal\Core\Routing\RouteMatchInterface $route_match
   *   The current route match.
   * @param \Symfony\Component\HttpFoundation\RequestStack $request_stack
   *   The request stack used to retrieve the current request.
   */
  public function __construct(array $configuration, $plugin_id, $plugin_definition, RouteMatchInterface $route_match, RequestStack $request_stack) {
    parent::__construct($configuration, $plugin_id, $plugin_definition, $route_match);
    $this->requestStack = $request_stack;
  }

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition): self {
    return new static(
      $configuration,
      $plugin_id,
      $plugin_definition,
      $container->get('current_route_match'),
      $container->get('request_stack'),
    );
  }

  /**
   * {@inheritdoc}
   */
  public function isApplicable(): bool {

    die('ddd');
    return FALSE;
  }

  /**
   * {@inheritdoc}
   */
  public function getGroup(): ?GroupInterface {
    return $this->group ?? NULL;
  }

}

shashank5563 → created an issue.

@shalini_jha, Please create a patch for it.

shashank5563 → created an issue.

I have created a patch as well.

I have create a patch and tested on my system. it is working fine.

shashank5563 → created an issue.

@bramtenhove, I am ready make it fully Drupal 10 compatible.
Because, I have done it one of my project today and it is working as expcted.

@here, Development version is available. Please test and review.

Now, it is supporting 4.x module.

Hello,

I see this module seeking co-maintainers. I would like to become a co-maintainer of the module to update a codebase, prepare it for Drupal 10 and implement new features mentioned in the issue queue.

Thanks,
shashank

shashank5563 → created an issue.

shashank5563 → created an issue.

I have created a MR and tested it is working as expected. Also, I have updated the method title with respective field name.

Please merge the MR.

shashank5563 → made their first commit to this issue’s fork.

@bhanutejaswi, I have fixed this issue. Please see the patch. Also this code is available in the 8.x-3.x-dev branch.

@arti, we are using the request_stack.

@malcomio, I have fixed this issue. Please see the patch. Also this code is available in the 8.x-3.x-dev branch.

@Shiv_Sharma, Please update the description. I don't see the problem reported by PHPCS.

#2 patch applied and found working as expected.

@Shiv_Sharma, Is it working as expected.

@Nishant, Please see the #4 comment.

shashank5563 → made their first commit to this issue’s fork.