Ahh, sorry, one thing is missing: Evaluation / review display.
Please implement the evaluationDisplay() method in the new plugin.
Looks great, tested the feedback version of the plugin and reviewed the code. Lack of automated test coverage will result in additional work for this so let's at least create a follow-up to add it.
Feel free to merge as this is a nice improvement, we can always create follow-ups if something else surfaces.
This seems to be fixed on 11.3-dev, 11.3.2 only seems to be buggy. Not sure about 11.x-dev, I'll keep watching.
This seems to be fixed on 11.3-dev, tests there pass currently.
If no one will beat me to it.. I don't expect to have time for that anytime soon and we're not going to upgrade the project that will be affected anytime soon, this was caught as a byproduct of checking a next major automated test fail.
graber → created an issue. See original summary → .
I don't think this is an LMS issue.. moving to LMS H5P.
Ahh, just a note: resave your views and export config all that experienced this, I had no time to write an update hook.
Thank you for creating this, we have Course and Lesson scheduling in plans that is somewhat related.
Is this still an issue on 4.4.x? 4.2.x is not supported.
Thank you for finding and handling this!
We should have test coverage for random activities feature, I'll create a follow-up.
Fixed, thanks for reporting this, now tests should catch any other issues with 8.1 as that's what's used with previous major.
I think it'll be better to fix this and stay compatible with 8.1. Can you confirm that's the only compatibility issue?
Thanks, checked and the test is indeed failing with the previous code, merging. It'll be good to extend test coverage even more, I'll write an issue next week.
I'm afraid no one will write those tests for a long time so I'll just release a fix and leave this open. I'll solve this in the action manager only by making sure $definition['type'] is always a string for later consistency.
Thank you for reporting and the initial work!
Fixed in 📌 Add more phpstan checks Fixed . Finally made it always a string.
Edge case as file usage doesn't delete files by default since a long time. Requires fixing nevertheless. The fix is much more simple though.
We should rather solve this in Drupal\views_bulk_operations\Service\ViewsBulkOperationsActionManager::findDefinitions() in such a way that $definition['confirm_form_route_name'] is always either NULL or a non-empty string.
Thank you for finding and reporting this!
I don't want fuzzy functions like empty() that can take anything as a parameter and behave in unpredictable ways, 4.4.x doesn't use them. Also if conditions should contain only expressions that evaluate to boolean type. Setting to needs work.
All good, I'll wait a bit before releasing this in case there's more. Thanks!