Considering factoring out classes to an optional module

Maybe I was a bit too fast with planning of moving the classes sub-module outside of the Drupal LMS repo as it can go out of sync at some point and will require splitting automated tests..

Ah yes I was thinking just an optional module in the main repo - at least to start with.

This will be more tricky as it'll break lms_membership_request → module. lms_membership_request → will now need 2 cases: lms_classes installed or not.
We should probably just do it without looking at lms_membership_request and update it when someone else decides to support the initiative and then update it?

I can do the work here as it doesn't look very scary but the membership request part may be a different thing.

Could lms_membership_request add a hard dependency on lms_classes?

I would think the non-class case would be pretty much raw https://www.drupal.org/project/grequest → or at least not far off? But if there's some extra things we want to add, that becomes a feature request against lms_membership_request rather than a bug then.

Pushed some WIP.

All green.

Needs human review & hopefully a bit of testing.

Tested this a bit.. without classes we have a very "vanilla" LMS where students / results view needs to be built.. Everything needed to do this (course status relationship, status and results link fields) is provided.

Will probably need additional docs in the lms_classes module and definitely a new minor bump release for lms_membership_request when this lands.

1 BC issue though: I couldn't figure out how to install the submodule in an update hook (anything results in missing lms_classes plugin) or even using Drush (unable to install due to existing config). Update path will be possible but tricky if there are no good ideas / existing examples, probably manually deleting the existing config and installing the module afterwards.

(unable to install due to existing config)

Can the config be moved to optional? That ought to not complain.

Added a stub module to 1.0.x, there'll be an additional step in the upgrade - enabling it. Can't seem to do it programatically, seems like \Drupal::service('module_installer')->install(['lms_classes']); is not enough..

Automatically closed - issue fixed for 2 weeks with no activity.