Move duplicate code in feedback plugins to a common trait

Created on 26 June 2025, 2 months ago

Problem/Motivation

The "with feedback" activity-answer plugins all have code in common, including the AJAX calls to show feedback. The duplicated code can be moved to a single abstract trait that is called by each plugin.

Best to do this before developing more plugins to reduce overall effort.

📌 Task
Status

Active

Version

1.0

Component

Activities and answers

Created by

🇨🇦Canada ob3ron Canada

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ob3ron
  • Merge request !111Resolve #3532652 "Move duplicate code" → (Open) created by Unnamed author
  • Pipeline finished with Success
    15 days ago
    #572398
  • Pipeline finished with Success
    15 days ago
    #572401
  • 🇨🇦Canada ob3ron Canada

    Tricky to get all four feedback plugins to work with a common trait, but we got there eventually!

  • First commit to issue fork.
  • 🇵🇱Poland Graber

    Feedback in the MR :)

  • Pipeline finished with Success
    3 days ago
    Total: 269s
    #581589
  • Assigned to ob3ron
  • Status changed to Needs review 3 days ago
  • 🇨🇦Canada ob3ron Canada

    Feedback incorporated!

  • 🇵🇱Poland Graber

    Just one more thing, either a regression or a pre-existing issue with the full text plugin. Should be fixed in the trait if possible so if validation fails when checking for feedback, it's visible on the screen regardless of the plugin used. More info on the MR.

  • Pipeline finished with Success
    2 days ago
    Total: 255s
    #582267
  • Pipeline finished with Success
    2 days ago
    Total: 290s
    #582511
  • 🇨🇦Canada ob3ron Canada

    Added minimum character validation in the AJAX callback, hopefully final fixes.

  • 🇵🇱Poland Graber

    Almost there ;)

  • Pipeline finished with Success
    about 10 hours ago
    Total: 284s
    #584492
  • Pipeline finished with Success
    about 10 hours ago
    Total: 268s
    #584499
  • Pipeline finished with Canceled
    about 9 hours ago
    Total: 543s
    #584500
  • 🇨🇦Canada ob3ron Canada

    Added all errors to feedback area.

  • Pipeline finished with Success
    about 9 hours ago
    Total: 277s
    #584505
Production build 0.71.5 2024