- Issue created by @alecsmrekar
- Merge request !10141Issue 3486797: Remove langcode condition in ws alias repo → (Closed) created by alecsmrekar
- 🇸🇮Slovenia alecsmrekar
Test failure does not seem related:
Drupal\Tests\comment\Functional\CommentPreviewTest 0 passes 94s 1 fails - 🇺🇸United States smustgrave
Thanks for reporting
Think next step will be to add test coverage showing the problem and that the change fixes it.
- 🇮🇳India shalini_jha
I have replicated this issue, and the merge request fixes it. I will work for the test coverage.
- 🇮🇳India shalini_jha
I have added test coverage for showing this issue, pipeline is green so moving this NR.
Kindly review.Failing test :
There was 1 failure: 1) Drupal\Tests\workspaces\Functional\PathWorkspacesTest::testPathAliasesWithTranslation Behat\Mink\Exception\ExpectationException: Current response status code is 404, but 200 expected. /var/www/html/vendor/behat/mink/src/WebAssert.php:888 /var/www/html/vendor/behat/mink/src/WebAssert.php:145 /var/www/html/core/modules/workspaces/tests/src/Functional/PathWorkspacesTest.php:345 /var/www/html/core/modules/workspaces/tests/src/Functional/PathWorkspacesTest.php:331 - 🇺🇸United States smustgrave
1) Drupal\Tests\workspaces\Functional\PathWorkspacesTest::testPathAliasesWithTranslation Behat\Mink\Exception\ExpectationException: Current response status code is 404, but 200 expected. /builds/issue/drupal-3486797/vendor/behat/mink/src/WebAssert.php:888 /builds/issue/drupal-3486797/vendor/behat/mink/src/WebAssert.php:145 /builds/issue/drupal-3486797/core/modules/workspaces/tests/src/Functional/PathWorkspacesTest.php:345 /builds/issue/drupal-3486797/core/modules/workspaces/tests/src/Functional/PathWorkspacesTest.php:331 FAILURES! Tests: 3, Assertions: 130, Failures: 1. Exiting with EXIT_CODE=1Test coverage appears to be there so removing that tag.
Reviewing code and nothing stands out.
- Status changed to RTBC
2 days ago 2:36pm 3 February 2025 - First commit to issue fork.
- 🇷🇴Romania amateescu
+1 for the RTBC. I added this in 🐛 Improve performance for path_alias queries in a workspace Active thinking that path aliases are translatable, but they're not :)
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x, and cherry-picked to 11.1.x, thanks!
This doesn't cherry-pick to 10.5 cleanly so leaving fixed against 11.1.x for now. If you strongly feel it needs a 10.5 backport, please re-open with a backport MR.